@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Reduce strength of Herald and user subscription stories
Summary:
Fixes T8952. When Herald changes subscribers, it is zzzzz very boring.
When users change subscribers, it is still super boring (more boring than a merge, for example).
Test Plan: Viewed feed, saw fewer Herald stories.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T8952
Differential Revision: https://secure.phabricator.com/D15774
+19
-1
+19
-1
src/applications/transactions/storage/PhabricatorApplicationTransaction.php
+19
-1
src/applications/transactions/storage/PhabricatorApplicationTransaction.php
···
1227
1227
// Make this weaker than TYPE_COMMENT.
1228
1228
return 0.25;
1229
1229
}
1230
-
break;
1230
+
1231
+
if ($this->isApplicationAuthor()) {
1232
+
// When applications (most often: Herald) change subscriptions it
1233
+
// is very uninteresting.
1234
+
return 0.000000001;
1235
+
}
1236
+
1237
+
// In other cases, subscriptions are more interesting than comments
1238
+
// (which are shown anyway) but less interesting than any other type of
1239
+
// transaction.
1240
+
return 0.75;
1231
1241
}
1232
1242
1233
1243
return 1.0;
···
1461
1471
1462
1472
return true;
1463
1473
}
1474
+
1475
+
private function isApplicationAuthor() {
1476
+
$author_phid = $this->getAuthorPHID();
1477
+
$author_type = phid_get_type($author_phid);
1478
+
$application_type = PhabricatorApplicationApplicationPHIDType::TYPECONST;
1479
+
return ($author_type == $application_type);
1480
+
}
1481
+
1464
1482
1465
1483
private function getInterestingMoves(array $moves) {
1466
1484
// Remove moves which only shift the position of a task within a column.