recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Passphrase Credential Secret field: Auto-select on click

Summary:
When looking at the Credential Secret you often probably want to copy it.
Highlight the entire string in the text field when clicking into the text field.

Closes T16520

Test Plan:
1. Go to http://phorge.localhost/passphrase/edit/?type=token
2. Set a `Name`, set some `Token`, click "Save"
3. On resulting http://phorge.localhost/K1, click "Show Secret"
4. In the dialog, click "Show Secret"
5. Click into the "Plaintext" field
6. See that Credential Secret value gets selected

Reviewers: O1 Blessed Committers, mainframe98

Reviewed By: O1 Blessed Committers, mainframe98

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16520

Differential Revision: https://we.phorge.it/D26791

Andre Klapper 942e90ad 0b986c08

+2
+2
src/applications/passphrase/controller/PassphraseCredentialRevealController.php
··· 42 42 } else if (!strlen($secret->openEnvelope())) { 43 43 $body = pht('This credential has an empty secret.'); 44 44 } else { 45 + Javelin::initBehavior('select-on-click'); 45 46 $body = id(new PHUIFormLayoutView()) 46 47 ->appendChild( 47 48 id(new AphrontFormTextAreaControl()) 48 49 ->setLabel(pht('Plaintext')) 49 50 ->setReadOnly(true) 51 + ->setSigil('select-on-click') 50 52 ->setCustomClass('PhabricatorMonospaced') 51 53 ->setHeight(AphrontFormTextAreaControl::HEIGHT_VERY_TALL) 52 54 ->setValue($secret->openEnvelope()));