@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix bad tables in diffusion blame

Summary: My fake data was 100%, and not all tables have full revision history. This leads to a broken table. Instead check if we have //any// revisions at all, then always show the column, with or without a link inside.

Test Plan: going on a limb this is the correct fix and test on secure... again ...

Reviewers: epriestley

Reviewed By: epriestley

Spies: Korvin

Differential Revision: https://secure.phabricator.com/D18474

+7 -13
+2 -2
resources/celerity/map.php
··· 74 74 'rsrc/css/application/diffusion/diffusion-icons.css' => '0c15255e', 75 75 'rsrc/css/application/diffusion/diffusion-readme.css' => '419dd5b6', 76 76 'rsrc/css/application/diffusion/diffusion-repository.css' => 'ee6f20ec', 77 - 'rsrc/css/application/diffusion/diffusion-source.css' => 'cb2bf02e', 77 + 'rsrc/css/application/diffusion/diffusion-source.css' => '47db8a7c', 78 78 'rsrc/css/application/diffusion/diffusion.css' => 'ceacf994', 79 79 'rsrc/css/application/feed/feed.css' => 'ecd4ec57', 80 80 'rsrc/css/application/files/global-drag-and-drop.css' => 'b556a948', ··· 574 574 'diffusion-icons-css' => '0c15255e', 575 575 'diffusion-readme-css' => '419dd5b6', 576 576 'diffusion-repository-css' => 'ee6f20ec', 577 - 'diffusion-source-css' => 'cb2bf02e', 577 + 'diffusion-source-css' => '47db8a7c', 578 578 'diviner-shared-css' => '896f1d43', 579 579 'font-fontawesome' => 'e838e088', 580 580 'font-lato' => 'c7ccd872',
+1 -1
src/applications/diffusion/controller/DiffusionBrowseController.php
··· 1183 1183 ), 1184 1184 $commit_link); 1185 1185 1186 - if ($revision_link) { 1186 + if ($revision_map) { 1187 1187 $row[] = phutil_tag( 1188 1188 'th', 1189 1189 array(
+4 -10
webroot/rsrc/css/application/diffusion/diffusion-source.css
··· 37 37 white-space: nowrap; 38 38 } 39 39 40 - .diffusion-blame-date { 40 + .diffusion-blame-date, 41 + .diffusion-blame-link, 42 + .diffusion-blame-revision, 43 + .diffusion-rev-link { 41 44 background: {$lightgreybackground}; 42 45 font: {$basefont}; 43 46 font-size: {$smallerfontsize}; 44 47 } 45 48 46 - .diffusion-blame-link, 47 - .diffusion-line-link, 48 - .diffusion-blame-revision { 49 - background: {$lightgreybackground}; 50 - } 51 - 52 49 .diffusion-source th.diffusion-rev-link { 53 50 text-align: left; 54 51 min-width: 130px; 55 - background: {$lightgreybackground}; 56 - font: {$basefont}; 57 - font-size: {$smallerfontsize}; 58 52 } 59 53 60 54 .diffusion-source a {