recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Make getApplicationTransactionEditor() in PhabricatorApplication return an editor

Summary:
Ref T12685. I provided this incorrect (`return new` rather than `throw`) implementation earlier; it can now be replaced with a proper implementation.

This caused application policy edits to spew this into the daemon log:

```
[2017-05-14 15:35:27] EXCEPTION: (Error) Call to undefined method PhutilMethodNotImplementedException::setActor() at [<phabricator>/src/applications/transactions/worker/PhabricatorApplicationTransactionPublishWorker.php:69]
```

Test Plan:
- Used `bin/worker execute --id <id>` to execute a previously-failing task.
- Saw a feed story publish.

Reviewers: chad, amckinley

Reviewed By: chad

Maniphest Tasks: T12685

Differential Revision: https://secure.phabricator.com/D17876

epriestley 95925ad5 aa819799

+1 -1
+1 -1
src/applications/base/PhabricatorApplication.php
··· 642 642 643 643 644 644 public function getApplicationTransactionEditor() { 645 - return new PhutilMethodNotImplementedException(pht('Coming Soon!')); 645 + return new PhabricatorApplicationEditor(); 646 646 } 647 647 648 648 public function getApplicationTransactionObject() {