@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Allow "arc diff --draft" to create revisions as drafts more forcefully
Summary:
Depends on D18771. See PHI206. Currently, `arc diff --draft` only holds revisions in draft mode: it doesn't put them into draft mode if the install isn't configured to use draft mode.
Instead, make it a bit more forceful so that `arc diff --draft` can create into draft mode explicitly even if protoypes are off. This aligns with expection a little more clearly.
Test Plan: Ran `arc diff --draft` with prototypes off, got a revision held in draft mode.
Reviewers: amckinley
Reviewed By: amckinley
Differential Revision: https://secure.phabricator.com/D18772
+9
+9
src/applications/differential/xaction/DifferentialRevisionHoldDraftTransaction.php
+9
src/applications/differential/xaction/DifferentialRevisionHoldDraftTransaction.php
···
16
16
17
17
public function applyInternalEffects($object, $value) {
18
18
$object->setHoldAsDraft($value);
19
+
20
+
// If draft isn't the default state but we're creating a new revision
21
+
// and holding it as a draft, put it in draft mode. See PHI206.
22
+
// TODO: This can probably be removed once Draft is the universal default.
23
+
if ($this->isNewObject()) {
24
+
if ($object->isNeedsReview()) {
25
+
$object->setModernRevisionStatus(DifferentialRevisionStatus::DRAFT);
26
+
}
27
+
}
19
28
}
20
29
21
30
public function getTitle() {