@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
render_tag -> tag: fix some more callsites
Summary:
- Crumbs is straightforward.
- Maniphest does a lot of string construction which isn't i18n or safehtml aware. I cheated under the theory that we'll resolve this properly in {T2217}.
Test Plan: Looked at crumbs and Maniphest.
Reviewers: vrana
Reviewed By: vrana
CC: aran
Maniphest Tasks: T2432
Differential Revision: https://secure.phabricator.com/D4748
+24
-7
+16
-2
src/applications/maniphest/view/ManiphestTransactionDetailView.php
+16
-2
src/applications/maniphest/view/ManiphestTransactionDetailView.php
···
164
164
if ($this->getRenderFullSummary()) {
165
165
$full_summary = $this->renderFullSummary($transaction);
166
166
}
167
-
$descs[] = javelin_render_tag(
167
+
$descs[] = javelin_tag(
168
168
'div',
169
169
array(
170
170
'sigil' => 'maniphest-transaction-description',
171
171
),
172
-
$author->renderLink().' '.$desc.'.'.$full_summary);
172
+
array(
173
+
$author->renderLink(),
174
+
' ',
175
+
$desc,
176
+
'.',
177
+
$full_summary,
178
+
));
173
179
}
174
180
175
181
if ($this->getRenderSummaryOnly()) {
···
551
557
return array($type, ' brazenly '.$type."'d", $classes);
552
558
}
553
559
560
+
// TODO: [HTML] This code will all be rewritten when we switch to using
561
+
// ApplicationTransactions. It does not handle HTML or translations
562
+
// correctly right now.
563
+
$desc = phutil_safe_html($desc);
564
+
554
565
return array($verb, $desc, $classes);
555
566
}
556
567
···
578
589
list($range_s, $range_e, $mask) =
579
590
DifferentialChangesetParser::parseRangeSpecification($spec);
580
591
$output = $parser->render($range_s, $range_e, $mask);
592
+
593
+
// TODO: [HTML] DifferentialChangesetParser needs cleanup.
594
+
$output = phutil_safe_html($output);
581
595
582
596
return $output;
583
597
}
+8
-5
src/view/layout/PhabricatorCrumbsView.php
+8
-5
src/view/layout/PhabricatorCrumbsView.php
···
50
50
));
51
51
}
52
52
53
-
$action_view = phutil_render_tag(
53
+
$action_view = phutil_tag(
54
54
'div',
55
55
array(
56
56
'class' => 'phabricator-crumbs-actions',
57
57
),
58
-
self::renderSingleView($actions));
58
+
$this->renderHTMLView($actions));
59
59
}
60
60
61
61
if ($this->crumbs) {
62
62
last($this->crumbs)->setIsLastCrumb(true);
63
63
}
64
64
65
-
return phutil_render_tag(
65
+
return phutil_tag(
66
66
'div',
67
67
array(
68
68
'class' => 'phabricator-crumbs-view '.
69
69
'sprite-gradient gradient-breadcrumbs',
70
70
),
71
-
$action_view.
72
-
self::renderSingleView($this->crumbs));
71
+
$this->renderHTMLView(
72
+
array(
73
+
$action_view,
74
+
$this->crumbs,
75
+
)));
73
76
}
74
77
75
78
}