@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Try to get to the bottom of the sporradic test failures in testColumnExtendedPolicies()
Summary:
This test has been failing occasionally in a way that does not reproduce, and only when no one is looking at it.
Try to add some extra assertions to maybe get more information.
Test Plan: `arc unit`
Reviewers: chad
Reviewed By: chad
Differential Revision: https://secure.phabricator.com/D16137
+12
+12
src/applications/project/__tests__/PhabricatorProjectCoreTestCase.php
+12
src/applications/project/__tests__/PhabricatorProjectCoreTestCase.php
···
1099
1099
$column = $this->refreshColumn($user, $column);
1100
1100
$this->assertTrue((bool)$column);
1101
1101
1102
+
// This test has been failing randomly in a way that doesn't reproduce
1103
+
// on any host, so add some extra assertions to try to nail it down.
1104
+
$board = $this->refreshProject($board, $user, true);
1105
+
$this->assertTrue((bool)$board);
1106
+
$this->assertTrue($board->isUserMember($user->getPHID()));
1107
+
1108
+
$can_view = PhabricatorPolicyFilter::hasCapability(
1109
+
$user,
1110
+
$column,
1111
+
PhabricatorPolicyCapability::CAN_VIEW);
1112
+
$this->assertTrue($can_view);
1113
+
1102
1114
$can_edit = PhabricatorPolicyFilter::hasCapability(
1103
1115
$user,
1104
1116
$column,