@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Update Settings for newPage
Summary: Converts over to `newPage`
Test Plan: Pull up Settings panel, test a few.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D15625
+8
-10
+8
-10
src/applications/settings/controller/PhabricatorSettingsMainController.php
+8
-10
src/applications/settings/controller/PhabricatorSettingsMainController.php
···
61
61
'/p/'.$this->getUser()->getUsername().'/');
62
62
}
63
63
$crumbs->addTextCrumb($panel->getPanelName());
64
-
$nav->appendChild(
65
-
array(
66
-
$crumbs,
67
-
$response,
68
-
));
64
+
$nav->appendChild($response);
69
65
70
-
return $this->buildApplicationPage(
71
-
$nav,
72
-
array(
73
-
'title' => $panel->getPanelName(),
74
-
));
66
+
$title = $panel->getPanelName();
67
+
68
+
return $this->newPage()
69
+
->setTitle($title)
70
+
->setCrumbs($crumbs)
71
+
->setNavigation($nav);
72
+
75
73
}
76
74
77
75
private function buildPanels() {