@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Make closed vs open objects in object graphs more obvious
Summary: Ref T4788. It's not easy to tell at a glance which objects are open vs closed. Try to make that a bit more clear. This could probably use some more tweaking.
Test Plan: {F1708330}
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T4788
Differential Revision: https://secure.phabricator.com/D16219
+47
-9
+3
-3
resources/celerity/map.php
+3
-3
resources/celerity/map.php
···
7
7
*/
8
8
return array(
9
9
'names' => array(
10
-
'core.pkg.css' => '2cc8508b',
10
+
'core.pkg.css' => '93eb0544',
11
11
'core.pkg.js' => 'f2139810',
12
12
'darkconsole.pkg.js' => 'e7393ebb',
13
13
'differential.pkg.css' => '3e81ae60',
···
25
25
'rsrc/css/aphront/notification.css' => '3f6c89c9',
26
26
'rsrc/css/aphront/panel-view.css' => '8427b78d',
27
27
'rsrc/css/aphront/phabricator-nav-view.css' => 'ac79a758',
28
-
'rsrc/css/aphront/table-view.css' => '9258e19f',
28
+
'rsrc/css/aphront/table-view.css' => '2596314c',
29
29
'rsrc/css/aphront/tokenizer.css' => '056da01b',
30
30
'rsrc/css/aphront/tooltip.css' => '1a07aea8',
31
31
'rsrc/css/aphront/typeahead-browse.css' => '8904346a',
···
536
536
'aphront-list-filter-view-css' => '5d6f0526',
537
537
'aphront-multi-column-view-css' => 'fd18389d',
538
538
'aphront-panel-view-css' => '8427b78d',
539
-
'aphront-table-view-css' => '9258e19f',
539
+
'aphront-table-view-css' => '2596314c',
540
540
'aphront-tokenizer-control-css' => '056da01b',
541
541
'aphront-tooltip-css' => '1a07aea8',
542
542
'aphront-typeahead-control-css' => 'd4f16145',
+6
-2
src/infrastructure/graph/DifferentialRevisionGraph.php
+6
-2
src/infrastructure/graph/DifferentialRevisionGraph.php
···
18
18
return new DifferentialRevisionQuery();
19
19
}
20
20
21
+
protected function isClosed($object) {
22
+
return $object->isClosed();
23
+
}
24
+
21
25
protected function newTableRow($phid, $object, $trace) {
22
26
$viewer = $this->getViewer();
23
27
···
68
72
->setColumnClasses(
69
73
array(
70
74
'threads',
71
-
null,
75
+
'graph-status',
72
76
null,
73
-
'wide',
77
+
'wide object-link',
74
78
));
75
79
}
76
80
+6
-2
src/infrastructure/graph/ManiphestTaskGraph.php
+6
-2
src/infrastructure/graph/ManiphestTaskGraph.php
···
18
18
return new ManiphestTaskQuery();
19
19
}
20
20
21
+
protected function isClosed($object) {
22
+
return $object->isClosed();
23
+
}
24
+
21
25
protected function newTableRow($phid, $object, $trace) {
22
26
$viewer = $this->getViewer();
23
27
···
78
82
->setColumnClasses(
79
83
array(
80
84
'threads',
81
-
null,
85
+
'graph-status',
82
86
null,
83
-
'wide',
87
+
'wide object-link',
84
88
));
85
89
}
86
90
+17
-2
src/infrastructure/graph/PhabricatorObjectGraph.php
+17
-2
src/infrastructure/graph/PhabricatorObjectGraph.php
···
28
28
abstract protected function newQuery();
29
29
abstract protected function newTableRow($phid, $object, $trace);
30
30
abstract protected function newTable(AphrontTableView $table);
31
+
abstract protected function isClosed($object);
31
32
32
33
final public function setSeedPHID($phid) {
33
34
$this->seedPHID = $phid;
···
132
133
$object = idx($objects, $phid);
133
134
$rows[] = $this->newTableRow($phid, $object, $traces[$ii++]);
134
135
136
+
$classes = array();
135
137
if ($phid == $this->seedPHID) {
136
-
$rowc[] = 'highlighted';
138
+
$classes[] = 'highlighted';
139
+
}
140
+
141
+
if ($object) {
142
+
if ($this->isClosed($object)) {
143
+
$classes[] = 'closed';
144
+
}
145
+
}
146
+
147
+
if ($classes) {
148
+
$classes = implode(' ', $classes);
137
149
} else {
138
-
$rowc[] = null;
150
+
$classes = null;
139
151
}
152
+
153
+
$rowc[] = $classes;
140
154
}
141
155
142
156
$table = id(new AphrontTableView($rows))
157
+
->setClassName('object-graph-table')
143
158
->setRowClasses($rowc);
144
159
145
160
$this->objects = $objects;
+15
webroot/rsrc/css/aphront/table-view.css
+15
webroot/rsrc/css/aphront/table-view.css
···
228
228
position: static;
229
229
}
230
230
231
+
.aphront-table-view tr.closed td.object-link a,
232
+
.aphront-table-view tr.alt-closed td.object-link a {
233
+
text-decoration: line-through;
234
+
color: rgba({$alphablack}, 0.5);
235
+
}
236
+
237
+
.aphront-table-view tr.closed td.graph-status,
238
+
.aphront-table-view tr.alt-closed td.graph-status {
239
+
opacity: 0.5;
240
+
}
241
+
242
+
.object-graph-table em {
243
+
color: {$lightgreytext};
244
+
}
245
+
231
246
.aphront-table-view tr.highlighted {
232
247
background: #fdf9e4;
233
248
}