@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Update Facts for handleRequest
Summary: Updated Facts Controllers
Test Plan: Viewed Facts
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: epriestley, Korvin
Differential Revision: https://secure.phabricator.com/D13733
+7
-9
+2
-3
src/applications/fact/controller/PhabricatorFactChartController.php
+2
-3
src/applications/fact/controller/PhabricatorFactChartController.php
···
2
2
3
3
final class PhabricatorFactChartController extends PhabricatorFactController {
4
4
5
-
public function processRequest() {
6
-
$request = $this->getRequest();
7
-
$user = $request->getUser();
5
+
public function handleRequest(AphrontRequest $request) {
6
+
$viewer = $request->getViewer();
8
7
9
8
$table = new PhabricatorFactRaw();
10
9
$conn_r = $table->establishConnection('r');
+5
-6
src/applications/fact/controller/PhabricatorFactHomeController.php
+5
-6
src/applications/fact/controller/PhabricatorFactHomeController.php
···
6
6
return true;
7
7
}
8
8
9
-
public function processRequest() {
10
-
$request = $this->getRequest();
11
-
$user = $request->getUser();
9
+
public function handleRequest(AphrontRequest $request) {
10
+
$viewer = $request->getViewer();
12
11
13
12
if ($request->isFormPost()) {
14
13
$uri = new PhutilURI('/fact/chart/');
···
34
33
$spec = $specs[$fact->getFactType()];
35
34
36
35
$name = $spec->getName();
37
-
$value = $spec->formatValueForDisplay($user, $fact->getValueX());
36
+
$value = $spec->formatValueForDisplay($viewer, $fact->getValueX());
38
37
39
38
$rows[] = array($name, $value);
40
39
}
···
73
72
74
73
private function buildChartForm() {
75
74
$request = $this->getRequest();
76
-
$user = $request->getUser();
75
+
$viewer = $request->getUser();
77
76
78
77
$table = new PhabricatorFactRaw();
79
78
$conn_r = $table->establishConnection('r');
···
106
105
}
107
106
108
107
$form = id(new AphrontFormView())
109
-
->setUser($user)
108
+
->setUser($viewer)
110
109
->appendChild(
111
110
id(new AphrontFormSelectControl())
112
111
->setLabel(pht('Y-Axis'))