@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Don't require "CAN_EDIT" to watch/unwatch a project
Summary:
See T1024. When "CAN_EDIT" became default in T13186, this was missed as an exception.
Watching shouldn't require "CAN_EDIT", so exempt it.
Test Plan:
- Before change: tried to watch a project I could not edit, got a policy error.
- After change: watched/unwatched a project I could not edit.
Reviewers: amckinley
Reviewed By: amckinley
Differential Revision: https://secure.phabricator.com/D19977
+3
+3
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
+3
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
···
1677
1677
1678
1678
// You need CAN_EDIT to change members other than yourself.
1679
1679
return PhabricatorPolicyCapability::CAN_EDIT;
1680
+
case PhabricatorObjectHasWatcherEdgeType::EDGECONST:
1681
+
// See PHI1024. Watching a project does not require CAN_EDIT.
1682
+
return null;
1680
1683
default:
1681
1684
return PhabricatorPolicyCapability::CAN_EDIT;
1682
1685
}