@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Update typeahead for new UI
Summary: Uses modern UI, `newPage`, etc. Changes table behavior to always scroll if too large for container, can't find anything this breaks, but be on the lookout.
Test Plan: Pull up help and view pages, search for some people and projects.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D15611
+24
-20
+3
-3
resources/celerity/map.php
+3
-3
resources/celerity/map.php
···
7
7
*/
8
8
return array(
9
9
'names' => array(
10
-
'core.pkg.css' => '5de0f7af',
10
+
'core.pkg.css' => 'a3016dac',
11
11
'core.pkg.js' => 'e5484f37',
12
12
'darkconsole.pkg.js' => 'e7393ebb',
13
13
'differential.pkg.css' => '7ba78475',
···
25
25
'rsrc/css/aphront/notification.css' => '7f684b62',
26
26
'rsrc/css/aphront/panel-view.css' => '8427b78d',
27
27
'rsrc/css/aphront/phabricator-nav-view.css' => 'ac79a758',
28
-
'rsrc/css/aphront/table-view.css' => '036b6cdc',
28
+
'rsrc/css/aphront/table-view.css' => '9258e19f',
29
29
'rsrc/css/aphront/tokenizer.css' => '056da01b',
30
30
'rsrc/css/aphront/tooltip.css' => '1a07aea8',
31
31
'rsrc/css/aphront/typeahead-browse.css' => 'd8581d2c',
···
526
526
'aphront-list-filter-view-css' => '5d6f0526',
527
527
'aphront-multi-column-view-css' => 'fd18389d',
528
528
'aphront-panel-view-css' => '8427b78d',
529
-
'aphront-table-view-css' => '036b6cdc',
529
+
'aphront-table-view-css' => '9258e19f',
530
530
'aphront-tokenizer-control-css' => '056da01b',
531
531
'aphront-tooltip-css' => '1a07aea8',
532
532
'aphront-typeahead-control-css' => 'd4f16145',
+6
-9
src/applications/typeahead/controller/PhabricatorTypeaheadFunctionHelpController.php
+6
-9
src/applications/typeahead/controller/PhabricatorTypeaheadFunctionHelpController.php
···
126
126
$header = id(new PHUIHeaderView())
127
127
->setHeader($title);
128
128
129
-
$document = id(new PHUIDocumentView())
129
+
$document = id(new PHUIDocumentViewPro())
130
130
->setHeader($header)
131
131
->appendChild($content_box);
132
132
133
133
$crumbs = $this->buildApplicationCrumbs();
134
134
$crumbs->addTextCrumb(pht('Function Help'));
135
+
$crumbs->setBorder(true);
135
136
136
-
return $this->buildApplicationPage(
137
-
array(
138
-
$crumbs,
139
-
$document,
140
-
),
141
-
array(
142
-
'title' => $title,
143
-
));
137
+
return $this->newPage()
138
+
->setTitle($title)
139
+
->setCrumbs($crumbs)
140
+
->appendChild($document);
144
141
}
145
142
146
143
}
+14
-6
src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php
+14
-6
src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php
···
309
309
310
310
$form_box = id(new PHUIObjectBoxView())
311
311
->setHeaderText(pht('Token Query'))
312
+
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
312
313
->setForm($form);
313
314
314
315
$table = new AphrontTableView($content);
···
329
330
330
331
$result_box = id(new PHUIObjectBoxView())
331
332
->setHeaderText(pht('Token Results (%s)', $class))
333
+
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
332
334
->appendChild($table);
333
335
334
-
return $this->buildApplicationPage(
335
-
array(
336
+
$title = pht('Typeahead Results');
337
+
338
+
$header = id(new PHUIHeaderView())
339
+
->setHeader($title);
340
+
341
+
$view = id(new PHUITwoColumnView())
342
+
->setHeader($header)
343
+
->setFooter(array(
336
344
$form_box,
337
345
$result_box,
338
-
),
339
-
array(
340
-
'title' => pht('Typeahead Results'),
341
-
'device' => false,
342
346
));
347
+
348
+
return $this->newPage()
349
+
->setTitle($title)
350
+
->appendChild($view);
343
351
}
344
352
345
353
}