@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove setup check for safe_mode removed in PHP 5.4
Summary:
Phorge requires PHP 7.2 so don't check for stuff removed in PHP 5.4.
See https://www.php.net/releases/5_4_0.php and https://web.archive.org/web/20190217003515/https://php.net/features.safe-mode
Test Plan: Set up Phorge, I'd guess.
Reviewers: O1 Blessed Committers, mainframe98, avivey
Reviewed By: O1 Blessed Committers, mainframe98, avivey
Subscribers: mainframe98, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Differential Revision: https://we.phorge.it/D25947
-19
-19
src/applications/config/check/PhabricatorPHPPreflightSetupCheck.php
-19
src/applications/config/check/PhabricatorPHPPreflightSetupCheck.php
···
11
11
}
12
12
13
13
protected function executeChecks() {
14
-
// TODO: This can be removed entirely because the minimum PHP version is
15
-
// now PHP 5.5, which does not have safe mode.
16
-
17
-
$safe_mode = ini_get('safe_mode');
18
-
if ($safe_mode) {
19
-
$message = pht(
20
-
"You have '%s' enabled in your PHP configuration, but this software ".
21
-
"will not run in safe mode. Safe mode has been deprecated in PHP 5.3 ".
22
-
"and removed in PHP 5.4.\n\nDisable safe mode to continue.",
23
-
'safe_mode');
24
-
25
-
$this->newIssue('php.safe_mode')
26
-
->setIsFatal(true)
27
-
->setName(pht('Disable PHP %s', 'safe_mode'))
28
-
->setMessage($message)
29
-
->addPHPConfig('safe_mode');
30
-
return;
31
-
}
32
-
33
14
// Check for `disable_functions` or `disable_classes`. Although it's
34
15
// possible to disable a bunch of functions (say, `array_change_key_case()`)
35
16
// and classes and still have Phabricator work fine, it's unreasonably