@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix custom field selector control in cases where the user doesn't edit anything
Summary: The JS and PHP representations of state can differ; just have the JS write the state out immediately on page load.
Test Plan: Saved `diffusion.fields` without making changes, reloaded, saw no effective change.
Reviewers: joshuaspence
Reviewed By: joshuaspence
Subscribers: epriestley
Differential Revision: https://secure.phabricator.com/D12998
+11
-13
+9
-9
resources/celerity/map.php
+9
-9
resources/celerity/map.php
···
333
333
'rsrc/js/application/auth/behavior-persona-login.js' => '9414ff18',
334
334
'rsrc/js/application/calendar/behavior-day-view.js' => '5c46cff2',
335
335
'rsrc/js/application/calendar/behavior-event-all-day.js' => '38dcf3c8',
336
-
'rsrc/js/application/config/behavior-reorder-fields.js' => '14a827de',
336
+
'rsrc/js/application/config/behavior-reorder-fields.js' => 'b6993408',
337
337
'rsrc/js/application/conpherence/ConpherenceThreadManager.js' => '10246726',
338
338
'rsrc/js/application/conpherence/behavior-drag-and-drop-photo.js' => 'cf86d16a',
339
339
'rsrc/js/application/conpherence/behavior-durable-column.js' => '16c695bf',
···
543
543
'javelin-behavior-audio-source' => '59b251eb',
544
544
'javelin-behavior-audit-preview' => 'd835b03a',
545
545
'javelin-behavior-choose-control' => '6153c708',
546
-
'javelin-behavior-config-reorder-fields' => '14a827de',
546
+
'javelin-behavior-config-reorder-fields' => 'b6993408',
547
547
'javelin-behavior-conpherence-drag-and-drop-photo' => 'cf86d16a',
548
548
'javelin-behavior-conpherence-menu' => 'c0348cac',
549
549
'javelin-behavior-conpherence-pontificate' => '21ba5861',
···
906
906
'javelin-stratcom',
907
907
'javelin-dom',
908
908
'javelin-history',
909
-
),
910
-
'14a827de' => array(
911
-
'javelin-behavior',
912
-
'javelin-stratcom',
913
-
'javelin-dom',
914
-
'javelin-json',
915
-
'phabricator-draggable-list',
916
909
),
917
910
'14ac66f5' => array(
918
911
'javelin-install',
···
1727
1720
'javelin-stratcom',
1728
1721
'javelin-dom',
1729
1722
'javelin-util',
1723
+
),
1724
+
'b6993408' => array(
1725
+
'javelin-behavior',
1726
+
'javelin-stratcom',
1727
+
'javelin-dom',
1728
+
'javelin-json',
1729
+
'phabricator-draggable-list',
1730
1730
),
1731
1731
'ba4fa35c' => array(
1732
1732
'javelin-behavior',
+1
-4
src/infrastructure/customfield/config/PhabricatorCustomFieldConfigOptionType.php
+1
-4
src/infrastructure/customfield/config/PhabricatorCustomFieldConfigOptionType.php
···
12
12
$storage_value = $request->getStr('value');
13
13
14
14
$in_value = phutil_json_decode($storage_value);
15
-
if (!is_array($in_value)) {
16
-
$in_value = array();
17
-
}
18
15
19
16
// When we submit from JS, we submit a list (since maps are not guaranteed
20
17
// to retain order). Convert it into a map for storage (since it's far more
···
113
110
'id' => $input_id,
114
111
'type' => 'hidden',
115
112
'name' => 'value',
116
-
'value' => json_encode($display_value),
113
+
'value' => '',
117
114
));
118
115
119
116
Javelin::initBehavior(