@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Link "continue" action to confirm dialog in bulk jobs that are unconfirmed
Summary: See Q266.
Test Plan: Created a bulk job, clicked "Details" instead of "Confirm", clicked "Continue" to get back to confirmation dialog.
Reviewers: chad
Reviewed By: chad
Differential Revision: https://secure.phabricator.com/D14985
+11
-1
+7
-1
src/applications/daemon/controller/PhabricatorDaemonBulkJobViewController.php
+7
-1
src/applications/daemon/controller/PhabricatorDaemonBulkJobViewController.php
···
71
71
->setUser($viewer)
72
72
->setObject($job);
73
73
74
+
if ($job->isConfirming()) {
75
+
$continue_uri = $job->getMonitorURI();
76
+
} else {
77
+
$continue_uri = $job->getDoneURI();
78
+
}
79
+
74
80
$actions->addAction(
75
81
id(new PhabricatorActionView())
76
-
->setHref($job->getDoneURI())
82
+
->setHref($continue_uri)
77
83
->setIcon('fa-arrow-circle-o-right')
78
84
->setName(pht('Continue')));
79
85
+4
src/infrastructure/daemon/workers/storage/PhabricatorWorkerBulkJob.php
+4
src/infrastructure/daemon/workers/storage/PhabricatorWorkerBulkJob.php
···
130
130
return idx($map, $this->getStatus(), $this->getStatus());
131
131
}
132
132
133
+
public function isConfirming() {
134
+
return ($this->getStatus() == self::STATUS_CONFIRM);
135
+
}
136
+
133
137
134
138
/* -( Job Implementation )------------------------------------------------- */
135
139