@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Bring up contrast on light green / red diffs

Summary: Minor color saturation here, ideal for low quality monitors.

Test Plan:
Review new colors in various scenarios.

{F2305178}

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D17141

+34 -12
+6 -6
resources/celerity/map.php
··· 12 12 'core.pkg.css' => '9c725fa0', 13 13 'core.pkg.js' => 'f998932d', 14 14 'darkconsole.pkg.js' => 'e7393ebb', 15 - 'differential.pkg.css' => '13726e1c', 15 + 'differential.pkg.css' => 'f69afb45', 16 16 'differential.pkg.js' => '40b18f35', 17 17 'diffusion.pkg.css' => '91c5d3a6', 18 18 'diffusion.pkg.js' => '84c8f8fd', ··· 59 59 'rsrc/css/application/dashboard/dashboard.css' => 'bc6f2127', 60 60 'rsrc/css/application/diff/inline-comment-summary.css' => '51efda3a', 61 61 'rsrc/css/application/differential/add-comment.css' => 'c47f8c40', 62 - 'rsrc/css/application/differential/changeset-view.css' => '6d0fc277', 62 + 'rsrc/css/application/differential/changeset-view.css' => '11395d9c', 63 63 'rsrc/css/application/differential/core.css' => '5b7b8ff4', 64 64 'rsrc/css/application/differential/phui-inline-comment.css' => '5953c28e', 65 65 'rsrc/css/application/differential/revision-comment.css' => '14b8565a', ··· 574 574 'conpherence-thread-manager' => 'c8b5ee6f', 575 575 'conpherence-transaction-css' => '85129c68', 576 576 'd3' => 'a11a5ff2', 577 - 'differential-changeset-view-css' => '6d0fc277', 577 + 'differential-changeset-view-css' => '11395d9c', 578 578 'differential-core-view-css' => '5b7b8ff4', 579 579 'differential-inline-comment-editor' => '2e3f9738', 580 580 'differential-revision-add-comment-css' => 'c47f8c40', ··· 1032 1032 'javelin-dom', 1033 1033 'javelin-typeahead-normalizer', 1034 1034 ), 1035 + '11395d9c' => array( 1036 + 'phui-inline-comment-view-css', 1037 + ), 1035 1038 '12884df9' => array( 1036 1039 'javelin-behavior', 1037 1040 'javelin-stratcom', ··· 1454 1457 '6c2b09a2' => array( 1455 1458 'javelin-install', 1456 1459 'javelin-util', 1457 - ), 1458 - '6d0fc277' => array( 1459 - 'phui-inline-comment-view-css', 1460 1460 ), 1461 1461 '6d3e1947' => array( 1462 1462 'javelin-behavior',
+16 -4
src/applications/differential/render/DifferentialChangesetOneUpRenderer.php
··· 97 97 $line = array($hidden, $line); 98 98 } 99 99 100 - $cells[] = phutil_tag('th', array('id' => $left_id), $line); 100 + $cells[] = phutil_tag( 101 + 'th', 102 + array( 103 + 'id' => $left_id, 104 + 'class' => $class, 105 + ), 106 + $line); 101 107 102 - $cells[] = phutil_tag('th', array()); 108 + $cells[] = phutil_tag('th', array('class' => $class)); 103 109 $cells[] = $no_copy; 104 110 $cells[] = phutil_tag('td', array('class' => $class), $p['render']); 105 111 $cells[] = $no_coverage; 106 112 } else { 107 113 if ($p['htype']) { 108 114 $class = 'right new'; 109 - $cells[] = phutil_tag('th', array()); 115 + $cells[] = phutil_tag('th', array('class' => $class)); 110 116 } else { 111 117 $class = 'right'; 112 118 if ($left_prefix) { ··· 138 144 $line = array($hidden, $line); 139 145 } 140 146 141 - $cells[] = phutil_tag('th', array('id' => $right_id), $line); 147 + $cells[] = phutil_tag( 148 + 'th', 149 + array( 150 + 'id' => $right_id, 151 + 'class' => $class, 152 + ), 153 + $line); 142 154 143 155 $cells[] = $no_copy; 144 156 $cells[] = phutil_tag('td', array('class' => $class), $p['render']);
+2 -2
src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php
··· 306 306 $zero_space = "\xE2\x80\x8B"; 307 307 308 308 $html[] = phutil_tag('tr', array(), array( 309 - phutil_tag('th', array('id' => $o_id), $o_num), 309 + phutil_tag('th', array('id' => $o_id, 'class' => $o_classes), $o_num), 310 310 phutil_tag('td', array('class' => $o_classes), $o_text), 311 - phutil_tag('th', array('id' => $n_id), $n_num), 311 + phutil_tag('th', array('id' => $n_id, 'class' => $n_classes), $n_num), 312 312 $n_copy, 313 313 phutil_tag( 314 314 'td',
+10
webroot/rsrc/css/application/differential/changeset-view.css
··· 121 121 cursor: auto; 122 122 } 123 123 124 + .differential-diff th.old { 125 + background: #ffdddd; 126 + border-right-color: #f8cbcb; 127 + } 128 + 129 + .differential-diff th.new { 130 + background: #dbffdb; 131 + border-right-color: #a6f3a6; 132 + } 133 + 124 134 .differential-diff td.old, 125 135 .differential-diff td.old-full { 126 136 background: #ffecec;