@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Increase CSS specificity on Inline Comment Summary

Summary: Fixes T8354. Adds a class to each `th` and `td` for specificity.

Test Plan: Write a large table as an inline comment, see it wraps property on smaller screens.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T8354

Differential Revision: https://secure.phabricator.com/D13076

+13 -8
+3 -3
resources/celerity/map.php
··· 10 10 'core.pkg.css' => 'e2460e8f', 11 11 'core.pkg.js' => '3bbe23c6', 12 12 'darkconsole.pkg.js' => 'e7393ebb', 13 - 'differential.pkg.css' => '30602b8c', 13 + 'differential.pkg.css' => '02273347', 14 14 'differential.pkg.js' => 'ebef29b1', 15 15 'diffusion.pkg.css' => '591664fa', 16 16 'diffusion.pkg.js' => '0115b37c', ··· 56 56 'rsrc/css/application/contentsource/content-source-view.css' => '4b8b05d4', 57 57 'rsrc/css/application/countdown/timer.css' => '86b7b0a0', 58 58 'rsrc/css/application/dashboard/dashboard.css' => '17937d22', 59 - 'rsrc/css/application/diff/inline-comment-summary.css' => 'eb5f8e8c', 59 + 'rsrc/css/application/diff/inline-comment-summary.css' => '51efda3a', 60 60 'rsrc/css/application/differential/add-comment.css' => 'c47f8c40', 61 61 'rsrc/css/application/differential/changeset-view.css' => 'e19cfd6e', 62 62 'rsrc/css/application/differential/core.css' => '7ac3cabc', ··· 530 530 'herald-rule-editor' => '271ffdd7', 531 531 'herald-test-css' => '778b008e', 532 532 'homepage-panel-css' => 'e34bf140', 533 - 'inline-comment-summary-css' => 'eb5f8e8c', 533 + 'inline-comment-summary-css' => '51efda3a', 534 534 'javelin-aphlict' => '5359e785', 535 535 'javelin-behavior' => '61cbc29a', 536 536 'javelin-behavior-aphlict-dropdown' => '995ad707',
+8 -3
src/infrastructure/diff/view/PhabricatorInlineSummaryView.php
··· 36 36 'th', 37 37 array( 38 38 'colspan' => 3, 39 + 'class' => 'inline-comment-summary-table-header', 39 40 ), 40 41 array( 41 42 $icon, ··· 87 88 'tr', 88 89 array(), 89 90 array( 90 - phutil_tag('td', array('class' => 'inline-line-number'), $lines), 91 + phutil_tag('td', 92 + array('class' => 'inline-line-number inline-table-dolumn'), 93 + $lines), 91 94 ($has_where 92 - ? phutil_tag('td', array('class' => 'inline-which-diff'), $where) 95 + ? phutil_tag('td', 96 + array('class' => 'inline-which-diff inline-table-dolumn'), 97 + $where) 93 98 : null), 94 99 phutil_tag( 95 100 'td', 96 101 array( 97 - 'class' => 'inline-summary-content', 102 + 'class' => 'inline-summary-content inline-table-dolumn', 98 103 'colspan' => $colspan, 99 104 ), 100 105 phutil_tag_div('phabricator-remarkup', $item['content'])),
+2 -2
webroot/rsrc/css/application/diff/inline-comment-summary.css
··· 13 13 margin-top: -16px; 14 14 } 15 15 16 - .phabricator-inline-summary-table th { 16 + .phabricator-inline-summary-table .inline-comment-summary-table-header { 17 17 font-weight: bold; 18 18 padding: 16px 1px 8px; 19 19 background: #fff; ··· 21 21 border-bottom: 1px solid {$thinblueborder}; 22 22 } 23 23 24 - .phabricator-inline-summary-table td { 24 + .phabricator-inline-summary-table .inline-table-dolumn { 25 25 padding: 4px 8px; 26 26 white-space: nowrap; 27 27 color: {$darkbluetext};