@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Modernize Fact a bit
Summary: Remove AphrontPanels, use standard UI, test for mobile, add phts
Test Plan: Faked a few facts for layout purposes.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D11960
+13
-16
+3
-4
src/applications/fact/controller/PhabricatorFactChartController.php
+3
-4
src/applications/fact/controller/PhabricatorFactChartController.php
···
76
76
'colors' => array('#0000ff'),
77
77
));
78
78
79
-
$panel = new AphrontPanelView();
80
-
$panel->setHeader('Count of '.$spec->getName());
79
+
$panel = new PHUIObjectBoxView();
80
+
$panel->setHeaderText(pht('Count of %s', $spec->getName()));
81
81
$panel->appendChild($chart);
82
82
83
83
$crumbs = $this->buildApplicationCrumbs();
···
89
89
$panel,
90
90
),
91
91
array(
92
-
'title' => 'Chart',
93
-
'device' => false,
92
+
'title' => pht('Chart'),
94
93
));
95
94
}
96
95
+10
-12
src/applications/fact/controller/PhabricatorFactHomeController.php
+10
-12
src/applications/fact/controller/PhabricatorFactHomeController.php
···
42
42
$table = new AphrontTableView($rows);
43
43
$table->setHeaders(
44
44
array(
45
-
'Fact',
46
-
'Value',
45
+
pht('Fact'),
46
+
pht('Value'),
47
47
));
48
48
$table->setColumnClasses(
49
49
array(
···
51
51
'n',
52
52
));
53
53
54
-
$panel = new AphrontPanelView();
55
-
$panel->setHeader('Facts!');
54
+
$panel = new PHUIObjectBoxView();
55
+
$panel->setHeaderText(pht('Facts'));
56
56
$panel->appendChild($table);
57
57
58
58
$chart_form = $this->buildChartForm();
···
67
67
$panel,
68
68
),
69
69
array(
70
-
'title' => 'Facts',
71
-
'device' => false,
70
+
'title' => pht('Facts'),
72
71
));
73
72
}
74
73
···
98
97
99
98
if (!$options) {
100
99
return id(new PHUIInfoView())
101
-
->setSeverity(PHUIInfoView::SEVERITY_NOTICE)
100
+
->setSeverity(PHUIInfoView::SEVERITY_NODATA)
102
101
->setTitle(pht('No Chartable Facts'))
103
102
->appendChild(phutil_tag(
104
103
'p',
···
115
114
->setOptions($options))
116
115
->appendChild(
117
116
id(new AphrontFormSubmitControl())
118
-
->setValue('Plot Chart'));
117
+
->setValue(pht('Plot Chart')));
119
118
120
-
$panel = new AphrontPanelView();
121
-
$panel->appendChild($form);
122
-
$panel->setWidth(AphrontPanelView::WIDTH_FORM);
123
-
$panel->setHeader('Plot Chart');
119
+
$panel = new PHUIObjectBoxView();
120
+
$panel->setForm($form);
121
+
$panel->setHeaderText(pht('Plot Chart'));
124
122
125
123
return $panel;
126
124
}