@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix transaction title rendering for AuthenticationConfigs
Summary: I was poking around in `PhabricatorAuthProviderViewController` and noticed that none of the subclass-specific rendering was working. Figured out that no one ever calls `PhabricatorAuthProviderConfigTransaction->setProvider()`, so instead of adding all those calls, just pull the provider out of the config object.
Test Plan:
Before: {F6598145}
After: {F6598147}
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D20655
+1
-8
+1
-8
src/applications/auth/storage/PhabricatorAuthProviderConfigTransaction.php
+1
-8
src/applications/auth/storage/PhabricatorAuthProviderConfigTransaction.php
···
14
14
15
15
const PROPERTY_KEY = 'auth:property';
16
16
17
-
private $provider;
18
-
19
-
public function setProvider(PhabricatorAuthProvider $provider) {
20
-
$this->provider = $provider;
21
-
return $this;
22
-
}
23
-
24
17
public function getProvider() {
25
-
return $this->provider;
18
+
return $this->getObject()->getProvider();
26
19
}
27
20
28
21
public function getApplicationName() {