recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Rename `DiffusionSSHWorkflow` subclasses for consistency

Summary: Ref T5655.

Test Plan: `grep`

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Maniphest Tasks: T5655

Differential Revision: https://secure.phabricator.com/D11185

Joshua Spence 97cd8c1c 94ac3c08

+33 -36
+18 -18
src/__phutil_library_map__.php
··· 500 500 'DiffusionGitFileContentQuery' => 'applications/diffusion/query/filecontent/DiffusionGitFileContentQuery.php', 501 501 'DiffusionGitFileContentQueryTestCase' => 'applications/diffusion/query/__tests__/DiffusionGitFileContentQueryTestCase.php', 502 502 'DiffusionGitRawDiffQuery' => 'applications/diffusion/query/rawdiff/DiffusionGitRawDiffQuery.php', 503 + 'DiffusionGitReceivePackSSHWorkflow' => 'applications/diffusion/ssh/DiffusionGitReceivePackSSHWorkflow.php', 503 504 'DiffusionGitRequest' => 'applications/diffusion/request/DiffusionGitRequest.php', 504 505 'DiffusionGitResponse' => 'applications/diffusion/response/DiffusionGitResponse.php', 506 + 'DiffusionGitSSHWorkflow' => 'applications/diffusion/ssh/DiffusionGitSSHWorkflow.php', 507 + 'DiffusionGitUploadPackSSHWorkflow' => 'applications/diffusion/ssh/DiffusionGitUploadPackSSHWorkflow.php', 505 508 'DiffusionHistoryController' => 'applications/diffusion/controller/DiffusionHistoryController.php', 506 509 'DiffusionHistoryQueryConduitAPIMethod' => 'applications/diffusion/conduit/DiffusionHistoryQueryConduitAPIMethod.php', 507 510 'DiffusionHistoryTableView' => 'applications/diffusion/view/DiffusionHistoryTableView.php', ··· 527 530 'DiffusionMercurialRawDiffQuery' => 'applications/diffusion/query/rawdiff/DiffusionMercurialRawDiffQuery.php', 528 531 'DiffusionMercurialRequest' => 'applications/diffusion/request/DiffusionMercurialRequest.php', 529 532 'DiffusionMercurialResponse' => 'applications/diffusion/response/DiffusionMercurialResponse.php', 533 + 'DiffusionMercurialSSHWorkflow' => 'applications/diffusion/ssh/DiffusionMercurialSSHWorkflow.php', 534 + 'DiffusionMercurialServeSSHWorkflow' => 'applications/diffusion/ssh/DiffusionMercurialServeSSHWorkflow.php', 535 + 'DiffusionMercurialWireClientSSHProtocolChannel' => 'applications/diffusion/ssh/DiffusionMercurialWireClientProtocoSSHChannel.php', 530 536 'DiffusionMercurialWireProtocol' => 'applications/diffusion/protocol/DiffusionMercurialWireProtocol.php', 537 + 'DiffusionMercurialWireSSHTestCase' => 'applications/diffusion/ssh/__tests__/DiffusionMercurialWireSSHTestCase.php', 531 538 'DiffusionMergedCommitsQueryConduitAPIMethod' => 'applications/diffusion/conduit/DiffusionMergedCommitsQueryConduitAPIMethod.php', 532 539 'DiffusionMirrorDeleteController' => 'applications/diffusion/controller/DiffusionMirrorDeleteController.php', 533 540 'DiffusionMirrorEditController' => 'applications/diffusion/controller/DiffusionMirrorEditController.php', ··· 581 588 'DiffusionRequest' => 'applications/diffusion/request/DiffusionRequest.php', 582 589 'DiffusionResolveRefsConduitAPIMethod' => 'applications/diffusion/conduit/DiffusionResolveRefsConduitAPIMethod.php', 583 590 'DiffusionResolveUserQuery' => 'applications/diffusion/query/DiffusionResolveUserQuery.php', 584 - 'DiffusionSSHGitReceivePackWorkflow' => 'applications/diffusion/ssh/DiffusionSSHGitReceivePackWorkflow.php', 585 - 'DiffusionSSHGitUploadPackWorkflow' => 'applications/diffusion/ssh/DiffusionSSHGitUploadPackWorkflow.php', 586 - 'DiffusionSSHGitWorkflow' => 'applications/diffusion/ssh/DiffusionSSHGitWorkflow.php', 587 - 'DiffusionSSHMercurialServeWorkflow' => 'applications/diffusion/ssh/DiffusionSSHMercurialServeWorkflow.php', 588 - 'DiffusionSSHMercurialWireClientProtocolChannel' => 'applications/diffusion/ssh/DiffusionSSHMercurialWireClientProtocolChannel.php', 589 - 'DiffusionSSHMercurialWireTestCase' => 'applications/diffusion/ssh/__tests__/DiffusionSSHMercurialWireTestCase.php', 590 - 'DiffusionSSHMercurialWorkflow' => 'applications/diffusion/ssh/DiffusionSSHMercurialWorkflow.php', 591 - 'DiffusionSSHSubversionServeWorkflow' => 'applications/diffusion/ssh/DiffusionSSHSubversionServeWorkflow.php', 592 - 'DiffusionSSHSubversionWorkflow' => 'applications/diffusion/ssh/DiffusionSSHSubversionWorkflow.php', 593 591 'DiffusionSSHWorkflow' => 'applications/diffusion/ssh/DiffusionSSHWorkflow.php', 594 592 'DiffusionSearchQueryConduitAPIMethod' => 'applications/diffusion/conduit/DiffusionSearchQueryConduitAPIMethod.php', 595 593 'DiffusionServeController' => 'applications/diffusion/controller/DiffusionServeController.php', 596 594 'DiffusionSetPasswordSettingsPanel' => 'applications/diffusion/panel/DiffusionSetPasswordSettingsPanel.php', 597 595 'DiffusionSetupException' => 'applications/diffusion/exception/DiffusionSetupException.php', 596 + 'DiffusionSubversionSSHWorkflow' => 'applications/diffusion/ssh/DiffusionSubversionSSHWorkflow.php', 597 + 'DiffusionSubversionServeSSHWorkflow' => 'applications/diffusion/ssh/DiffusionSubversionServeSSHWorkflow.php', 598 598 'DiffusionSubversionWireProtocol' => 'applications/diffusion/protocol/DiffusionSubversionWireProtocol.php', 599 599 'DiffusionSubversionWireProtocolTestCase' => 'applications/diffusion/protocol/__tests__/DiffusionSubversionWireProtocolTestCase.php', 600 600 'DiffusionSvnFileContentQuery' => 'applications/diffusion/query/filecontent/DiffusionSvnFileContentQuery.php', ··· 3561 3561 'DiffusionGitFileContentQuery' => 'DiffusionFileContentQuery', 3562 3562 'DiffusionGitFileContentQueryTestCase' => 'PhabricatorTestCase', 3563 3563 'DiffusionGitRawDiffQuery' => 'DiffusionRawDiffQuery', 3564 + 'DiffusionGitReceivePackSSHWorkflow' => 'DiffusionGitSSHWorkflow', 3564 3565 'DiffusionGitRequest' => 'DiffusionRequest', 3565 3566 'DiffusionGitResponse' => 'AphrontResponse', 3567 + 'DiffusionGitSSHWorkflow' => 'DiffusionSSHWorkflow', 3568 + 'DiffusionGitUploadPackSSHWorkflow' => 'DiffusionGitSSHWorkflow', 3566 3569 'DiffusionHistoryController' => 'DiffusionController', 3567 3570 'DiffusionHistoryQueryConduitAPIMethod' => 'DiffusionQueryConduitAPIMethod', 3568 3571 'DiffusionHistoryTableView' => 'DiffusionView', ··· 3587 3590 'DiffusionMercurialRawDiffQuery' => 'DiffusionRawDiffQuery', 3588 3591 'DiffusionMercurialRequest' => 'DiffusionRequest', 3589 3592 'DiffusionMercurialResponse' => 'AphrontResponse', 3593 + 'DiffusionMercurialSSHWorkflow' => 'DiffusionSSHWorkflow', 3594 + 'DiffusionMercurialServeSSHWorkflow' => 'DiffusionMercurialSSHWorkflow', 3595 + 'DiffusionMercurialWireClientSSHProtocolChannel' => 'PhutilProtocolChannel', 3596 + 'DiffusionMercurialWireSSHTestCase' => 'PhabricatorTestCase', 3590 3597 'DiffusionMergedCommitsQueryConduitAPIMethod' => 'DiffusionQueryConduitAPIMethod', 3591 3598 'DiffusionMirrorDeleteController' => 'DiffusionController', 3592 3599 'DiffusionMirrorEditController' => 'DiffusionController', ··· 3632 3639 'DiffusionRepositoryRemarkupRule' => 'PhabricatorObjectRemarkupRule', 3633 3640 'DiffusionResolveRefsConduitAPIMethod' => 'DiffusionQueryConduitAPIMethod', 3634 3641 'DiffusionResolveUserQuery' => 'Phobject', 3635 - 'DiffusionSSHGitReceivePackWorkflow' => 'DiffusionSSHGitWorkflow', 3636 - 'DiffusionSSHGitUploadPackWorkflow' => 'DiffusionSSHGitWorkflow', 3637 - 'DiffusionSSHGitWorkflow' => 'DiffusionSSHWorkflow', 3638 - 'DiffusionSSHMercurialServeWorkflow' => 'DiffusionSSHMercurialWorkflow', 3639 - 'DiffusionSSHMercurialWireClientProtocolChannel' => 'PhutilProtocolChannel', 3640 - 'DiffusionSSHMercurialWireTestCase' => 'PhabricatorTestCase', 3641 - 'DiffusionSSHMercurialWorkflow' => 'DiffusionSSHWorkflow', 3642 - 'DiffusionSSHSubversionServeWorkflow' => 'DiffusionSSHSubversionWorkflow', 3643 - 'DiffusionSSHSubversionWorkflow' => 'DiffusionSSHWorkflow', 3644 3642 'DiffusionSSHWorkflow' => 'PhabricatorSSHWorkflow', 3645 3643 'DiffusionSearchQueryConduitAPIMethod' => 'DiffusionQueryConduitAPIMethod', 3646 3644 'DiffusionServeController' => 'DiffusionController', 3647 3645 'DiffusionSetPasswordSettingsPanel' => 'PhabricatorSettingsPanel', 3648 3646 'DiffusionSetupException' => 'AphrontUsageException', 3647 + 'DiffusionSubversionSSHWorkflow' => 'DiffusionSSHWorkflow', 3648 + 'DiffusionSubversionServeSSHWorkflow' => 'DiffusionSubversionSSHWorkflow', 3649 3649 'DiffusionSubversionWireProtocol' => 'Phobject', 3650 3650 'DiffusionSubversionWireProtocolTestCase' => 'PhabricatorTestCase', 3651 3651 'DiffusionSvnFileContentQuery' => 'DiffusionFileContentQuery',
+3
src/applications/diffusion/ssh/DiffusionMercurialSSHWorkflow.php
··· 1 + <?php 2 + 3 + abstract class DiffusionMercurialSSHWorkflow extends DiffusionSSHWorkflow {}
+1 -2
src/applications/diffusion/ssh/DiffusionSSHGitReceivePackWorkflow.php src/applications/diffusion/ssh/DiffusionGitReceivePackSSHWorkflow.php
··· 1 1 <?php 2 2 3 - final class DiffusionSSHGitReceivePackWorkflow 4 - extends DiffusionSSHGitWorkflow { 3 + final class DiffusionGitReceivePackSSHWorkflow extends DiffusionGitSSHWorkflow { 5 4 6 5 public function didConstruct() { 7 6 $this->setName('git-receive-pack');
+1 -2
src/applications/diffusion/ssh/DiffusionSSHGitUploadPackWorkflow.php src/applications/diffusion/ssh/DiffusionGitUploadPackSSHWorkflow.php
··· 1 1 <?php 2 2 3 - final class DiffusionSSHGitUploadPackWorkflow 4 - extends DiffusionSSHGitWorkflow { 3 + final class DiffusionGitUploadPackSSHWorkflow extends DiffusionGitSSHWorkflow { 5 4 6 5 public function didConstruct() { 7 6 $this->setName('git-upload-pack');
+1 -1
src/applications/diffusion/ssh/DiffusionSSHGitWorkflow.php src/applications/diffusion/ssh/DiffusionGitSSHWorkflow.php
··· 1 1 <?php 2 2 3 - abstract class DiffusionSSHGitWorkflow extends DiffusionSSHWorkflow { 3 + abstract class DiffusionGitSSHWorkflow extends DiffusionSSHWorkflow { 4 4 5 5 protected function writeError($message) { 6 6 // Git assumes we'll add our own newlines.
+3 -3
src/applications/diffusion/ssh/DiffusionSSHMercurialServeWorkflow.php src/applications/diffusion/ssh/DiffusionMercurialServeSSHWorkflow.php
··· 1 1 <?php 2 2 3 - final class DiffusionSSHMercurialServeWorkflow 4 - extends DiffusionSSHMercurialWorkflow { 3 + final class DiffusionMercurialServeSSHWorkflow 4 + extends DiffusionMercurialSSHWorkflow { 5 5 6 6 protected $didSeeWrite; 7 7 ··· 46 46 ->setEnv($this->getEnvironment()); 47 47 48 48 $io_channel = $this->getIOChannel(); 49 - $protocol_channel = new DiffusionSSHMercurialWireClientProtocolChannel( 49 + $protocol_channel = new DiffusionMercurialWireClientSSHProtocolChannel( 50 50 $io_channel); 51 51 52 52 $err = id($this->newPassthruCommand())
+1 -1
src/applications/diffusion/ssh/DiffusionSSHMercurialWireClientProtocolChannel.php src/applications/diffusion/ssh/DiffusionMercurialWireClientProtocoSSHChannel.php
··· 1 1 <?php 2 2 3 - final class DiffusionSSHMercurialWireClientProtocolChannel 3 + final class DiffusionMercurialWireClientSSHProtocolChannel 4 4 extends PhutilProtocolChannel { 5 5 6 6 private $buffer = '';
-3
src/applications/diffusion/ssh/DiffusionSSHMercurialWorkflow.php
··· 1 - <?php 2 - 3 - abstract class DiffusionSSHMercurialWorkflow extends DiffusionSSHWorkflow {}
+2 -2
src/applications/diffusion/ssh/DiffusionSSHSubversionServeWorkflow.php src/applications/diffusion/ssh/DiffusionSubversionServeSSHWorkflow.php
··· 6 6 * http://svn.apache.org/repos/asf/subversion/trunk/subversion/libsvn_ra_svn/protocol 7 7 * 8 8 */ 9 - final class DiffusionSSHSubversionServeWorkflow 10 - extends DiffusionSSHSubversionWorkflow { 9 + final class DiffusionSubversionServeSSHWorkflow 10 + extends DiffusionSubversionSSHWorkflow { 11 11 12 12 private $didSeeWrite; 13 13
+1 -1
src/applications/diffusion/ssh/DiffusionSSHSubversionWorkflow.php src/applications/diffusion/ssh/DiffusionSubversionSSHWorkflow.php
··· 1 1 <?php 2 2 3 - abstract class DiffusionSSHSubversionWorkflow extends DiffusionSSHWorkflow { 3 + abstract class DiffusionSubversionSSHWorkflow extends DiffusionSSHWorkflow { 4 4 5 5 protected function writeError($message) { 6 6 // Subversion assumes we'll add our own newlines.
+2 -3
src/applications/diffusion/ssh/__tests__/DiffusionSSHMercurialWireTestCase.php src/applications/diffusion/ssh/__tests__/DiffusionMercurialWireSSHTestCase.php
··· 1 1 <?php 2 2 3 - final class DiffusionSSHMercurialWireTestCase 4 - extends PhabricatorTestCase { 3 + final class DiffusionMercurialWireSSHTestCase extends PhabricatorTestCase { 5 4 6 5 public function testMercurialClientWireProtocolParser() { 7 6 $data = dirname(__FILE__).'/hgwiredata/'; ··· 19 18 20 19 private function assertParserResult(array $expect, $input, $file) { 21 20 list($x, $y) = PhutilSocketChannel::newChannelPair(); 22 - $xp = new DiffusionSSHMercurialWireClientProtocolChannel($x); 21 + $xp = new DiffusionMercurialWireClientSSHProtocolChannel($x); 23 22 24 23 $y->write($input); 25 24 $y->flush();