@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Quicksand and global drag and drop - install quicksand listener on event only
Summary: noticed this while doing some other work. didn't really break anything before but no need to install this listener every time we load the global drag and drop behavior; just the once works fine.
Test Plan: home -> profile -> back to home and drag and drop still worked
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D12740
+14
-13
+4
-4
resources/celerity/map.php
+4
-4
resources/celerity/map.php
···
8
8
return array(
9
9
'names' => array(
10
10
'core.pkg.css' => 'ca3f6a60',
11
-
'core.pkg.js' => 'e9484a4e',
11
+
'core.pkg.js' => '74e57ea0',
12
12
'darkconsole.pkg.js' => 'e7393ebb',
13
13
'differential.pkg.css' => 'bb338e4b',
14
14
'differential.pkg.js' => '3cfa26f9',
···
459
459
'rsrc/js/core/behavior-file-tree.js' => '88236f00',
460
460
'rsrc/js/core/behavior-form.js' => '5c54cbf3',
461
461
'rsrc/js/core/behavior-gesture.js' => '3ab51e2c',
462
-
'rsrc/js/core/behavior-global-drag-and-drop.js' => 'c203e6ee',
462
+
'rsrc/js/core/behavior-global-drag-and-drop.js' => 'c8e57404',
463
463
'rsrc/js/core/behavior-high-security-warning.js' => 'a464fe03',
464
464
'rsrc/js/core/behavior-history-install.js' => '7ee2b591',
465
465
'rsrc/js/core/behavior-hovercard.js' => 'f36e01af',
···
584
584
'javelin-behavior-durable-column' => '657c2b50',
585
585
'javelin-behavior-error-log' => '6882e80a',
586
586
'javelin-behavior-fancy-datepicker' => '5c0f680f',
587
-
'javelin-behavior-global-drag-and-drop' => 'c203e6ee',
587
+
'javelin-behavior-global-drag-and-drop' => 'c8e57404',
588
588
'javelin-behavior-herald-rule-editor' => '7ebaeed3',
589
589
'javelin-behavior-high-security-warning' => 'a464fe03',
590
590
'javelin-behavior-history-install' => '7ee2b591',
···
1780
1780
'javelin-dom',
1781
1781
'javelin-vector',
1782
1782
),
1783
-
'c203e6ee' => array(
1783
+
'c8e57404' => array(
1784
1784
'javelin-behavior',
1785
1785
'javelin-dom',
1786
1786
'javelin-uri',
+10
-9
webroot/rsrc/js/core/behavior-global-drag-and-drop.js
+10
-9
webroot/rsrc/js/core/behavior-global-drag-and-drop.js
···
90
90
statics.pending--;
91
91
statics.errors = true;
92
92
});
93
+
94
+
JX.Stratcom.listen(
95
+
'quicksand-redraw',
96
+
null,
97
+
function (e) {
98
+
var data = e.getData();
99
+
var toggle = data.newResponse.globalDragAndDrop;
100
+
statics.enabled = toggle;
101
+
statics.drop.setIsEnabled(toggle);
102
+
});
93
103
}
94
104
95
105
statics.init = statics.init || init();
96
106
97
-
JX.Stratcom.listen(
98
-
'quicksand-redraw',
99
-
null,
100
-
function (e) {
101
-
var data = e.getData();
102
-
var toggle = data.newResponse.globalDragAndDrop;
103
-
statics.enabled = toggle;
104
-
statics.drop.setIsEnabled(toggle);
105
-
});
106
107
});