@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
When the last rejecting reviewer resigns from a revision, return it to "Needs Review"
Summary:
Ref T13216. Fixes T12920. See PHI911. If you reject a revision and then resign from it, it stays in "Needs Revision".
There's some arguable motivation for this, but it's inconsistent with how "Accept" works (if the last accepting reviewer resigns, we kick you out of "Accepted"). Make it consistent.
Test Plan:
- As the only reviewer: requested changes to a revision, then resigned.
- Before: revision stays in "Needs Revision".
- After: revision moves back to "Needs Review".
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T13216, T12920
Differential Revision: https://secure.phabricator.com/D19840
+5
+5
src/applications/differential/editor/DifferentialTransactionEditor.php
+5
src/applications/differential/editor/DifferentialTransactionEditor.php
···
451
451
// conditions for acceptance. This usually happens after an accepting
452
452
// reviewer resigns or is removed.
453
453
$new_status = DifferentialRevisionStatus::NEEDS_REVIEW;
454
+
} else if ($was_revision) {
455
+
// This revision was "Needs Revision", but no longer has any rejecting
456
+
// reviewers. This usually happens after the last rejecting reviewer
457
+
// resigns or is removed. Put the revision back in "Needs Review".
458
+
$new_status = DifferentialRevisionStatus::NEEDS_REVIEW;
454
459
}
455
460
456
461
if ($new_status === null) {