@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix two minor issues with Pholio
Summary:
- One bad method call.
- One fatal when handling a mock with no images. These "can't" exist, but we have a few old ones I think and it's probably better not to fatal. We could filter the object out completely, but this doesn't seem like a bad fix?
Test Plan: Viewed `/pholio/` (although I don't think I have any imageless mocks) and viewed an outdated image.
Reviewers: btrahan, chad
Reviewed By: chad
CC: aran
Differential Revision: https://secure.phabricator.com/D6574
+2
-2
+1
-1
src/applications/pholio/controller/PholioMockViewController.php
+1
-1
src/applications/pholio/controller/PholioMockViewController.php
···
134
134
$image = idx($images, $image_id);
135
135
136
136
if ($image) {
137
-
$history = $mock->getImageUpdateSet($image_id);
137
+
$history = $mock->getImageHistorySet($image_id);
138
138
$latest_image = last($history);
139
139
$href = $this->getApplicationURI(
140
140
'image/history/'.$latest_image->getID().'/');
+1
-1
src/applications/pholio/query/PholioMockQuery.php
+1
-1
src/applications/pholio/query/PholioMockQuery.php
···
122
122
$image_groups = mgroup($all_images, 'getMockID');
123
123
124
124
foreach ($mocks as $mock) {
125
-
$mock_images = $image_groups[$mock->getID()];
125
+
$mock_images = idx($image_groups, $mock->getID(), array());
126
126
$mock->attachAllImages($mock_images);
127
127
$mock->attachImages(mfilter($mock_images, 'getIsObsolete', true));
128
128
}