recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Use modern SearchEngine construction in Nuance

Summary: Ref T10537. Minor cleanup of controllers to be more modern / work better on mobile.

Test Plan: Browsed all queue / source pages.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10537

Differential Revision: https://secure.phabricator.com/D15428

epriestley 98542637 2ddd7864

+51 -58
+11 -7
src/__phutil_library_map__.php
··· 1433 1433 'NuancePhabricatorFormSourceDefinition' => 'applications/nuance/source/NuancePhabricatorFormSourceDefinition.php', 1434 1434 'NuanceQuery' => 'applications/nuance/query/NuanceQuery.php', 1435 1435 'NuanceQueue' => 'applications/nuance/storage/NuanceQueue.php', 1436 + 'NuanceQueueController' => 'applications/nuance/controller/NuanceQueueController.php', 1436 1437 'NuanceQueueDatasource' => 'applications/nuance/typeahead/NuanceQueueDatasource.php', 1437 1438 'NuanceQueueEditController' => 'applications/nuance/controller/NuanceQueueEditController.php', 1438 1439 'NuanceQueueEditor' => 'applications/nuance/editor/NuanceQueueEditor.php', ··· 1457 1458 'NuanceSchemaSpec' => 'applications/nuance/storage/NuanceSchemaSpec.php', 1458 1459 'NuanceSource' => 'applications/nuance/storage/NuanceSource.php', 1459 1460 'NuanceSourceActionController' => 'applications/nuance/controller/NuanceSourceActionController.php', 1461 + 'NuanceSourceController' => 'applications/nuance/controller/NuanceSourceController.php', 1460 1462 'NuanceSourceCreateController' => 'applications/nuance/controller/NuanceSourceCreateController.php', 1461 1463 'NuanceSourceDefaultEditCapability' => 'applications/nuance/capability/NuanceSourceDefaultEditCapability.php', 1462 1464 'NuanceSourceDefaultViewCapability' => 'applications/nuance/capability/NuanceSourceDefaultViewCapability.php', ··· 5678 5680 'PhabricatorPolicyInterface', 5679 5681 'PhabricatorApplicationTransactionInterface', 5680 5682 ), 5683 + 'NuanceQueueController' => 'NuanceController', 5681 5684 'NuanceQueueDatasource' => 'PhabricatorTypeaheadDatasource', 5682 - 'NuanceQueueEditController' => 'NuanceController', 5685 + 'NuanceQueueEditController' => 'NuanceQueueController', 5683 5686 'NuanceQueueEditor' => 'PhabricatorApplicationTransactionEditor', 5684 - 'NuanceQueueListController' => 'NuanceController', 5687 + 'NuanceQueueListController' => 'NuanceQueueController', 5685 5688 'NuanceQueuePHIDType' => 'PhabricatorPHIDType', 5686 5689 'NuanceQueueQuery' => 'NuanceQuery', 5687 5690 'NuanceQueueSearchEngine' => 'PhabricatorApplicationSearchEngine', 5688 5691 'NuanceQueueTransaction' => 'NuanceTransaction', 5689 5692 'NuanceQueueTransactionComment' => 'PhabricatorApplicationTransactionComment', 5690 5693 'NuanceQueueTransactionQuery' => 'PhabricatorApplicationTransactionQuery', 5691 - 'NuanceQueueViewController' => 'NuanceController', 5694 + 'NuanceQueueViewController' => 'NuanceQueueController', 5692 5695 'NuanceRequestor' => array( 5693 5696 'NuanceDAO', 5694 5697 'PhabricatorPolicyInterface', ··· 5710 5713 'PhabricatorPolicyInterface', 5711 5714 ), 5712 5715 'NuanceSourceActionController' => 'NuanceController', 5713 - 'NuanceSourceCreateController' => 'NuanceController', 5716 + 'NuanceSourceController' => 'NuanceController', 5717 + 'NuanceSourceCreateController' => 'NuanceSourceController', 5714 5718 'NuanceSourceDefaultEditCapability' => 'PhabricatorPolicyCapability', 5715 5719 'NuanceSourceDefaultViewCapability' => 'PhabricatorPolicyCapability', 5716 5720 'NuanceSourceDefinition' => 'Phobject', 5717 5721 'NuanceSourceDefinitionTestCase' => 'PhabricatorTestCase', 5718 - 'NuanceSourceEditController' => 'NuanceController', 5722 + 'NuanceSourceEditController' => 'NuanceSourceController', 5719 5723 'NuanceSourceEditor' => 'PhabricatorApplicationTransactionEditor', 5720 - 'NuanceSourceListController' => 'NuanceController', 5724 + 'NuanceSourceListController' => 'NuanceSourceController', 5721 5725 'NuanceSourceManageCapability' => 'PhabricatorPolicyCapability', 5722 5726 'NuanceSourcePHIDType' => 'PhabricatorPHIDType', 5723 5727 'NuanceSourceQuery' => 'NuanceQuery', ··· 5725 5729 'NuanceSourceTransaction' => 'NuanceTransaction', 5726 5730 'NuanceSourceTransactionComment' => 'PhabricatorApplicationTransactionComment', 5727 5731 'NuanceSourceTransactionQuery' => 'PhabricatorApplicationTransactionQuery', 5728 - 'NuanceSourceViewController' => 'NuanceController', 5732 + 'NuanceSourceViewController' => 'NuanceSourceController', 5729 5733 'NuanceTransaction' => 'PhabricatorApplicationTransaction', 5730 5734 'OwnersConduitAPIMethod' => 'ConduitAPIMethod', 5731 5735 'OwnersEditConduitAPIMethod' => 'PhabricatorEditEngineAPIMethod',
+11
src/applications/nuance/controller/NuanceQueueController.php
··· 1 + <?php 2 + 3 + abstract class NuanceQueueController 4 + extends NuanceController { 5 + 6 + public function buildApplicationMenu() { 7 + return $this->newApplicationMenu() 8 + ->setSearchEngine(new NuanceQueueSearchEngine()); 9 + } 10 + 11 + }
+2 -1
src/applications/nuance/controller/NuanceQueueEditController.php
··· 1 1 <?php 2 2 3 - final class NuanceQueueEditController extends NuanceController { 3 + final class NuanceQueueEditController 4 + extends NuanceQueueController { 4 5 5 6 public function handleRequest(AphrontRequest $request) { 6 7 $viewer = $this->getViewer();
+4 -23
src/applications/nuance/controller/NuanceQueueListController.php
··· 1 1 <?php 2 2 3 3 final class NuanceQueueListController 4 - extends NuanceController { 4 + extends NuanceQueueController { 5 5 6 6 public function handleRequest(AphrontRequest $request) { 7 - $request = $this->getRequest(); 8 - $controller = id(new PhabricatorApplicationSearchController($request)) 9 - ->setQueryKey($request->getURIData('queryKey')) 10 - ->setSearchEngine(new NuanceQueueSearchEngine()) 11 - ->setNavigation($this->buildSideNavView()); 12 - 13 - return $this->delegateToController($controller); 14 - } 15 - 16 - public function buildSideNavView($for_app = false) { 17 - $user = $this->getRequest()->getUser(); 18 - 19 - $nav = new AphrontSideNavFilterView(); 20 - $nav->setBaseURI(new PhutilURI($this->getApplicationURI())); 21 - 22 - id(new NuanceQueueSearchEngine()) 23 - ->setViewer($user) 24 - ->addNavigationItems($nav->getMenu()); 25 - 26 - $nav->selectFilter(null); 27 - 28 - return $nav; 7 + return id(new NuanceQueueSearchEngine()) 8 + ->setController($this) 9 + ->buildResponse(); 29 10 } 30 11 31 12 protected function buildApplicationCrumbs() {
+2 -1
src/applications/nuance/controller/NuanceQueueViewController.php
··· 1 1 <?php 2 2 3 - final class NuanceQueueViewController extends NuanceController { 3 + final class NuanceQueueViewController 4 + extends NuanceQueueController { 4 5 5 6 public function handleRequest(AphrontRequest $request) { 6 7 $viewer = $this->getViewer();
+11
src/applications/nuance/controller/NuanceSourceController.php
··· 1 + <?php 2 + 3 + abstract class NuanceSourceController 4 + extends NuanceController { 5 + 6 + public function buildApplicationMenu() { 7 + return $this->newApplicationMenu() 8 + ->setSearchEngine(new NuanceSourceSearchEngine()); 9 + } 10 + 11 + }
+2 -1
src/applications/nuance/controller/NuanceSourceCreateController.php
··· 1 1 <?php 2 2 3 - final class NuanceSourceCreateController extends NuanceController { 3 + final class NuanceSourceCreateController 4 + extends NuanceSourceController { 4 5 5 6 public function handleRequest(AphrontRequest $request) { 6 7 $can_edit = $this->requireApplicationCapability(
+2 -1
src/applications/nuance/controller/NuanceSourceEditController.php
··· 1 1 <?php 2 2 3 - final class NuanceSourceEditController extends NuanceController { 3 + final class NuanceSourceEditController 4 + extends NuanceSourceController { 4 5 5 6 public function handleRequest(AphrontRequest $request) { 6 7 $can_edit = $this->requireApplicationCapability(
+4 -23
src/applications/nuance/controller/NuanceSourceListController.php
··· 1 1 <?php 2 2 3 3 final class NuanceSourceListController 4 - extends NuanceController { 4 + extends NuanceSourceController { 5 5 6 6 public function handleRequest(AphrontRequest $request) { 7 - $request = $this->getRequest(); 8 - $controller = id(new PhabricatorApplicationSearchController($request)) 9 - ->setQueryKey($request->getURIData('queryKey')) 10 - ->setSearchEngine(new NuanceSourceSearchEngine()) 11 - ->setNavigation($this->buildSideNavView()); 12 - 13 - return $this->delegateToController($controller); 14 - } 15 - 16 - public function buildSideNavView($for_app = false) { 17 - $user = $this->getRequest()->getUser(); 18 - 19 - $nav = new AphrontSideNavFilterView(); 20 - $nav->setBaseURI(new PhutilURI($this->getApplicationURI())); 21 - 22 - id(new NuanceSourceSearchEngine()) 23 - ->setViewer($user) 24 - ->addNavigationItems($nav->getMenu()); 25 - 26 - $nav->selectFilter(null); 27 - 28 - return $nav; 7 + return id(new NuanceSourceSearchEngine()) 8 + ->setController($this) 9 + ->buildResponse(); 29 10 } 30 11 31 12 protected function buildApplicationCrumbs() {
+2 -1
src/applications/nuance/controller/NuanceSourceViewController.php
··· 1 1 <?php 2 2 3 - final class NuanceSourceViewController extends NuanceController { 3 + final class NuanceSourceViewController 4 + extends NuanceSourceController { 4 5 5 6 public function handleRequest(AphrontRequest $request) { 6 7 $viewer = $this->getViewer();