@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix a Harbormaster build log issue where too few header lines were returned when expanding logs in the middle
Summary: Ref T13088. This variable bled through from an earlier loop and caused us to drop some of the lines in the middle.
Test Plan: Clicked "Show More", got an equal number of header and footer lines.
Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam
Maniphest Tasks: T13088
Differential Revision: https://secure.phabricator.com/D19148
+2
-2
+2
-2
src/applications/harbormaster/controller/HarbormasterBuildLogRenderController.php
+2
-2
src/applications/harbormaster/controller/HarbormasterBuildLogRenderController.php
···
167
167
'Unable to find lines.'));
168
168
}
169
169
170
-
if ($direction > 0) {
170
+
if ($view['direction'] > 0) {
171
171
$slice_offset = $anchor_key;
172
172
} else {
173
173
$slice_offset = max(0, $anchor_key - ($view['lines'] - 1));
···
589
589
$up_text);
590
590
591
591
$mid_text = pht(
592
-
'Show More (%s bytes Hidden)',
592
+
'Show More (%s Bytes)',
593
593
new PhutilNumber($range['tail'] - $range['head']));
594
594
595
595
$expand_mid = javelin_tag(