When we purge the request cache, also force PHP to collect cycles

@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge

phorge phabricator

fork

Summary:
Ref T12997. See that task for more details. Briefly, an unusual dataset (where commits are mentioned hundreds of times by other commits) is causing some weird memory behavior in the daemons.

Forcing PHP to GC cycles explicitly after each task completes seems to help with this, by cleaning up some of the memory between tasks. A more thorough fix might be to untangle the `$xactions` structure, but that's significantly more involved.

Test Plan:
- Did this locally in a controlled environment, saw an immediate collection of a 500MB `$xactions` cycle.
- Put a similar change in production, memory usage seemed less to improve. It's hard to tell for sure that this does anything, but it shouldn't hurt.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T12997

Differential Revision: https://secure.phabricator.com/D18657

epriestley 8 years ago 9875af73 086a125a

1 changed file

expand all

src

applications

cache

PhabricatorCaches.php

src/applications/cache/PhabricatorCaches.php

··· 51 51 */ 52 52 public static function destroyRequestCache() { 53 53 self::$requestCache = null; 54 + 55 + // See T12997. Force the GC to run when the request cache is destroyed to 56 + // clean up any cycles which may still be hanging around. 57 + if (function_exists('gc_collect_cycles')) { 58 + gc_collect_cycles(); 59 + } 54 60 } 55 61 56 62

Configure Feed

Configure Feed