recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix call to non-existing newIcons() in PhabricatorIconSet

Summary:
`PhabricatorIconSet::getIcons()` calls `$this->newIcons()` which is undefined.

As all six child classes which extend `PhabricatorIconSet` implement `newIcons()`, declare an abstract function in their parent class.

Test Plan: Carefully read the code.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25647

Andre Klapper 98884f75 a8af0c6e

+2
+2
src/applications/files/iconset/PhabricatorIconSet.php
··· 3 3 abstract class PhabricatorIconSet 4 4 extends Phobject { 5 5 6 + abstract protected function newIcons(); 7 + 6 8 final public function getIconSetKey() { 7 9 return $this->getPhobjectClassConstant('ICONSETKEY'); 8 10 }