@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Actually squelch Harbormaster "test passed" mail
Summary:
Ref T1049. When Harbormaster tests pass, don't bother sending an email about it.
(I tried to implement this earlier but didn't test it entirely properly, and we needed a little more code.)
Test Plan: Used `bin/harbormaster build` to build some junk, got no email about passes.
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: epriestley
Maniphest Tasks: T1049
Differential Revision: https://secure.phabricator.com/D8813
+16
-1
+1
-1
src/applications/differential/storage/DifferentialTransaction.php
+1
-1
src/applications/differential/storage/DifferentialTransaction.php
+15
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
+15
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
···
1721
1721
PhabricatorLiskDAO $object,
1722
1722
array $xactions) {
1723
1723
1724
+
// Check if any of the transactions are visible. If we don't have any
1725
+
// visible transactions, don't send the mail.
1726
+
1727
+
$any_visible = false;
1728
+
foreach ($xactions as $xaction) {
1729
+
if (!$xaction->shouldHideForMail($xactions)) {
1730
+
$any_visible = true;
1731
+
break;
1732
+
}
1733
+
}
1734
+
1735
+
if (!$any_visible) {
1736
+
return;
1737
+
}
1738
+
1724
1739
$email_to = array_filter(array_unique($this->getMailTo($object)));
1725
1740
$email_cc = array_filter(array_unique($this->getMailCC($object)));
1726
1741