recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Hide the arrow icon that displays above workboard columns on Safari

Summary:
In fec00256be1f, workboard columns were made collapsible by using the
HTML `<details>`/`<summary>` elements. Some CSS was also added in order
to prevent the default HTML icon associated with these elements [0] from
displaying; however, it seems like that CSS doesn't have any effect (or,
at least, doesn't have the intended effect) on the desktop Safari
browser.

In order to remove this default icon on Safari, this patch adds a
`display: none;` CSS rule targeting the `::-webkit-details-marker`
pseudo-element on the relevant `<summary>` elements. This is
documented [0] as being the pseudo-element to use in order to stop this
icon from being displayed on (e.g.) Safari, and it seems to fix the
issue for me locally.

[0] https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/summary#default_style

Closes T16464

Test Plan:
Open a project workboard in Safari on desktop. Verify that there is no
longer an arrow icon displaying above the names of each of the workboard
columns (as there is in the screenshot attached to T16464).

Do the same in these browser webs and no regressions:

- Mozilla Firefox 140.7 on Debian GNU/Linux 13 (trixie)
- Chromium 144.0 on Debian GNU/Linux 13 (trixie)
- Safari on iOS 26.2 (which AFAICS didn't seem to be affected by this
bug in the first place, for some reason)

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16464

Differential Revision: https://we.phorge.it/D26693

authored by

a smart kitten and committed by
Pppery 988e220f dd430661

+7 -3
+3 -3
resources/celerity/map.php
··· 9 9 'names' => array( 10 10 'conpherence.pkg.css' => 'b2d6f4b8', 11 11 'conpherence.pkg.js' => '020aebcf', 12 - 'core.pkg.css' => '671fbe41', 12 + 'core.pkg.css' => '8755ddc1', 13 13 'core.pkg.js' => '3b8563ac', 14 14 'dark-console.pkg.js' => '187792c2', 15 15 'differential.pkg.css' => 'abdb4fe9', ··· 151 151 'rsrc/css/phui/phui-form.css' => 'aa7692fe', 152 152 'rsrc/css/phui/phui-formation-view.css' => 'b172a0b3', 153 153 'rsrc/css/phui/phui-head-thing.css' => 'd7f293df', 154 - 'rsrc/css/phui/phui-header-view.css' => '7bc4efa0', 154 + 'rsrc/css/phui/phui-header-view.css' => 'b71a7a1b', 155 155 'rsrc/css/phui/phui-hovercard.css' => '7ffb4e0c', 156 156 'rsrc/css/phui/phui-icon-set-selector.css' => '19e0253b', 157 157 'rsrc/css/phui/phui-icon.css' => 'e790b94e', ··· 778 778 'phui-form-view-css' => '029b1ef9', 779 779 'phui-formation-view-css' => 'b172a0b3', 780 780 'phui-head-thing-view-css' => 'd7f293df', 781 - 'phui-header-view-css' => '7bc4efa0', 781 + 'phui-header-view-css' => 'b71a7a1b', 782 782 'phui-hovercard' => '6199f752', 783 783 'phui-hovercard-list' => 'de4b4919', 784 784 'phui-hovercard-view-css' => '7ffb4e0c',
+4
webroot/rsrc/css/phui/phui-header-view.css
··· 61 61 content: none; 62 62 } 63 63 64 + details > summary.phui-header-shell::-webkit-details-marker { 65 + display: none; 66 + } 67 + 64 68 .device-phone details > summary.phui-header-shell::after, 65 69 .device-tablet details > summary.phui-header-shell::after { 66 70 font-family: FontAwesome;