@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix audit commenting where there are only inlines
Summary: been some changes here and this code was broked. turns out we re-assign $action like two lines later and never used the initial value, so we can simply delete the offending line. Fixes T5745.
Test Plan: submitted inline comment pre-patch and fatal. re-submitted post patch and great success!
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: epriestley, Korvin
Maniphest Tasks: T5745
Differential Revision: https://secure.phabricator.com/D10078
-2
-2
src/applications/audit/editor/PhabricatorAuditCommentEditor.php
-2
src/applications/audit/editor/PhabricatorAuditCommentEditor.php
···
74
74
'commitPHID = %s',
75
75
$commit->getPHID());
76
76
77
-
$action = $comment->getAction();
78
-
79
77
// TODO: We should validate the action, currently we allow anyone to, e.g.,
80
78
// close an audit if they muck with form parameters. I'll followup with this
81
79
// and handle the no-effect cases (e.g., closing and already-closed audit).