@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Hide "X created Y, a subtask of P." feed stories again
Summary: Fixes T12787. Modular Transactions don't actually support `shouldHideForFeed()`. I'll add some discussion to the task.
Test Plan: Created a subtask, saw no more "X reopened Y, a subtask of P" feed story.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T12787
Differential Revision: https://secure.phabricator.com/D18058
+16
-9
+16
src/applications/maniphest/storage/ManiphestTransaction.php
+16
src/applications/maniphest/storage/ManiphestTransaction.php
···
40
40
return parent::shouldGenerateOldValue();
41
41
}
42
42
43
+
public function shouldHideForFeed() {
44
+
// NOTE: Modular transactions don't currently support this, and it has
45
+
// very few callsites, and it's publish-time rather than display-time.
46
+
// This should probably become a supported, display-time behavior. For
47
+
// discussion, see T12787.
48
+
49
+
// Hide "alice created X, a task blocking Y." from feed because it
50
+
// will almost always appear adjacent to "alice created Y".
51
+
$is_new = $this->getMetadataValue('blocker.new');
52
+
if ($is_new) {
53
+
return true;
54
+
}
55
+
56
+
return parent::shouldHideForFeed();
57
+
}
58
+
43
59
public function getRequiredHandlePHIDs() {
44
60
$phids = parent::getRequiredHandlePHIDs();
45
61
-9
src/applications/maniphest/xaction/ManiphestTaskUnblockTransaction.php
-9
src/applications/maniphest/xaction/ManiphestTaskUnblockTransaction.php
···
9
9
return null;
10
10
}
11
11
12
-
public function shouldHideForFeed() {
13
-
// Hide "alice created X, a task blocking Y." from feed because it
14
-
// will almost always appear adjacent to "alice created Y".
15
-
$is_new = $this->getMetadataValue('blocker.new');
16
-
if ($is_new) {
17
-
return true;
18
-
}
19
-
}
20
-
21
12
public function getActionName() {
22
13
$old = $this->getOldValue();
23
14
$new = $this->getNewValue();