recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Execute Harbormaster buildable filtering properly from HarbormasterBuildSearchEngine

Summary:
Ref T11473. When running `harbormaster.build.search` with a `buildables` constraint, the constraint doesn't get passed to the Query and so currently has no effect.

This piece of logic was just accidentally omitted from D16356. It is probably not used anywhere today and doesn't show up in the UI, so it's easy to overlook (I missed it in review, too).

Test Plan: Ran `harbormaster.build.search` with a `buildables` constraint, got expected filtering.

Reviewers: yelirekim, chad

Reviewed By: chad

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T11473

Differential Revision: https://secure.phabricator.com/D16395

epriestley 99889a63 65e964fc

+4
+4
src/applications/harbormaster/query/HarbormasterBuildSearchEngine.php
··· 61 61 $query->withBuildPlanPHIDs($map['plans']); 62 62 } 63 63 64 + if ($map['buildables']) { 65 + $query->withBuildablePHIDs($map['buildables']); 66 + } 67 + 64 68 if ($map['statuses']) { 65 69 $query->withBuildStatuses($map['statuses']); 66 70 }