@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Use more explicit language for unassigning tasks
Summary:
Ref T10493.
- Call this action "Unassigned" instead of "Up For Grabs", since the latter implies that it's OK for anyone to grab it, which is a social/context thing that we probably shouldn't assume.
- Show who a task was previously assigned to in the transaction.
The text is a little clunky, yell if you've got a better wording? Or maybe I'll come up with something.
Test Plan: {F1166299}
Reviewers: chad
Reviewed By: chad
Subscribers: cburroughs
Maniphest Tasks: T10493
Differential Revision: https://secure.phabricator.com/D15454
+4
-3
+4
-3
src/applications/maniphest/storage/ManiphestTransaction.php
+4
-3
src/applications/maniphest/storage/ManiphestTransaction.php
···
301
301
if ($this->getAuthorPHID() == $new) {
302
302
return pht('Claimed');
303
303
} else if (!$new) {
304
-
return pht('Up For Grabs');
304
+
return pht('Unassigned');
305
305
} else if (!$old) {
306
306
return pht('Assigned');
307
307
} else {
···
547
547
$this->renderHandleLink($author_phid));
548
548
} else if (!$new) {
549
549
return pht(
550
-
'%s placed this task up for grabs.',
551
-
$this->renderHandleLink($author_phid));
550
+
'%s removed %s as the assignee of this task.',
551
+
$this->renderHandleLink($author_phid),
552
+
$this->renderHandleLink($old));
552
553
} else if (!$old) {
553
554
return pht(
554
555
'%s assigned this task to %s.',