@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix Herald rule actions on empty custom PHID fields
Summary: Fixes T9260. That task has a good description of the issue.
Test Plan: Followed steps in T9260 to reproduce the issue. Applied patch; issue went away.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T9260
Differential Revision: https://secure.phabricator.com/D14169
+10
+10
src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php
+10
src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php
···
166
166
);
167
167
}
168
168
169
+
public function getHeraldFieldValue() {
170
+
// If the field has a `null` value, make sure we hand an `array()` to
171
+
// Herald.
172
+
$value = parent::getHeraldFieldValue();
173
+
if ($value) {
174
+
return $value;
175
+
}
176
+
return array();
177
+
}
178
+
169
179
}