@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Phurl URL object should show a banner if the URL is invalid
Summary: Ref T8989, Phurl URL should always show an info banner if the URL isn't valid
Test Plan: Phurl objects with URL "google.com" should show an error banner, but objects with URL "http://google.com" should not show banner.
Reviewers: epriestley, #blessed_reviewers
Reviewed By: epriestley, #blessed_reviewers
Subscribers: Korvin
Maniphest Tasks: T8989
Differential Revision: https://secure.phabricator.com/D14386
+5
-1
+5
-1
src/applications/phurl/controller/PhabricatorPhurlURLViewController.php
+5
-1
src/applications/phurl/controller/PhabricatorPhurlURLViewController.php
···
35
35
$properties = $this->buildPropertyView($url);
36
36
37
37
$properties->setActionList($actions);
38
+
$url_error = id(new PHUIInfoView())
39
+
->setErrors(array(pht('This URL is invalid due to a bad protocol.')))
40
+
->setIsHidden($url->isValid());
38
41
$box = id(new PHUIObjectBoxView())
39
42
->setHeader($header)
40
-
->addPropertyList($properties);
43
+
->addPropertyList($properties)
44
+
->setInfoView($url_error);
41
45
42
46
$is_serious = PhabricatorEnv::getEnvConfig('phabricator.serious-business');
43
47
$add_comment_header = $is_serious