recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Don't show empty attributes.

Summary: Some places we pass in empty strings and get hanging middots. Would prefer not have the middot, and let the developer decide if they should set a 'nothing here' state.

Test Plan: Checked Repositories with no lint messages.

Reviewers: epriestley, btrahan

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5920

Chad Little 99f648e4 63c27b32

+3 -1
+3 -1
src/view/layout/PhabricatorObjectItemView.php
··· 122 122 } 123 123 124 124 public function addAttribute($attribute) { 125 - $this->attributes[] = $attribute; 125 + if (!empty($attribute)) { 126 + $this->attributes[] = $attribute; 127 + } 126 128 return $this; 127 129 } 128 130