recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Remove standalone huge single page setting edit controller

Summary: Ref T4103. This isn't necessary or particularly useful anymore since panels have been converted.

Test Plan: Visited URI, got a 404.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T4103

Differential Revision: https://secure.phabricator.com/D16024

epriestley 9a076b71 45f347fe

-39
-2
src/__phutil_library_map__.php
··· 3378 3378 'PhabricatorSettingsApplicationsPanelGroup' => 'applications/settings/panelgroup/PhabricatorSettingsApplicationsPanelGroup.php', 3379 3379 'PhabricatorSettingsAuthenticationPanelGroup' => 'applications/settings/panelgroup/PhabricatorSettingsAuthenticationPanelGroup.php', 3380 3380 'PhabricatorSettingsDeveloperPanelGroup' => 'applications/settings/panelgroup/PhabricatorSettingsDeveloperPanelGroup.php', 3381 - 'PhabricatorSettingsEditController' => 'applications/settings/controller/PhabricatorSettingsEditController.php', 3382 3381 'PhabricatorSettingsEditEngine' => 'applications/settings/editor/PhabricatorSettingsEditEngine.php', 3383 3382 'PhabricatorSettingsEmailPanelGroup' => 'applications/settings/panelgroup/PhabricatorSettingsEmailPanelGroup.php', 3384 3383 'PhabricatorSettingsLogsPanelGroup' => 'applications/settings/panelgroup/PhabricatorSettingsLogsPanelGroup.php', ··· 8139 8138 'PhabricatorSettingsApplicationsPanelGroup' => 'PhabricatorSettingsPanelGroup', 8140 8139 'PhabricatorSettingsAuthenticationPanelGroup' => 'PhabricatorSettingsPanelGroup', 8141 8140 'PhabricatorSettingsDeveloperPanelGroup' => 'PhabricatorSettingsPanelGroup', 8142 - 'PhabricatorSettingsEditController' => 'PhabricatorController', 8143 8141 'PhabricatorSettingsEditEngine' => 'PhabricatorEditEngine', 8144 8142 'PhabricatorSettingsEmailPanelGroup' => 'PhabricatorSettingsPanelGroup', 8145 8143 'PhabricatorSettingsLogsPanelGroup' => 'PhabricatorSettingsPanelGroup',
-2
src/applications/settings/application/PhabricatorSettingsApplication.php
··· 37 37 'adjust/' => 'PhabricatorSettingsAdjustController', 38 38 'timezone/(?P<offset>[^/]+)/' 39 39 => 'PhabricatorSettingsTimezoneController', 40 - '(?P<type>user)/(?P<username>[^/]+)/(?:panel/(?P<key>[^/]+)/)?' 41 - => 'PhabricatorSettingsEditController', 42 40 ), 43 41 ); 44 42 }
-35
src/applications/settings/controller/PhabricatorSettingsEditController.php
··· 1 - <?php 2 - 3 - final class PhabricatorSettingsEditController 4 - extends PhabricatorController { 5 - 6 - public function handleRequest(AphrontRequest $request) { 7 - $viewer = $this->getViewer(); 8 - 9 - $engine = id(new PhabricatorSettingsEditEngine()) 10 - ->setController($this); 11 - 12 - switch ($request->getURIData('type')) { 13 - case 'user': 14 - $user = id(new PhabricatorPeopleQuery()) 15 - ->setViewer($viewer) 16 - ->withUsernames(array($request->getURIData('username'))) 17 - ->executeOne(); 18 - 19 - $preferences = $user->loadPreferences(); 20 - 21 - PhabricatorPolicyFilter::requireCapability( 22 - $viewer, 23 - $preferences, 24 - PhabricatorPolicyCapability::CAN_EDIT); 25 - 26 - $engine->setTargetObject($preferences); 27 - break; 28 - default: 29 - return new Aphront404Response(); 30 - } 31 - 32 - return $engine->buildResponse(); 33 - } 34 - 35 - }