@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
render_tag -> tag: pinboards
Summary: Fix pinboard callsites.
Test Plan: Looked at Pholio and Macro.
Reviewers: vrana
Reviewed By: vrana
CC: aran
Maniphest Tasks: T2432
Differential Revision: https://secure.phabricator.com/D4690
+12
-8
+1
-1
src/applications/macro/controller/PhabricatorMacroListController.php
+1
-1
src/applications/macro/controller/PhabricatorMacroListController.php
···
125
125
if ($file->getAuthorPHID()) {
126
126
$author_handle = $this->getHandle($file->getAuthorPHID());
127
127
$item->appendChild(
128
-
'Created by '.$author_handle->renderLink());
128
+
pht('Created by %s', $author_handle->renderLink()));
129
129
}
130
130
$datetime = phabricator_date($file->getDateCreated(), $viewer);
131
131
$item->appendChild(
+9
-5
src/view/layout/PhabricatorPinboardItemView.php
+9
-5
src/view/layout/PhabricatorPinboardItemView.php
···
33
33
public function render() {
34
34
$header = null;
35
35
if ($this->header) {
36
-
$header = hsprintf('<a href="%s">%s</a>', $this->uri, $this->header);
37
36
$header = phutil_tag(
38
37
'div',
39
38
array(
40
39
'class' => 'phabricator-pinboard-item-header',
41
40
),
42
-
$header);
41
+
phutil_tag('a', array('href' => $this->uri), $this->header));
43
42
}
44
43
45
44
$image = phutil_tag(
···
56
55
'height' => $this->imageHeight,
57
56
)));
58
57
59
-
$content = $this->renderChildren();
58
+
$content = $this->renderHTMLChildren();
60
59
if ($content) {
61
-
$content = phutil_render_tag(
60
+
$content = phutil_tag(
62
61
'div',
63
62
array(
64
63
'class' => 'phabricator-pinboard-item-content',
···
71
70
array(
72
71
'class' => 'phabricator-pinboard-item-view',
73
72
),
74
-
array($header, $image, $content));
73
+
$this->renderHTMLView(
74
+
array(
75
+
$header,
76
+
$image,
77
+
$content,
78
+
)));
75
79
}
76
80
77
81
}
+2
-2
src/view/layout/PhabricatorPinboardView.php
+2
-2
src/view/layout/PhabricatorPinboardView.php