recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Remove 750ms timeout on owners path validation

Summary:
Ref T13164. See PHI748. Path validation has a 750ms timeout which blames to rP5038ab850c, in 2011.

Production path validation is sometimes taking more than 750ms, particularly on the initial page load where we may validate many paths simultaneously.

I have no idea why we have this timeout, and it isn't consistent with how we perform other AJAX requests. Just remove it.

Test Plan:
- Reproduced issue in production, saw all validation calls failing at 750ms. Actual underlying calls succeed, they just take more than 750ms to resolve.
- Loaded path validator locally, got green checkmark.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13164

Differential Revision: https://secure.phabricator.com/D19575

epriestley 9a15129b 92a29f72

+10 -12
+10 -10
resources/celerity/map.php
··· 393 393 'rsrc/js/application/files/behavior-launch-icon-composer.js' => '48086888', 394 394 'rsrc/js/application/harbormaster/behavior-harbormaster-log.js' => '549459b8', 395 395 'rsrc/js/application/herald/HeraldRuleEditor.js' => 'dca75c0e', 396 - 'rsrc/js/application/herald/PathTypeahead.js' => '662e9cea', 396 + 'rsrc/js/application/herald/PathTypeahead.js' => '6d8c7912', 397 397 'rsrc/js/application/herald/herald-rule-editor.js' => '7ebaeed3', 398 398 'rsrc/js/application/maniphest/behavior-batch-selector.js' => 'ad54037e', 399 399 'rsrc/js/application/maniphest/behavior-line-chart.js' => 'e4232876', ··· 739 739 'owners-path-editor' => 'c96502cf', 740 740 'owners-path-editor-css' => '9c136c29', 741 741 'paste-css' => '9fcc9773', 742 - 'path-typeahead' => '662e9cea', 742 + 'path-typeahead' => '6d8c7912', 743 743 'people-picture-menu-item-css' => 'a06f7f34', 744 744 'people-profile-css' => '4df76faf', 745 745 'phabricator-action-list-view-css' => '0bcd9a45', ··· 1353 1353 'javelin-workflow', 1354 1354 'javelin-dom', 1355 1355 ), 1356 - '662e9cea' => array( 1357 - 'javelin-install', 1358 - 'javelin-typeahead', 1359 - 'javelin-dom', 1360 - 'javelin-request', 1361 - 'javelin-typeahead-ondemand-source', 1362 - 'javelin-util', 1363 - ), 1364 1356 66888767 => array( 1365 1357 'javelin-behavior', 1366 1358 'javelin-stratcom', ··· 1435 1427 'javelin-dom', 1436 1428 'javelin-typeahead', 1437 1429 'javelin-uri', 1430 + ), 1431 + '6d8c7912' => array( 1432 + 'javelin-install', 1433 + 'javelin-typeahead', 1434 + 'javelin-dom', 1435 + 'javelin-request', 1436 + 'javelin-typeahead-ondemand-source', 1437 + 'javelin-util', 1438 1438 ), 1439 1439 '70baed2f' => array( 1440 1440 'javelin-install',
-2
webroot/rsrc/js/application/herald/PathTypeahead.js
··· 208 208 209 209 this._validationInflight = validation_request; 210 210 JX.DOM.setContent(error_display, JX.$H(this._icons.test)); 211 - 212 - validation_request.setTimeout(750); 213 211 validation_request.send(); 214 212 } 215 213 }