@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Audit - fix a bug with unloaded repositories
Summary:
...because its always at least the string <ATTACHABLE>... Not sure when we'd hit this / see the TODO about making it better, but its definitely a logic bug right now.
(an update to D12347 helped me notice that this conditional is always hit and may fatal later)
Test Plan: NA
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D12348
+2
-2
+2
-2
src/applications/audit/editor/PhabricatorAuditEditor.php
+2
-2
src/applications/audit/editor/PhabricatorAuditEditor.php
···
961
961
962
962
// not every code path loads the repository so tread carefully
963
963
// TODO: They should, and then we should simplify this.
964
-
if ($object->getRepository($assert_attached = false)) {
965
-
$repository = $object->getRepository();
964
+
$repository = $object->getRepository($assert_attached = false);
965
+
if ($repository != PhabricatorLiskDAO::ATTACHABLE) {
966
966
if (!$repository->shouldPublish()) {
967
967
return false;
968
968
}