recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix PHP 8.1 "strlen(null)" exceptions which block rendering the People page of a user

Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15318

Test Plan:
Applied these five changes on top of D25147 and D25153, and both `/p/username/`
and `/people/manage/userid/` finally rendered in web browser.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15318

Differential Revision: https://we.phorge.it/D25167

Andre Klapper 9aa8d09d 5a76e8d2

+5 -5
+1 -1
src/applications/people/menuitem/PhabricatorPeopleBadgesProfileMenuItem.php
··· 22 22 PhabricatorProfileMenuItemConfiguration $config) { 23 23 $name = $config->getMenuItemProperty('name'); 24 24 25 - if (strlen($name)) { 25 + if (phutil_nonempty_string($name)) { 26 26 return $name; 27 27 } 28 28
+1 -1
src/applications/people/menuitem/PhabricatorPeopleCommitsProfileMenuItem.php
··· 22 22 PhabricatorProfileMenuItemConfiguration $config) { 23 23 $name = $config->getMenuItemProperty('name'); 24 24 25 - if (strlen($name)) { 25 + if (phutil_nonempty_string($name)) { 26 26 return $name; 27 27 } 28 28
+1 -1
src/applications/people/menuitem/PhabricatorPeopleManageProfileMenuItem.php
··· 22 22 PhabricatorProfileMenuItemConfiguration $config) { 23 23 $name = $config->getMenuItemProperty('name'); 24 24 25 - if (strlen($name)) { 25 + if (phutil_nonempty_string($name)) { 26 26 return $name; 27 27 } 28 28
+1 -1
src/applications/people/menuitem/PhabricatorPeopleRevisionsProfileMenuItem.php
··· 22 22 PhabricatorProfileMenuItemConfiguration $config) { 23 23 $name = $config->getMenuItemProperty('name'); 24 24 25 - if (strlen($name)) { 25 + if (phutil_nonempty_string($name)) { 26 26 return $name; 27 27 } 28 28
+1 -1
src/applications/people/menuitem/PhabricatorPeopleTasksProfileMenuItem.php
··· 22 22 PhabricatorProfileMenuItemConfiguration $config) { 23 23 $name = $config->getMenuItemProperty('name'); 24 24 25 - if (strlen($name)) { 25 + if (phutil_nonempty_string($name)) { 26 26 return $name; 27 27 } 28 28