@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Make tokens more accessible to assitive technologies
Summary:
Ref T4843.
- The token award buttons are just icons.
- The tokens themselves are just icons.
- Also spread the tokens out a tiny bit, they feel a little tight to me right now.
Test Plan: Used VoiceOver to read out tokens and token actions. Looked at an object with several token awards.
Reviewers: chad, btrahan
Reviewed By: btrahan
Subscribers: epriestley
Maniphest Tasks: T4843
Differential Revision: https://secure.phabricator.com/D8982
+31
-4
+2
-2
resources/celerity/map.php
+2
-2
resources/celerity/map.php
···
103
103
'rsrc/css/application/settings/settings.css' => 'ea8f5915',
104
104
'rsrc/css/application/slowvote/slowvote.css' => '266df6a1',
105
105
'rsrc/css/application/subscriptions/subscribers-list.css' => '5bb30c78',
106
-
'rsrc/css/application/tokens/tokens.css' => '5f7bca25',
106
+
'rsrc/css/application/tokens/tokens.css' => '3d0f239e',
107
107
'rsrc/css/application/uiexample/example.css' => '528b19de',
108
108
'rsrc/css/core/core.css' => '7dff07c3',
109
109
'rsrc/css/core/remarkup.css' => '0ec9ea61',
···
806
806
'sprite-tokens-css' => '1706b943',
807
807
'subscribers-list-css' => '5bb30c78',
808
808
'syntax-highlighting-css' => '3c18c1cb',
809
-
'tokens-css' => '5f7bca25',
809
+
'tokens-css' => '3d0f239e',
810
810
),
811
811
'requires' =>
812
812
array(
+11
-1
src/applications/tokens/controller/PhabricatorTokenGiveController.php
+11
-1
src/applications/tokens/controller/PhabricatorTokenGiveController.php
···
73
73
$buttons = array();
74
74
$ii = 0;
75
75
foreach ($tokens as $token) {
76
+
$aural = javelin_tag(
77
+
'span',
78
+
array(
79
+
'aural' => true,
80
+
),
81
+
pht('Award "%s" Token', $token->getName()));
82
+
76
83
$buttons[] = javelin_tag(
77
84
'button',
78
85
array(
···
85
92
'tip' => $token->getName(),
86
93
)
87
94
),
88
-
$token->renderIcon());
95
+
array(
96
+
$aural,
97
+
$token->renderIcon(),
98
+
));
89
99
if ((++$ii % 4) == 0) {
90
100
$buttons[] = phutil_tag('br');
91
101
}
+14
-1
src/applications/tokens/event/PhabricatorTokenUIEventListener.php
+14
-1
src/applications/tokens/event/PhabricatorTokenUIEventListener.php
···
115
115
}
116
116
117
117
$token = $tokens[$token_given->getTokenPHID()];
118
+
$aural = javelin_tag(
119
+
'span',
120
+
array(
121
+
'aural' => true,
122
+
),
123
+
pht(
124
+
'"%s" token, awarded by %s.',
125
+
$token->getName(),
126
+
$handles[$token_given->getAuthorPHID()]->getName()));
118
127
119
128
$list[] = javelin_tag(
120
129
'span',
121
130
array(
122
131
'sigil' => 'has-tooltip',
132
+
'class' => 'token-icon',
123
133
'meta' => array(
124
134
'tip' => $handles[$token_given->getAuthorPHID()]->getName(),
125
135
),
126
136
),
127
-
$token->renderIcon());
137
+
array(
138
+
$aural,
139
+
$token->renderIcon(),
140
+
));
128
141
}
129
142
130
143
$view = $event->getValue('view');