+1 -1

scripts/setup/manage_garbage.php

reviewed

··· 5 5 require_once $root.'/scripts/__init_script__.php'; 6 6 7 7 $args = new PhutilArgumentParser($argv); 8 8 - $args->setTagline(pht('manage garbage colletors')); 8 8 + $args->setTagline(pht('manage garbage collectors')); 9 9 $args->setSynopsis(<<<EOSYNOPSIS 10 10 **garbage** __command__ [__options__] 11 11 Manage garbage collectors.

+1 -1

src/aphront/httpparametertype/AphrontHTTPParameterType.php

reviewed

··· 160 160 /** 161 161 * Call another type's existence check. 162 162 * 163 163 - * This method allows a type to reuse the exitence behavior of a different 163 163 + * This method allows a type to reuse the existence behavior of a different 164 164 * type. For example, a "list of users" type may have the same basic 165 165 * existence check that a simpler "list of strings" type has, and can just 166 166 * call the simpler type to reuse its behavior.

+1 -1

src/applications/almanac/editor/AlmanacDeviceEditor.php

reviewed

··· 204 204 $xaction); 205 205 $errors[] = $error; 206 206 } else { 207 207 - // TODO: Validate addresses, but IPv6 addresses are not trival 207 207 + // TODO: Validate addresses, but IPv6 addresses are not trivial 208 208 // to validate. 209 209 } 210 210

+1 -1

src/applications/audit/view/PhabricatorAuditListView.php

reviewed

··· 63 63 return $summary; 64 64 } 65 65 66 66 - // No summary, so either this is still impoting or just has an empty 66 66 + // No summary, so either this is still importing or just has an empty 67 67 // commit message. 68 68 69 69 if (!$commit->isImported()) {

+1 -1

src/applications/auth/controller/PhabricatorAuthController.php

reviewed

··· 134 134 // checks later on to make sure this account is valid for the intended 135 135 // operation. This requires edit permission for completeness and consistency 136 136 // but it won't actually be meaningfully checked because we're using the 137 137 - // ominpotent user. 137 137 + // omnipotent user. 138 138 139 139 $account = id(new PhabricatorExternalAccountQuery()) 140 140 ->setViewer(PhabricatorUser::getOmnipotentUser())

+1 -1

src/applications/auth/controller/PhabricatorAuthRegisterController.php

reviewed

··· 79 79 } 80 80 81 81 if ($default_email !== null) { 82 82 - // We should bypass policy here becase e.g. limiting an application use 82 82 + // We should bypass policy here because e.g. limiting an application use 83 83 // to a subset of users should not allow the others to overwrite 84 84 // configured application emails. 85 85 $application_email = id(new PhabricatorMetaMTAApplicationEmailQuery())

+1 -1

src/applications/auth/editor/PhabricatorAuthSSHKeyEditor.php

reviewed

··· 226 226 ->addHeader('Thread-Topic', $phid); 227 227 228 228 // The primary value of this mail is alerting users to account compromises, 229 229 - // so force delivery. In particular, this mail should still be delievered 229 229 + // so force delivery. In particular, this mail should still be delivered 230 230 // even if "self mail" is disabled. 231 231 $mail->setForceDelivery(true); 232 232

+1 -1

src/applications/auth/factor/__tests__/PhabricatorAuthInviteTestCase.php

reviewed

··· 51 51 $caught = $ex; 52 52 } 53 53 54 54 - // This first time should accept the invite and verify the addresss. 54 54 + // This first time should accept the invite and verify the address. 55 55 $this->assertTrue( 56 56 ($caught instanceof PhabricatorAuthInviteRegisteredException)); 57 57

+1 -1

src/applications/auth/management/PhabricatorAuthManagementRevokeWorkflow.php

reviewed

··· 74 74 if (!strlen($from) && !$is_everywhere) { 75 75 throw new PhutilArgumentUsageException( 76 76 pht( 77 77 - 'Specify the target to revoke credentals from with "--from" or '. 77 77 + 'Specify the target to revoke credentials from with "--from" or '. 78 78 'specify "--everywhere".')); 79 79 } else if (strlen($from) && $is_everywhere) { 80 80 throw new PhutilArgumentUsageException(

+1 -1

src/applications/auth/provider/PhabricatorOAuth1AuthProvider.php

reviewed

··· 270 270 } 271 271 272 272 private function getHandshakeTokenKeyFromClientCode($client_code) { 273 273 - // NOTE: This is very slightly coersive since the TemporaryToken table 273 273 + // NOTE: This is very slightly coercive since the TemporaryToken table 274 274 // expects an "objectPHID" as an identifier, but nothing about the storage 275 275 // is bound to PHIDs. 276 276

+1 -1

src/applications/base/PhabricatorApplication.php

reviewed

··· 108 108 * 109 109 * Launchable applications can be pinned to the home page, and show up in the 110 110 * "Launcher" view of the Applications application. Making an application 111 111 - * unlauncahble prevents pinning and hides it from this view. 111 111 + * unlaunchable prevents pinning and hides it from this view. 112 112 * 113 113 * Usually, an application should be marked unlaunchable if: 114 114 *

+1 -1

src/applications/base/controller/PhabricatorController.php

reviewed

··· 552 552 553 553 554 554 public function buildApplicationCrumbsForEditEngine() { 555 555 - // TODO: This is kind of gross, I'm bascially just making this public so 555 555 + // TODO: This is kind of gross, I'm basically just making this public so 556 556 // I can use it in EditEngine. We could do this without making it public 557 557 // by using controller delegation, or make it properly public. 558 558 return $this->buildApplicationCrumbs();

+1 -1

src/applications/calendar/editor/PhabricatorCalendarImportEditEngine.php

reviewed

··· 134 134 $fields[] = id(new PhabricatorSelectEditField()) 135 135 ->setKey('frequency') 136 136 ->setLabel(pht('Update Automatically')) 137 137 - ->setDescription(pht('Configure an automatic update frequncy.')) 137 137 + ->setDescription(pht('Configure an automatic update frequency.')) 138 138 ->setTransactionType( 139 139 PhabricatorCalendarImportFrequencyTransaction::TRANSACTIONTYPE) 140 140 ->setConduitDescription(pht('Set the automatic update frequency.'))

+1 -1

src/applications/calendar/icon/PhabricatorCalendarIconSet.php

reviewed

··· 16 16 'fa-plane' => pht('Travel'), 17 17 'fa-plus-square' => pht('Health / Appointment'), 18 18 19 19 - 'fa-rocket' => pht('Sabatical / Leave'), 19 19 + 'fa-rocket' => pht('Sabbatical / Leave'), 20 20 'fa-home' => pht('Working From Home'), 21 21 'fa-tree' => pht('Holiday'), 22 22 'fa-gamepad' => pht('Staycation'),

+1 -1

src/applications/calendar/util/CalendarTimeUtil.php

reviewed

··· 8 8 * calendar views - one for the conpherence calendar widget and one for the 9 9 * user profile calendar view. These have slight differences such as 10 10 * conpherence showing both a three day "today 'til 2 days from now" *and* 11 11 - * a Sunday -> Saturday list, whilest the profile view shows a more simple 11 11 + * a Sunday -> Saturday list, whilst the profile view shows a more simple 12 12 * seven day rolling list of events. 13 13 */ 14 14 final class CalendarTimeUtil extends Phobject {

+2 -2

src/applications/calendar/xaction/PhabricatorCalendarEventFrequencyTransaction.php

reviewed

··· 23 23 // month, it means "the 30th of every month" as far as the RRULE is 24 24 // concerned. Such an event will not occur on months with fewer days. 25 25 26 26 - // This is surprising, and proably not what the user wants. Instead, 26 26 + // This is surprising, and probably not what the user wants. Instead, 27 27 // schedule these events relative to the end of the month: on the "-1st", 28 28 // "-2nd" or "-3rd" day of the month. For example, a monthly event on 29 29 // the 31st of a 31-day month translates to "every month, on the last ··· 66 66 if (!isset($valid[$value])) { 67 67 $errors[] = $this->newInvalidError( 68 68 pht( 69 69 - 'Event frequency "%s" is not valid. Valid frequences are: %s.', 69 69 + 'Event frequency "%s" is not valid. Valid frequencies are: %s.', 70 70 $value, 71 71 implode(', ', $valid)), 72 72 $xaction);

+2 -2

src/applications/calendar/xaction/PhabricatorCalendarEventInviteTransaction.php

reviewed

··· 132 132 $this->renderHandleList($rem)); 133 133 } else { 134 134 return pht( 135 135 - '%s invited %s attendee(s): %s; uninvinted %s attendee(s): %s.', 135 135 + '%s invited %s attendee(s): %s; uninvited %s attendee(s): %s.', 136 136 $this->renderAuthor(), 137 137 phutil_count($add), 138 138 $this->renderHandleList($add), ··· 161 161 } else { 162 162 return pht( 163 163 '%s updated the invite list for %s, invited %s: %s; '. 164 164 - 'uninvinted %s: %s.', 164 164 + 'uninvited %s: %s.', 165 165 $this->renderAuthor(), 166 166 $this->renderObject(), 167 167 phutil_count($add),

+1 -1

src/applications/calendar/xaction/PhabricatorCalendarImportFrequencyTransaction.php

reviewed

··· 32 32 if (!isset($valid[$value])) { 33 33 $errors[] = $this->newInvalidError( 34 34 pht( 35 35 - 'Import frequency "%s" is not valid. Valid frequences are: %s.', 35 35 + 'Import frequency "%s" is not valid. Valid frequencies are: %s.', 36 36 $value, 37 37 implode(', ', $valid)), 38 38 $xaction);

+1 -1

src/applications/config/check/PhabricatorStorageSetupCheck.php

reviewed

··· 85 85 'be buffered into memory before being written to permanent '. 86 86 'storage. Phabricator needs memory available to store these '. 87 87 'chunks while they are uploaded, but PHP is currently configured '. 88 88 - 'to severly limit the available memory.'. 88 88 + 'to severely limit the available memory.'. 89 89 "\n\n". 90 90 'PHP processes currently have very little free memory available '. 91 91 '(%s). To work well, processes should have at least %s.'.

+1 -1

src/applications/conpherence/query/ConpherenceThreadQuery.php

reviewed

··· 290 290 ->withObjectPHIDs(array_keys($conpherences)) 291 291 ->needHandles(true); 292 292 293 293 - // We have to flip these for the underyling query class. The semantics of 293 293 + // We have to flip these for the underlying query class. The semantics of 294 294 // paging are tricky business. 295 295 if ($this->afterTransactionID) { 296 296 $query->setBeforeID($this->afterTransactionID);

+1 -1

src/applications/dashboard/customfield/PhabricatorDashboardPanelTabsCustomField.php

reviewed

··· 78 78 79 79 public function renderEditControl(array $handles) { 80 80 // NOTE: This includes archived panels so we don't mutate the tabs 81 81 - // when saving a tab panel that includes archied panels. This whole UI is 81 81 + // when saving a tab panel that includes archived panels. This whole UI is 82 82 // hopefully temporary anyway. 83 83 84 84 $value = $this->getFieldValue();

+1 -1

src/applications/differential/controller/DifferentialController.php

reviewed

··· 217 217 // by default and let the user toggle the rest. With modern messages, 218 218 // we can send the user to the Harbormaster detail page. Just show 219 219 // "a lot" of messages in legacy cases to try to strike a balance 220 220 - // between implementation simplicitly and compatibility. 220 220 + // between implementation simplicity and compatibility. 221 221 $legacy_messages = array_slice($legacy_messages, 0, 100); 222 222 223 223 $messages = array();

+1 -1

src/applications/differential/customfield/DifferentialHarbormasterField.php

reviewed

··· 45 45 // by default and let the user toggle the rest. With modern messages, 46 46 // we can send the user to the Harbormaster detail page. Just show 47 47 // "a lot" of messages in legacy cases to try to strike a balance 48 48 - // between implementation simplicitly and compatibility. 48 48 + // between implementation simplicity and compatibility. 49 49 $legacy_messages = array_slice($legacy_messages, 0, 100); 50 50 51 51 foreach ($legacy_messages as $message) {

+1 -1

src/applications/differential/editor/DifferentialDiffEditor.php

reviewed

··· 106 106 * We run Herald as part of transaction validation because Herald can 107 107 * block diff creation for Differential diffs. Its important to do this 108 108 * separately so no Herald logs are saved; these logs could expose 109 109 - * information the Herald rules are inteneded to block. 109 109 + * information the Herald rules are intended to block. 110 110 */ 111 111 protected function validateTransaction( 112 112 PhabricatorLiskDAO $object,

+3 -3

src/applications/differential/parser/DifferentialChangesetParser.php

reviewed

··· 699 699 $hunk_parser->parseHunksForLineData($changeset->getHunks()); 700 700 701 701 // Depending on the whitespace mode, we may need to compute a different 702 702 - // set of changes than the set of changes in the hunk data (specificaly, 702 702 + // set of changes than the set of changes in the hunk data (specifically, 703 703 // we might want to consider changed lines which have only whitespace 704 704 // changes as unchanged). 705 705 if ($ignore_all) { ··· 1192 1192 * Mask - compute the actual lines that need to be shown (because they 1193 1193 * are near changes lines, near inline comments, or the request has 1194 1194 * explicitly asked for them, i.e. resulting from the user clicking 1195 1195 - * "show more"). The $mask returned is a sparesely populated dictionary 1195 1195 + * "show more"). The $mask returned is a sparsely populated dictionary 1196 1196 * of $visible_line_number => true. 1197 1197 * 1198 1198 * Depths - compute how indented any given line is. The $depths returned 1199 1199 - * is a sparesely populated dictionary of $visible_line_number => $depth. 1199 1199 + * is a sparsely populated dictionary of $visible_line_number => $depth. 1200 1200 * 1201 1201 * This function also has the side effect of modifying member variable 1202 1202 * new such that tabs are normalized to spaces for each line of the diff.

+1 -1

src/applications/differential/storage/DifferentialModernHunk.php

reviewed

··· 128 128 $this->setData($file->getPHID()); 129 129 130 130 // NOTE: Because hunks don't have a PHID and we just load hunk data with 131 131 - // the ominipotent viewer, we do not need to attach the file to anything. 131 131 + // the omnipotent viewer, we do not need to attach the file to anything. 132 132 133 133 $result = $this->save(); 134 134

+2 -2

src/applications/differential/storage/DifferentialRevision.php

reviewed

··· 442 442 443 443 // For each path which the viewer owns a package for, find other packages 444 444 // which that authority can be used to force-accept. Once we find a way to 445 445 - // force-accept a package, we don't need to keep loooking. 445 445 + // force-accept a package, we don't need to keep looking. 446 446 $has_control = array(); 447 447 foreach ($force_map as $path => $spec) { 448 448 $path_fragments = PhabricatorOwnersPackage::splitPath($path); ··· 891 891 self::TABLE_COMMIT, 892 892 $this->getID()); 893 893 894 894 - // we have to do paths a little differentally as they do not have 894 894 + // we have to do paths a little differently as they do not have 895 895 // an id or phid column for delete() to act on 896 896 $dummy_path = new DifferentialAffectedPath(); 897 897 queryfx(

+1 -1

src/applications/differential/typeahead/DifferentialResponsibleViewerFunctionDatasource.php

reviewed

··· 22 22 'summary' => pht('Use the current viewing user.'), 23 23 'description' => pht( 24 24 'Show revisions the current viewer is responsible for. This '. 25 25 - 'function inclues revisions the viewer is responsible for through '. 25 25 + 'function includes revisions the viewer is responsible for through '. 26 26 'membership in projects and packages.'), 27 27 ), 28 28 );

+1 -1

src/applications/diffusion/controller/DiffusionCommitController.php

reviewed

··· 479 479 // chains of events). This should be rare, but does not indicate a bug 480 480 // or data issue. 481 481 482 482 - // NOTE: We never query push logs in SVN because the commiter is always 482 482 + // NOTE: We never query push logs in SVN because the committer is always 483 483 // the pusher and the commit time is always the push time; the push log 484 484 // is redundant and we save a query by skipping it. 485 485

+3 -3

src/applications/diffusion/editor/DiffusionRepositoryEditEngine.php

reviewed

··· 338 338 ->setIsCopyable(true) 339 339 ->setDescription(pht('Track only these branches.')) 340 340 ->setConduitDescription(pht('Set the tracked branches.')) 341 341 - ->setConduitTypeDescription(pht('New tracked branchs.')) 341 341 + ->setConduitTypeDescription(pht('New tracked branches.')) 342 342 ->setValue($track_value), 343 343 id(new PhabricatorTextAreaEditField()) 344 344 ->setIsStringList(true) ··· 349 349 ->setIsCopyable(true) 350 350 ->setDescription(pht('Autoclose commits on only these branches.')) 351 351 ->setConduitDescription(pht('Set the autoclose branches.')) 352 352 - ->setConduitTypeDescription(pht('New default tracked branchs.')) 352 352 + ->setConduitTypeDescription(pht('New default tracked branches.')) 353 353 ->setValue($autoclose_value), 354 354 id(new PhabricatorTextEditField()) 355 355 ->setKey('importOnly') ··· 396 396 ->setConduitDescription( 397 397 pht('Change symbol languages for this repository.')) 398 398 ->setConduitTypeDescription( 399 399 - pht('New symbol langauges.')) 399 399 + pht('New symbol languages.')) 400 400 ->setValue($object->getSymbolLanguages()), 401 401 id(new PhabricatorDatasourceEditField()) 402 402 ->setKey('symbolRepositoryPHIDs')

+1 -1

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

reviewed

··· 1230 1230 // also look at author data (do the commits come from multiple different 1231 1231 // authors?) and commit date data (is the oldest commit more than 48 hours 1232 1232 // old), but we don't have immediate access to those and this simple 1233 1233 - // heruistic might be good enough. 1233 1233 + // heuristic might be good enough. 1234 1234 1235 1235 $commit_count = 0; 1236 1236 $type_commit = PhabricatorRepositoryPushLog::REFTYPE_COMMIT;

+1 -1

src/applications/diffusion/gitlfs/DiffusionGitLFSAuthenticateWorkflow.php

reviewed

··· 80 80 81 81 $lfs_uri = $repository->getGitLFSURI('info/lfs'); 82 82 83 83 - // Generate a temporary token to allow the user to acces LFS over HTTP. 83 83 + // Generate a temporary token to allow the user to access LFS over HTTP. 84 84 // This works even if normal HTTP repository operations are not available 85 85 // on this host, and does not require the user to have a VCS password. 86 86

+1 -1

src/applications/diffusion/herald/HeraldCommitAdapter.php

reviewed

··· 112 112 $phids[] = $repository_phid; 113 113 114 114 // NOTE: This is projects for the repository, not for the commit. When 115 115 - // Herald evalutes, commits normally can not have any project tags yet. 115 115 + // Herald evaluates, commits normally can not have any project tags yet. 116 116 $repository_project_phids = PhabricatorEdgeQuery::loadDestinationPHIDs( 117 117 $repository_phid, 118 118 $project_type);

+1 -1

src/applications/diffusion/protocol/DiffusionCommandEngine.php

reviewed

··· 178 178 if (!$device) { 179 179 throw new Exception( 180 180 pht( 181 181 - 'Attempting to build a reposiory command (for repository "%s") '. 181 181 + 'Attempting to build a repository command (for repository "%s") '. 182 182 'as device, but this host ("%s") is not configured as a cluster '. 183 183 'device.', 184 184 $repository->getDisplayName(),

+1 -1

src/applications/diffusion/protocol/DiffusionMercurialWireProtocol.php

reviewed

··· 101 101 102 102 /** If the server version is running 3.4+ it will respond 103 103 * with 'bundle2' capability in the format of "bundle2=(url-encoding)". 104 104 - * Until we maange to properly package up bundles to send back we 104 104 + * Until we manage to properly package up bundles to send back we 105 105 * disallow the client from knowing we speak bundle2 by removing it 106 106 * from the capabilities listing. 107 107 *

+2 -2

src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php

reviewed

··· 231 231 // no way to tell which one has the "right" data. If we pick wrong, we 232 232 // might erase some or all of the data in the repository. 233 233 234 234 - // Since this is dangeorus, we refuse to guess unless there is only one 234 234 + // Since this is dangerous, we refuse to guess unless there is only one 235 235 // device. If we're the only device in the group, we obviously must be 236 236 // a leader. 237 237 ··· 252 252 'Repository "%s" exists on more than one device, but no device '. 253 253 'has any repository version information. Phabricator can not '. 254 254 'guess which copy of the existing data is authoritative. Promote '. 255 255 - 'a device or see "Ambigous Leaders" in the documentation.', 255 255 + 'a device or see "Ambiguous Leaders" in the documentation.', 256 256 $repository->getDisplayName())); 257 257 } 258 258

+1 -1

src/applications/diffusion/query/DiffusionCachedResolveRefsQuery.php

reviewed

··· 9 9 * low-level query can. 10 10 * 11 11 * This class can resolve the most common refs (commits, branches, tags) and 12 12 - * can do so cheapy (by examining the database, without needing to make calls 12 12 + * can do so cheaply (by examining the database, without needing to make calls 13 13 * to the VCS or the service host). 14 14 */ 15 15 final class DiffusionCachedResolveRefsQuery

+1 -1

src/applications/diffusion/query/DiffusionCommitQuery.php

reviewed

··· 69 69 70 70 /** 71 71 * Look up commits in a specific repository. Prefer 72 72 - * @{method:withRepositoryIDs}; the underyling table is keyed by ID such 72 72 + * @{method:withRepositoryIDs}; the underlying table is keyed by ID such 73 73 * that this method requires a separate initial query to map PHID to ID. 74 74 */ 75 75 public function withRepositoryPHIDs(array $phids) {

+1 -1

src/applications/diffusion/xaction/DiffusionCommitConcernTransaction.php

reviewed

··· 53 53 } 54 54 55 55 // Even if you've already raised a concern, you can raise again as long 56 56 - // as the author requsted you verify. 56 56 + // as the author requested you verify. 57 57 $state_verify = PhabricatorAuditCommitStatusConstants::NEEDS_VERIFICATION; 58 58 59 59 if ($this->isViewerFullyRejected($object, $viewer)) {

+1 -1

src/applications/diffusion/xaction/DiffusionCommitVerifyTransaction.php

reviewed

··· 53 53 throw new Exception( 54 54 pht( 55 55 'You can not request verification of this commit because no '. 56 56 - 'auditors have raised conerns with it.')); 56 56 + 'auditors have raised concerns with it.')); 57 57 } 58 58 } 59 59

+2 -2

src/applications/drydock/blueprint/DrydockBlueprintImplementation.php

reviewed

··· 64 64 * is a coarse compatibility check between a lease and a resource. 65 65 * 66 66 * @param DrydockBlueprint Concrete blueprint to allocate for. 67 67 - * @param DrydockResource Candidiate resource to allocate the lease on. 67 67 + * @param DrydockResource Candidate resource to allocate the lease on. 68 68 * @param DrydockLease Pending lease that wants to allocate here. 69 69 * @return bool True if the resource and lease are compatible. 70 70 * @task lease ··· 76 76 77 77 78 78 /** 79 79 - * Acquire a lease. Allows resources to peform setup as leases are brought 79 79 + * Acquire a lease. Allows resources to perform setup as leases are brought 80 80 * online. 81 81 * 82 82 * If acquisition fails, throw an exception.

+1 -1

src/applications/drydock/storage/DrydockAuthorization.php

reviewed

··· 100 100 } 101 101 102 102 /** 103 103 - * Apply external authorization effects after a user chagnes the value of a 103 103 + * Apply external authorization effects after a user changes the value of a 104 104 * blueprint selector control an object. 105 105 * 106 106 * @param PhabricatorUser User applying the change.

+3 -3

src/applications/drydock/worker/DrydockLeaseUpdateWorker.php

reviewed

··· 241 241 // NOTE: We have not acquired the lease yet, so it is possible that the 242 242 // resource we just built will be snatched up by some other lease before 243 243 // we can acquire it. This is not problematic: we'll retry a little later 244 244 - // and should suceed eventually. 244 244 + // and should succeed eventually. 245 245 } 246 246 247 247 $resources = $this->rankResources($resources, $lease); ··· 261 261 if (!$allocated) { 262 262 throw new PhutilAggregateException( 263 263 pht( 264 264 - 'Unable to acquire lease "%s" on any resouce.', 264 264 + 'Unable to acquire lease "%s" on any resource.', 265 265 $lease->getPHID()), 266 266 $exceptions); 267 267 } ··· 725 725 // performed the read above and now, the resource might have closed, so 726 726 // we may activate leases on dead resources. At least for now, this seems 727 727 // fine: a resource dying right before we activate a lease on it should not 728 728 - // be distinguisahble from a resource dying right after we activate a lease 728 728 + // be distinguishable from a resource dying right after we activate a lease 729 729 // on it. We end up with an active lease on a dead resource either way, and 730 730 // can not prevent resources dying from lightning strikes. 731 731

+1 -1

src/applications/drydock/worker/DrydockWorker.php

reviewed

··· 199 199 $viewer = $this->getViewer(); 200 200 201 201 // Don't reclaim a resource if it has been updated recently. If two 202 202 - // leases are fighting, we don't want them to keep reclaming resources 202 202 + // leases are fighting, we don't want them to keep reclaiming resources 203 203 // from one another forever without making progress, so make resources 204 204 // immune to reclamation for a little while after they activate or update. 205 205

+1 -1

src/applications/files/controller/PhabricatorFileDataController.php

reviewed

··· 119 119 // make this logic simpler and more consistent. 120 120 121 121 // Beyond making the policy check itself more consistent, this also makes 122 122 - // sure we're consitent about returning HTTP 404 on bad requests instead 122 122 + // sure we're consistent about returning HTTP 404 on bad requests instead 123 123 // of serving HTTP 200 with a login page, which can mislead some clients. 124 124 125 125 $viewer = PhabricatorUser::getOmnipotentUser();

+1 -1

src/applications/files/management/PhabricatorFilesManagementCatWorkflow.php

reviewed

··· 24 24 'help' => pht( 25 25 'DANGEROUS. Attempt to salvage file content even if the '. 26 26 'integrity check fails. If an adversary has tampered with '. 27 27 - 'the file, the conent may be unsafe.'), 27 27 + 'the file, the content may be unsafe.'), 28 28 ), 29 29 array( 30 30 'name' => 'names',

+1 -1

src/applications/fund/editor/FundInitiativeEditEngine.php

reviewed

··· 50 50 } 51 51 52 52 protected function getObjectName() { 53 53 - return pht('Initivative'); 53 53 + return pht('Initiative'); 54 54 } 55 55 56 56 protected function getObjectCreateCancelURI($object) {

+2 -2

src/applications/harbormaster/conduit/HarbormasterSendMessageConduitAPIMethod.php

reviewed

··· 142 142 "=============\n". 143 143 "When you send Harbormaster a message, you must include a `type`, ". 144 144 "which describes the overall state of the build. For example, use ". 145 145 - "`pass` to tell Harbomaster that a build completed successfully.". 145 145 + "`pass` to tell Harbormaster that a build completed successfully.". 146 146 "\n\n". 147 147 "Supported message types are:". 148 148 "\n\n". ··· 155 155 "message, but you can also send a `work` message to report intermediate ". 156 156 "results.\n\n". 157 157 "To provide unit test results, pass a list of results in the `unit` ". 158 158 - "parameter. Each result shoud be a dictionary with these keys:". 158 158 + "parameter. Each result should be a dictionary with these keys:". 159 159 "\n\n". 160 160 "%s". 161 161 "\n\n".

+1 -1

src/applications/harbormaster/storage/configuration/HarbormasterBuildStep.php

reviewed

··· 38 38 // T6203/NULLABILITY 39 39 // This should not be nullable. Current `null` values indicate steps 40 40 // which predated editable names. These should be backfilled with 41 41 - // default names, then the code for handling `null` shoudl be removed. 41 41 + // default names, then the code for handling `null` should be removed. 42 42 'name' => 'text255?', 43 43 'stepAutoKey' => 'text32?', 44 44 ),

+1 -1

src/applications/legalpad/controller/LegalpadDocumentSignController.php

reviewed

··· 236 236 237 237 // Use the last content update as the modified date. We don't want to 238 238 // show that a document like a TOS was "updated" by an incidental change 239 239 - // to a field like the preamble or privacy settings which does not acutally 239 239 + // to a field like the preamble or privacy settings which does not actually 240 240 // affect the content of the agreement. 241 241 $content_updated = $document_body->getDateCreated(); 242 242

+2 -2

src/applications/maniphest/controller/ManiphestReportController.php

reviewed

··· 116 116 case ManiphestTaskMergedIntoTransaction::TRANSACTIONTYPE: 117 117 // NOTE: Merging a task does not generate a "status" transaction. 118 118 // We pretend it did. Note that this is not always accurate: it is 119 119 - // possble to merge a task which was previously closed, but this 119 119 + // possible to merge a task which was previously closed, but this 120 120 // fake transaction always counts a merge as a closure. 121 121 $oldv = $default_status; 122 122 $newv = $duplicate_status; ··· 762 762 // and equal distance in the past. This is so users can type "6 days" (which 763 763 // means "6 days from now") and get the behavior of "6 days ago", rather 764 764 // than no results (because the window epoch is in the future). This might 765 765 - // be a little confusing because it casues "tomorrow" to mean "yesterday" 765 765 + // be a little confusing because it causes "tomorrow" to mean "yesterday" 766 766 // and "2022" (or whatever) to mean "ten years ago", but these inputs are 767 767 // nonsense anyway. 768 768

+1 -1

src/applications/maniphest/editor/ManiphestTransactionEditor.php

reviewed

··· 972 972 973 973 $object_phid = $object->getPHID(); 974 974 975 975 - // We're doing layout with the ominpotent viewer to make sure we don't 975 975 + // We're doing layout with the omnipotent viewer to make sure we don't 976 976 // remove positions in columns that exist, but which the actual actor 977 977 // can't see. 978 978 $omnipotent_viewer = PhabricatorUser::getOmnipotentUser();

+1 -1

src/applications/metamta/management/PhabricatorMailManagementUnverifyWorkflow.php

reviewed

··· 63 63 echo tsprintf( 64 64 "%s\n", 65 65 pht( 66 66 - 'Address "%s" (owned by "%s") is already unveriifed.', 66 66 + 'Address "%s" (owned by "%s") is already unverified.', 67 67 $address, 68 68 $user->getUsername())); 69 69 continue;

+1 -1

src/applications/metamta/receiver/PhabricatorMailReceiver.php

reviewed

··· 255 255 256 256 257 257 /** 258 258 - * Reduce an email address to its canonical form. For example, an adddress 258 258 + * Reduce an email address to its canonical form. For example, an address 259 259 * like: 260 260 * 261 261 * "Abraham Lincoln" < ALincoln@example.com >

+1 -1

src/applications/owners/storage/__tests__/PhabricatorOwnersPackageTestCase.php

reviewed

··· 82 82 83 83 // Now, add a more specific path to Package #1. This tests nested ownership 84 84 // in packages with weak dominion rules. This time, Package #1 should end 85 85 - // up back on top, with Package #2 cedeing control to its more specific 85 85 + // up back on top, with Package #2 ceding control to its more specific 86 86 // path. 87 87 $rows[] = array( 88 88 'id' => 1,

+1 -1

src/applications/passphrase/credentialtype/PassphraseCredentialType.php

reviewed

··· 104 104 105 105 106 106 /** 107 107 - * Return true if the provided credental requires a password to decrypt. 107 107 + * Return true if the provided credential requires a password to decrypt. 108 108 * 109 109 * @param PhutilOpaqueEnvelope Credential secret value. 110 110 * @return bool True if the credential needs a password.

+1 -1

src/applications/passphrase/credentialtype/PassphraseSSHPrivateKeyTextCredentialType.php

reviewed

··· 47 47 pht( 48 48 'Decrypting SSH keys requires the `%s` binary, but it '. 49 49 'is not available in %s. Either make it available or strip the '. 50 50 - 'password fromt his SSH key manually before uploading it.', 50 50 + 'password from this SSH key manually before uploading it.', 51 51 'ssh-keygen', 52 52 '$PATH')); 53 53 }

+1 -1

src/applications/passphrase/view/PassphraseCredentialControl.php

reviewed

··· 67 67 $user_credential->getName()); 68 68 } 69 69 } catch (PhabricatorPolicyException $policy_exception) { 70 70 - // Pull the credential with the ominipotent viewer so we can look up 70 70 + // Pull the credential with the omnipotent viewer so we can look up 71 71 // the ID and provide the monogram. 72 72 $omnipotent_credential = id(new PassphraseCredentialQuery()) 73 73 ->setViewer(PhabricatorUser::getOmnipotentUser())

+1 -1

src/applications/people/markup/PhabricatorMentionRemarkupRule.php

reviewed

··· 10 10 11 11 // NOTE: The negative lookbehind prevents matches like "mail@lists", while 12 12 // allowing constructs like "@tomo/@mroch". Since we now allow periods in 13 13 - // usernames, we can't resonably distinguish that "@company.com" isn't a 13 13 + // usernames, we can't reasonably distinguish that "@company.com" isn't a 14 14 // username, so we'll incorrectly pick it up, but there's little to be done 15 15 // about that. We forbid terminal periods so that we can correctly capture 16 16 // "@joe" instead of "@joe." in "Hey, @joe.".

+2 -2

src/applications/people/query/PhabricatorPeopleQuery.php

reviewed

··· 425 425 } 426 426 427 427 // If the user is set to "Available" for this event, don't consider it 428 428 - // when computin their away status. 428 428 + // when computing their away status. 429 429 if (!$invitee->getDisplayAvailability($event)) { 430 430 continue; 431 431 } ··· 492 492 // valid for that long. 493 493 494 494 // NOTE: This doesn't handle overlapping events with the greatest 495 495 - // possible care. In theory, if you're attenting multiple events 495 495 + // possible care. In theory, if you're attending multiple events 496 496 // simultaneously we should accommodate that. However, it's complex 497 497 // to compute, rare, and probably not confusing most of the time. 498 498

+1 -1

src/applications/people/query/PhabricatorPeopleSearchEngine.php

reviewed

··· 79 79 ->setOptions( 80 80 pht('(Show All)'), 81 81 pht('Show Only Unapproved Users'), 82 82 - pht('Hide Unappproved Users')) 82 82 + pht('Hide Unapproved Users')) 83 83 ->setDescription( 84 84 pht( 85 85 'Pass true to find only users awaiting administrative approval, '.

+3 -3

src/applications/people/storage/PhabricatorUser.php

reviewed

··· 407 407 $token = substr($token, $breach_prelen + self::CSRF_SALT_LENGTH); 408 408 409 409 // When the user posts a form, we check that it contains a valid CSRF token. 410 410 - // Tokens cycle each hour (every CSRF_CYLCE_FREQUENCY seconds) and we accept 410 410 + // Tokens cycle each hour (every CSRF_CYCLE_FREQUENCY seconds) and we accept 411 411 // either the current token, the next token (users can submit a "future" 412 412 // token if you have two web frontends that have some clock skew) or any of 413 413 // the last 6 tokens. This means that pages are valid for up to 7 hours. ··· 1180 1180 /** 1181 1181 * Get a scalar string identifying this user. 1182 1182 * 1183 1183 - * This is similar to using the PHID, but distinguishes between ominpotent 1183 1183 + * This is similar to using the PHID, but distinguishes between omnipotent 1184 1184 * and public users explicitly. This allows safe construction of cache keys 1185 1185 * or cache buckets which do not conflate public and omnipotent users. 1186 1186 * ··· 1459 1459 id(new PhabricatorConduitSearchFieldSpecification()) 1460 1460 ->setKey('roles') 1461 1461 ->setType('list<string>') 1462 1462 - ->setDescription(pht('List of acccount roles.')), 1462 1462 + ->setDescription(pht('List of account roles.')), 1463 1463 ); 1464 1464 } 1465 1465

+1 -1

src/applications/phid/handle/pool/PhabricatorHandleList.php

reviewed

··· 82 82 if (!isset($this[$phid])) { 83 83 throw new Exception( 84 84 pht( 85 85 - 'Trying to create a new sublist of an existsing handle list, '. 85 85 + 'Trying to create a new sublist of an existing handle list, '. 86 86 'but PHID "%s" does not appear in the parent list.', 87 87 $phid)); 88 88 }

+1 -1

src/applications/phid/resolver/PhabricatorPHIDResolver.php

reviewed

··· 3 3 /** 4 4 * Resolve a list of identifiers into PHIDs. 5 5 * 6 6 - * This class simplifies the process of convering a list of mixed token types 6 6 + * This class simplifies the process of converting a list of mixed token types 7 7 * (like some PHIDs and some usernames) into a list of just PHIDs. 8 8 */ 9 9 abstract class PhabricatorPHIDResolver extends Phobject {

+1 -1

src/applications/phortune/provider/PhortuneStripePaymentProvider.php

reviewed

··· 361 361 case 'error:duplicate_transaction': 362 362 case 'error:processing_error': 363 363 default: 364 364 - // NOTE: These errors currently don't recevive a detailed message. 364 364 + // NOTE: These errors currently don't receive a detailed message. 365 365 // NOTE: We can also end up here with "http:nnn" messages. 366 366 367 367 // TODO: At least some of these should have a better message, or be

+1 -1

src/applications/phrequent/storage/PhrequentTimeBlock.php

reviewed

··· 124 124 } 125 125 } else { 126 126 // Here, we've prematurely ended a deeper stratum. Merge higher 127 127 - // stata. This looks like this: 127 127 + // strata. This looks like this: 128 128 // 129 129 // V 130 130 // V

+1 -1

src/applications/phriction/editor/PhrictionTransactionEditor.php

reviewed

··· 452 452 $verb) { 453 453 454 454 $errors = array(); 455 455 - // NOTE: We use the ominpotent user for these checks because policy 455 455 + // NOTE: We use the omnipotent user for these checks because policy 456 456 // doesn't matter; existence does. 457 457 $other_doc_viewer = PhabricatorUser::getOmnipotentUser(); 458 458 $ancestral_slugs = PhabricatorSlug::getAncestry($object->getSlug());

+1 -1

src/applications/policy/filter/PhabricatorPolicyFilter.php

reviewed

··· 257 257 $filtered[$key] = $object; 258 258 } 259 259 260 260 - // If we survied the primary checks, apply extended checks to objects 260 260 + // If we survived the primary checks, apply extended checks to objects 261 261 // with extended policies. 262 262 $results = array(); 263 263 $extended = array();

+1 -1

src/applications/project/query/PhabricatorProjectColumnQuery.php

reviewed

··· 97 97 if ($proxy_phid !== null) { 98 98 $proxy = idx($proxies, $proxy_phid); 99 99 100 100 - // Only attach valid proxies, so we don't end up getting surprsied if 100 100 + // Only attach valid proxies, so we don't end up getting surprised if 101 101 // an install somehow gets junk into their database. 102 102 if (!($proxy instanceof PhabricatorColumnProxyInterface)) { 103 103 $proxy = null;

+1 -1

src/applications/project/remarkup/ProjectRemarkupRule.php

reviewed

··· 24 24 protected function getObjectIDPattern() { 25 25 // NOTE: The latter half of this rule matches monograms with internal 26 26 // periods, like `#domain.com`, but does not match monograms with terminal 27 27 - // periods, because they're probably just puncutation. 27 27 + // periods, because they're probably just punctuation. 28 28 29 29 // Broadly, this will not match every possible project monogram, and we 30 30 // accept some false negatives -- like `#dot.` -- in order to avoid a bunch

+1 -1

src/applications/releeph/differential/DifferentialReleephRequestFieldSpecification.php

reviewed

··· 5 5 * 6 6 * 1: To parse "Releeph: picks RQ<nn>" headers in commits created by 7 7 * arc-releeph so that RQs committed by arc-releeph have real 8 8 - * PhabricatorRepositoryCommits associated with them (instaed of just the SHA 8 8 + * PhabricatorRepositoryCommits associated with them (instead of just the SHA 9 9 * of the commit, as seen by the pusher). 10 10 * 11 11 * 2: If requestors want to commit directly to their release branch, they can

+1 -1

src/applications/releeph/field/selector/ReleephDefaultFieldSelector.php

reviewed

··· 7 7 * 8 8 * TODO: This is a giant hacky mess because I am dumb and moved forward on 9 9 * Releeph changes with partial information. Recover from this as gracefully 10 10 - * as possible. This obivously is an abomination. -epriestley 10 10 + * as possible. This obviously is an abomination. -epriestley 11 11 */ 12 12 public static function isFacebook() { 13 13 return class_exists('ReleephFacebookKarmaFieldSpecification');

+1 -1

src/applications/repository/daemon/PhabricatorMercurialGraphStream.php

reviewed

··· 113 113 private function parseParents($parents, $target_rev) { 114 114 115 115 // The hg '{parents}' token is empty if there is one "natural" parent 116 116 - // (predecessor local commit ID). Othwerwise, it may have one or two 116 116 + // (predecessor local commit ID). Otherwise, it may have one or two 117 117 // parents. The string looks like this: 118 118 // 119 119 // 151:1f6c61a60586 154:1d5f799ebe1e

+2 -2

src/applications/repository/data/PhabricatorRepositoryURINormalizer.php

reviewed

··· 27 27 * // URIs are very unlikely to be the same repository. 28 28 * } 29 29 * 30 30 - * Because a repository can be hosted at arbitrarly many arbitrary URIs, there 30 30 + * Because a repository can be hosted at arbitrarily many arbitrary URIs, there 31 31 * is no way to completely prevent false negatives by only examining URIs 32 32 * (that is, repositories with totally different URIs could really be the same). 33 33 - * However, normalization is relatively agressive and false negatives should 33 33 + * However, normalization is relatively aggressive and false negatives should 34 34 * be rare: if normalization says two URIs are different repositories, they 35 35 * probably are. 36 36 *

+1 -1

src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php

reviewed

··· 703 703 // new repository for the first time is less important than any other 704 704 // daemon task. 705 705 706 706 - // If the repostitory has finished importing and we're just catching up 706 706 + // If the repository has finished importing and we're just catching up 707 707 // on recent commits, we schedule discovery at COMMIT priority, which is 708 708 // slightly below the default priority. 709 709

+1 -1

src/applications/repository/management/PhabricatorRepositoryManagementThawWorkflow.php

reviewed

··· 90 90 $risk_message); 91 91 92 92 $is_force = $args->getArg('force'); 93 93 - $prompt = pht('Accept the possibilty of permanent data loss?'); 93 93 + $prompt = pht('Accept the possibility of permanent data loss?'); 94 94 if (!$is_force && !phutil_console_confirm($prompt)) { 95 95 throw new PhutilArgumentUsageException( 96 96 pht('User aborted the workflow.'));

+2 -2

src/applications/repository/storage/PhabricatorRepository.php

reviewed

··· 1875 1875 1876 1876 1877 1877 /** 1878 1878 - * Retrieve the sevice URI for the device hosting this repository. 1878 1878 + * Retrieve the service URI for the device hosting this repository. 1879 1879 * 1880 1880 * See @{method:newConduitClient} for a general discussion of interacting 1881 1881 * with repository services. This method provides lower-level resolution of ··· 2129 2129 if ($this->isGit()) { 2130 2130 // $_ENV does not populate in CLI contexts if "E" is missing from 2131 2131 // "variables_order" in PHP config. Currently, we do not require this 2132 2132 - // to be configured. Since it may not be, explictitly bring expected Git 2132 2132 + // to be configured. Since it may not be, explicitly bring expected Git 2133 2133 // environmental variables into scope. This list is not exhaustive, but 2134 2134 // only lists variables with a known impact on commit hook behavior. 2135 2135

+1 -1

src/applications/repository/storage/PhabricatorRepositoryURI.php

reviewed

··· 362 362 return PhabricatorEnv::getEnvConfig('diffusion.ssh-port'); 363 363 } 364 364 365 365 - // If Phabricator is running on a nonstandard port, use that as the defualt 365 365 + // If Phabricator is running on a nonstandard port, use that as the default 366 366 // port for URIs with the same protocol. 367 367 368 368 $is_http = ($protocol == self::BUILTIN_PROTOCOL_HTTP);

+1 -1

src/applications/repository/storage/PhabricatorRepositoryWorkingCopyVersion.php

reviewed

··· 66 66 * may have committed and acknowledged a write on a node that lost the lock 67 67 * partway through the write and is no longer reachable. 68 68 * 69 69 - * In particular, if a node loses its connection to the datbase the global 69 69 + * In particular, if a node loses its connection to the database the global 70 70 * lock is released by default. This is a durable lock which stays locked 71 71 * by default. 72 72 */

+1 -1

src/applications/repository/worker/commitchangeparser/PhabricatorRepositoryMercurialCommitChangeParserWorker.php

reviewed

··· 216 216 $changes[$path]['changeType'] 217 217 = DifferentialChangeType::TYPE_COPY_AWAY; 218 218 } else if ($existing_type == DifferentialChangeType::TYPE_ADD) { 219 219 - // This change removes a diretory and replaces it with a file. Mark 219 219 + // This change removes a directory and replaces it with a file. Mark 220 220 // it as "change" instead of "add". 221 221 $changes[$path]['changeType'] = DifferentialChangeType::TYPE_CHANGE; 222 222 }

+1 -1

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

reviewed

··· 359 359 * ); 360 360 * 361 361 * Any unspecified fields (including custom fields and fields added 362 362 - * automatically by infrastruture) will be put in the middle. 362 362 + * automatically by infrastructure) will be put in the middle. 363 363 * 364 364 * @return list<string> Default ordering for field keys. 365 365 */

+1 -1

src/applications/search/management/PhabricatorSearchManagementWorkflow.php

reviewed

··· 5 5 6 6 protected function validateClusterSearchConfig() { 7 7 // Configuration is normally validated by setup self-checks on the web 8 8 - // workflow, but users may reasonsably run `bin/search` commands after 8 8 + // workflow, but users may reasonably run `bin/search` commands after 9 9 // making manual edits to "local.json". Re-verify configuration here before 10 10 // continuing. 11 11

+2 -2

src/applications/search/menuitem/PhabricatorMotivatorProfileMenuItem.php

reviewed

··· 80 80 private function getCatFacts() { 81 81 return array( 82 82 pht('Cats purr when they are happy, upset, or asleep.'), 83 83 - pht('The first cats evolved on the savanah about 8,000 years ago.'), 83 83 + pht('The first cats evolved on the savannah about 8,000 years ago.'), 84 84 pht( 85 85 'Cats have a tail, two feet, between one and three ears, and two '. 86 86 'other feet.'), ··· 111 111 pht( 112 112 'Not all cats can retract their claws, but most of them can.'), 113 113 pht( 114 114 - 'In the wild, cats and racoons sometimes hunt together in packs.'), 114 114 + 'In the wild, cats and raccoons sometimes hunt together in packs.'), 115 115 pht( 116 116 'The Spanish word for cat is "cato". The biggest cat is called '. 117 117 '"el cato".'),

+1 -1

src/applications/settings/panel/PhabricatorSettingsPanel.php

reviewed

··· 143 143 /** 144 144 * Return false to prevent this panel from being displayed or used. You can 145 145 * do, e.g., configuration checks here, to determine if the feature your 146 146 - * panel controls is unavailble in this install. By default, all panels are 146 146 + * panel controls is unavailable in this install. By default, all panels are 147 147 * enabled. 148 148 * 149 149 * @return bool True if the panel should be shown.

+1 -1

src/applications/settings/query/PhabricatorUserPreferencesQuery.php

reviewed

··· 49 49 * If no settings exist for a user, a new empty settings object with 50 50 * appropriate defaults is returned. 51 51 * 52 52 - * @param bool True to generat synthetic preferences for missing users. 52 52 + * @param bool True to generate synthetic preferences for missing users. 53 53 */ 54 54 public function needSyntheticPreferences($synthetic) { 55 55 $this->synthetic = $synthetic;

+1 -1

src/applications/settings/setting/PhabricatorTimezoneSetting.php

reviewed

··· 46 46 47 47 throw new Exception( 48 48 pht( 49 49 - 'Timezone "%s" is not a valid timezone identiifer.', 49 49 + 'Timezone "%s" is not a valid timezone identifier.', 50 50 $value)); 51 51 } 52 52

+1 -1

src/applications/subscriptions/controller/PhabricatorSubscriptionsEditController.php

reviewed

··· 83 83 } else { 84 84 85 85 // TODO: Eventually, get rid of this once everything implements 86 86 - // PhabriatorApplicationTransactionInterface. 86 86 + // PhabricatorApplicationTransactionInterface. 87 87 88 88 $editor = id(new PhabricatorSubscriptionsEditor()) 89 89 ->setActor($viewer)

+2 -2

src/applications/transactions/editengine/PhabricatorEditEngine.php

reviewed

··· 763 763 * Load an object given a configured query. 764 764 * 765 765 * @param PhabricatorPolicyAwareQuery Configured query. 766 766 - * @param list<const> List of required capabilitiy constants, or omit for 766 766 + * @param list<const> List of required capability constants, or omit for 767 767 * defaults. 768 768 * @return object|null Object, or null if no such object exists. 769 769 * @task load ··· 1382 1382 * and that field is visible and editable for the user. 1383 1383 * 1384 1384 * For example, you can use it to test if a user is able to reassign tasks 1385 1385 - * or not, prior to rendering dedicated UI for task reassingment. 1385 1385 + * or not, prior to rendering dedicated UI for task reassignment. 1386 1386 * 1387 1387 * Note that this method does NOT test if the user can actually edit the 1388 1388 * current object, just if they have access to the related field.

+1 -1

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

reviewed

··· 3701 3701 3702 3702 // If a later project in the list is an ancestor of this one, it will 3703 3703 // have added itself to the map. If any ancestor of this project points 3704 3704 - // at itself in the map, this project should be dicarded in favor of 3704 3704 + // at itself in the map, this project should be discarded in favor of 3705 3705 // that later ancestor. 3706 3706 foreach ($project->getAncestorProjects() as $ancestor) { 3707 3707 $ancestor_phid = $ancestor->getPHID();

+1 -1

src/applications/typeahead/datasource/PhabricatorTypeaheadDatasource.php

reviewed

··· 451 451 public static function isFunctionToken($token) { 452 452 // We're looking for a "(" so that a string like "members(q" is identified 453 453 // and parsed as a function call. This allows us to start generating 454 454 - // results immeidately, before the user fully types out "members(quack)". 454 454 + // results immediately, before the user fully types out "members(quack)". 455 455 return (strpos($token, '(') !== false); 456 456 } 457 457

+1 -1

src/applications/uiexample/examples/PhabricatorStatusUIExample.php

reviewed

··· 33 33 $view->addItem( 34 34 id(new PHUIStatusItemView()) 35 35 ->setIcon(PHUIStatusItemView::ICON_WARNING, 'dark', pht('Caution')) 36 36 - ->setTarget(pht('Pomegranite')) 36 36 + ->setTarget(pht('Pomegranate')) 37 37 ->setNote(pht('Lots of seeds. Watch out.'))); 38 38 39 39 $view->addItem(

+3 -3

src/docs/contributor/cla.diviner

reviewed

··· 87 87 do not contribute to Phabricator. 88 88 89 89 **Limitation of Liability**: The second benefit the CLA provides is that it 90 90 - makes the terms of your contribition explicitly clear upfront, and it puts us 90 90 + makes the terms of your contribution explicitly clear upfront, and it puts us 91 91 in a much stronger legal position if a contributor later claims there is 92 92 ambiguity about ownership of their work. We can point at the document they 93 93 signed as proof that they consented to our use and understood the terms of ··· 100 100 and the litigation has now been ongoing for more than a decade. 101 101 102 102 We want to avoid situations like this in the future by making the terms of 103 103 - contibution explicit upfront. 103 103 + contribution explicit upfront. 104 104 105 105 Generally, we believe the terms of the CLA are fair and reasonable for 106 106 contributors, and that the primary way contributors benefit from contributing ··· 158 158 159 159 If you are unsure, you should speak with your employer or a lawyer. If you 160 160 contribute code you do not own under the individual CLA, you are exposing 161 161 - yourself to liability. You may also be exposing us to liablity, but we'll have 161 161 + yourself to liability. You may also be exposing us to liability, but we'll have 162 162 the CLA on our side to show that we were unwilling pawns in your malicious 163 163 scheme to defraud your employer. 164 164

+1 -1

src/docs/contributor/describing_problems.diviner

reviewed

··· 140 140 141 141 Poor problem descriptions are a common issue in software development and 142 142 extensively documented elsewhere. Here are some additional resources describing 143 143 - how to describe problems and ask questions effectivey: 143 143 + how to describe problems and ask questions effectively: 144 144 145 145 - [[ http://www.catb.org/esr/faqs/smart-questions.html | How To Ask 146 146 Questions The Smart Way ]], by Eric S. Raymond

+1 -1

src/docs/contributor/internationalization.diviner

reviewed

··· 198 198 meaning, but no native English speaker would speak or write like this. 199 199 200 200 However, some languages have different subject-verb order rules or 201 201 - colloquisalisms, and a word order which transliterates like this may sound more 201 201 + colloquialisms, and a word order which transliterates like this may sound more 202 202 natural to a native speaker. By translating fragments instead of complete 203 203 sentences, you lock translators into English word order. 204 204

+2 -2

src/docs/contributor/reproduction_steps.diviner

reviewed

··· 112 112 113 113 If you can't follow your steps because they depend on information which is not 114 114 available on a clean instance (for example, a certain config setting), rewrite 115 115 - them to include instrutions to create that information (for example, adjusting 115 115 + them to include instructions to create that information (for example, adjusting 116 116 the config to the problematic value). 117 117 118 118 If you follow your instructions but the issue does not reproduce, the issue ··· 191 191 - Files like `A`, which have uppercase letters, do not work. 192 192 193 193 With a simpler reproduction scenario, you can simplify your steps to be more 194 194 - tailored and mimimal. This will help us pointpoint the issue more quickly and 194 194 + tailored and minimal. This will help us pinpoint the issue more quickly and 195 195 be more certain that we've understood and resolved it. 196 196 197 197 It is more important that steps be complete than that they be simple, and it's

+1 -1

src/docs/user/cluster/cluster.diviner

reviewed

··· 225 225 Configuring multiple notification hosts is simple and has no pre-requisites. 226 226 227 227 With multiple notification hosts, you can survive the loss of any subset of 228 228 - hosts as long as at least one host remains alive. Service may be breifly 228 228 + hosts as long as at least one host remains alive. Service may be briefly 229 229 disrupted directly after the incident which destroys the other hosts. 230 230 231 231 Notifications are noncritical, so this normally has little practical impact

+1 -1

src/docs/user/cluster/cluster_databases.diviner

reviewed

··· 31 31 32 32 Phabricator applications //can// be partitioned across multiple database 33 33 masters. This does not provide redundancy and generally does not increase 34 34 - resiliance or resistance to data loss, but can help you scale and operate 34 34 + resilience or resistance to data loss, but can help you scale and operate 35 35 Phabricator. For details, see 36 36 @{article:Cluster: Partitioning and Advanced Configuration}. 37 37

+1 -1

src/docs/user/cluster/cluster_devices.diviner

reviewed

··· 212 212 For example, you might run this command on `repo001` when using a shared key: 213 213 214 214 ``` 215 215 - $ ./bin/almanac register 215 215 + $ ./bin/almanac register \ 216 216 --device keywarden.mycompany.net \ 217 217 --private-key /path/to/private-key \ 218 218 --identify-as repo001.mycompany.net

+3 -3

src/docs/user/cluster/cluster_partitioning.diviner

reviewed

··· 21 21 it. Phabricator will normally run comfortably with a single database master 22 22 even for large organizations. 23 23 24 24 - Partitioning generally does not do much to increase resiliance or make it 24 24 + Partitioning generally does not do much to increase resilience or make it 25 25 easier to recover from disasters, and is primarily a mechanism for scaling and 26 26 operational convenience. 27 27 ··· 212 212 213 213 `persistent` //(bool)// Enables persistent connections. Defaults to off. 214 214 215 215 - With persitent connections enabled, Phabricator will keep a pool of database 215 215 + With persistent connections enabled, Phabricator will keep a pool of database 216 216 connections open between web requests and reuse them when serving subsequent 217 217 requests. 218 218 219 219 The primary benefit of using persistent connections is that it will greatly 220 220 reduce pressure on how quickly outbound TCP ports are opened and closed. After 221 221 a TCP port closes, it normally can't be used again for about 60 seconds, so 222 222 - rapidly cycling ports can cause resource exuastion. If you're seeing failures 222 222 + rapidly cycling ports can cause resource exhaustion. If you're seeing failures 223 223 because requests are unable to bind to an outbound port, enabling this option 224 224 is likely to fix the issue. This option may also slightly increase performance. 225 225

+1 -1

src/docs/user/cluster/cluster_repositories.diviner

reviewed

··· 440 440 441 441 When Phabricator can not tell which device in a cluster is a leader, it freezes 442 442 the cluster because it is possible that some devices have less data and others 443 443 - have more, and if it choses a leader arbitrarily it may destroy some data 443 443 + have more, and if it chooses a leader arbitrarily it may destroy some data 444 444 which you would prefer to retain. 445 445 446 446 To resolve this, you need to tell Phabricator which device has the most

+2 -2

src/docs/user/cluster/cluster_search.diviner

reviewed

··· 100 100 Service Type: Elasticsearch 101 101 ====================== 102 102 103 103 - The `elasticsearch` sevice type supports these options: 103 103 + The `elasticsearch` service type supports these options: 104 104 105 105 | Key | Description | 106 106 |---|---| 107 107 | `protocol` | Either `"http"` (default) or `"https"`. 108 108 | `port` | Elasticsearch TCP port. 109 109 | `version` | Elasticsearch version, either `2` or `5` (default). 110 110 - | `path` | Path for the index. Defaults to `/phabriator`. Advanced. 110 110 + | `path` | Path for the index. Defaults to `/phabricator`. Advanced. 111 111 112 112 A typical `elasticsearch` service configuration looks like this: 113 113

+2 -2

src/docs/user/configuration/configuration_guide.diviner

reviewed

··· 116 116 117 117 = Webserver: Configuring lighttpd = 118 118 119 119 - NOTE: Follow these instructions to use lighttpd. To use Apache or niginx, scroll 119 119 + NOTE: Follow these instructions to use lighttpd. To use Apache or nginx, scroll 120 120 up to their sections. 121 121 122 122 For lighttpd, add a section like this to your lighttpd.conf: ··· 138 138 139 139 Finally, you should run the following commands to enable php support: 140 140 141 141 - $ sudo apt-get install php5-cgi # for ubuntu; other distros should be similar 141 141 + $ sudo apt-get install php5-cgi # for Ubuntu; other distros should be similar 142 142 $ sudo lighty-enable-mod fastcgi-php 143 143 144 144 Restart lighttpd after making your edits, then continue below.

+1 -1

src/docs/user/configuration/configuring_backups.diviner

reviewed

··· 64 64 repository. To back them up, copy them elsewhere. 65 65 66 66 You can also just clone them and keep the clones up to date, or use 67 67 - {nav Add Mirror} to have the mirror somewhere automatically. 67 67 + {nav Add Mirror} to have them mirror somewhere automatically. 68 68 69 69 70 70 Restore: Hosted Repositories

+2 -2

src/docs/user/configuration/configuring_encryption.diviner

reviewed

··· 80 80 ================ 81 81 82 82 The `raw` storage format is automatically selected for all newly uploaded 83 83 - file data if no key is makred as the `default` key in the keyring. This is 83 83 + file data if no key is marked as the `default` key in the keyring. This is 84 84 the behavior of Phabricator if you haven't configured anything. 85 85 86 86 This format stores raw data without modification. ··· 137 137 phabricator/ $ ./bin/files encode --as <format> F123 [--key <key>] 138 138 ``` 139 139 140 140 - This will change the storage format of the sepcified file. 140 140 + This will change the storage format of the specified file. 141 141 142 142 143 143 Verifying Storage Formats

+1 -1

src/docs/user/configuration/managing_garbage.diviner

reviewed

··· 21 21 22 22 You can reconfigure the data retention policies for most collectors. 23 23 24 24 - The default retention polcies should be suitable for most installs. However, 24 24 + The default retention policies should be suitable for most installs. However, 25 25 you might want to **decrease** retention to reduce the amount of disk space 26 26 used by some high-volume log that you don't find particularly interesting, or 27 27 to adhere to an organizational data retention policy.

+1 -1

src/docs/user/field/conduit_changes.diviner

reviewed

··· 11 11 methods and may update older methods. 12 12 13 13 This document discusses API stability and how to minimize disruption when 14 14 - transitionig between API versions. 14 14 + transitioning between API versions. 15 15 16 16 17 17 Method Statuses

+1 -1

src/docs/user/field/darkconsole.diviner

reviewed

··· 131 131 - Unbatched queries which should be batched (see 132 132 @{article:Performance: N+1 Query Problem}). 133 133 - Opportunities to improve performance with caching. 134 134 - - General goofiness in how service calls are woking. 134 134 + - General goofiness in how service calls are working. 135 135 136 136 If the services tab looks fine, and particularly if a page is slow but the 137 137 "All Services" cost is small, that may indicate a problem in PHP. The best

+2 -2

src/docs/user/field/performance.diviner

reviewed

··· 34 34 to download over the network, and your browser will probably not be able to 35 35 render it especially quickly. 36 36 37 37 - We may be able to improve perfomance in some cases, but Phabricator is not 37 37 + We may be able to improve performance in some cases, but Phabricator is not 38 38 magic and can not wish away real complexity. The best solution to these problems 39 39 is usually to find another way to solve your problem: for example, maybe the 40 40 100MB document can be split into several smaller documents. ··· 51 51 inherent complexity, like these: 52 52 53 53 - {icon times, color=red} A 100MB wiki page takes a long time to render. 54 54 - - {icon times, color=red} A turing-complete simulation of Conway's Game of 54 54 + - {icon times, color=red} A Turing-complete simulation of Conway's Game of 55 55 Life implemented in 958,000 Herald rules executes slowly. 56 56 - {icon times, color=red} Uploading an 8GB file takes several minutes. 57 57

+4 -4

src/docs/user/field/repository_imports.diviner

reviewed

··· 127 127 daemons were killed halfway through the work. 128 128 129 129 These commits will retry eventually and usually succeed, but some of the retry 130 130 - time limits are very conserative (up to 24 hours) and you might not want to 130 130 + time limits are very conservative (up to 24 hours) and you might not want to 131 131 wait that long. 132 132 133 133 In the Daemon console, temporarily failures usually look like tasks in the ··· 137 137 138 138 In the daemon log, these temporary failures might have created log entries, but 139 139 might also not have. For example, if the failure was rooted in a network issue 140 140 - that probably will create a log entry, but if the faiulre was rooted in the 140 140 + that probably will create a log entry, but if the failure was rooted in the 141 141 daemons being abruptly killed that may not create a log entry. 142 142 143 143 You can follow the instructions from "Handling Permanent Failures" above to ··· 167 167 ============== 168 168 169 169 In rare cases, the actual tasks may be lost from the task queue. Usually, they 170 170 - have been stolen by gremlins or spritied away by ghosts, or someone may have 170 170 + have been stolen by gremlins or spirited away by ghosts, or someone may have 171 171 been too ambitious with running manual SQL commands and deleted a bunch of 172 172 extra things they shouldn't have. 173 173 ··· 226 226 ============ 227 227 228 228 Broadly, `bin/repository` contains several useful debugging commands which 229 229 - let you figure out where failures are occuring. You can add the `--trace` flag 229 229 + let you figure out where failures are occurring. You can add the `--trace` flag 230 230 to any command to get more details about what it is doing. For any command, 231 231 you can use `help` to learn more about what it does and which flag it takes: 232 232

+1 -1

src/docs/user/field/xhprof.diviner

reviewed

··· 88 88 to go down further to identify and understand it. 89 89 90 90 Conversely, if the "Wall Time (Exclusive)" column is large, or the children 91 91 - of a call are all cheap, there's probably something expesive happening in the 91 91 + of a call are all cheap, there's probably something expensive happening in the 92 92 call itself. 93 93 94 94 The "Count" column can also sometimes tip you off that something is amiss, if

+1 -1

src/docs/user/userguide/almanac.diviner

reviewed

··· 122 122 **Bindings**: Bindings are connections between services and interfaces. They 123 123 tell callers which devices host a named service. 124 124 125 125 - **Networks**: Networks allow Almanac to distingiush between addresses on 125 125 + **Networks**: Networks allow Almanac to distinguish between addresses on 126 126 different networks, like VPNs vs the public internet. 127 127 128 128 If you have hosts in different VPNs or on private networks, you might have

+1 -1

src/docs/user/userguide/arcanist.diviner

reviewed

··· 3 3 4 4 Guide to Arcanist, a command-line interface to Phabricator. 5 5 6 6 - Arcanists provides command-line access to many Phabricator tools (like 6 6 + Arcanist provides command-line access to many Phabricator tools (like 7 7 Differential, Files, and Paste), integrates with static analysis ("lint") and 8 8 unit tests, and manages common workflows like getting changes into Differential 9 9 for review.

+1 -1

src/docs/user/userguide/arcanist_lint.diviner

reviewed

··· 169 169 review. In that context, the severities behave like this: 170 170 171 171 - `error` When a file contains lint errors, they are always reported. These 172 172 - are intended to be severe problems, like a syntax error. Unresoved lint 172 172 + are intended to be severe problems, like a syntax error. Unresolved lint 173 173 errors require you to confirm that you want to continue. 174 174 - `warning` When a file contains warnings, they are reported by default only 175 175 if they appear on lines that you have changed. They are intended to be

+1 -1

src/docs/user/userguide/calendar_exports.diviner

reviewed

··· 61 61 - Example: All events tagged `#meetup`. 62 62 - Select the {nav Use Results... > Export Query as .ics} action to turn 63 63 the query into an export. 64 64 - - Name the export with a descritive name. 64 64 + - Name the export with a descriptive name. 65 65 - Select a policy mode for the export (see below for discussion). 66 66 - Click {nav Create New Export} to finish the process. 67 67

+1 -1

src/docs/user/userguide/calendar_imports.diviner

reviewed

··· 10 10 @{article:User Guide: Prototype Applications}. 11 11 12 12 You can import events into Phabricator to other calendar applications or from 13 13 - `.ics` files. This document will guide you through how to importe event data 13 13 + `.ics` files. This document will guide you through how to import event data 14 14 into Phabricator. 15 15 16 16 When you import events from another application, they can not be edited in

+1 -1

src/docs/user/userguide/conduit_edit.diviner

reviewed

··· 37 37 38 38 To edit objects, pass a list of transactions and use `objectIdentifier` to 39 39 specify which object to apply them to. You can normally pass an ID or PHID, 40 40 - and many applicaitons also allow you to pass a monogram (for example, you can 40 40 + and many applications also allow you to pass a monogram (for example, you can 41 41 edit a task by passing `T123`). 42 42 43 43

+1 -1

src/docs/user/userguide/diffusion_api.diviner

reviewed

··· 147 147 ======================= 148 148 149 149 Now that any URIs have been configured, activate the repository with another 150 150 - call to `diffusion.repository.edit`. This time, modify the existing repostitory 150 150 + call to `diffusion.repository.edit`. This time, modify the existing repository 151 151 instead of creating a new one: 152 152 153 153 ```

+1 -1

src/docs/user/userguide/diffusion_hosting.diviner

reviewed

··· 151 151 152 152 This is just a template. In the real configuration file, you need to: 153 153 154 154 - - Replace `www-user`, `dameon-user` and `vcs-user` with the correct 154 154 + - Replace `www-user`, `daemon-user` and `vcs-user` with the correct 155 155 usernames for your system. 156 156 - List every binary that these users need access to, as described above. 157 157 - Make sure each binary path is the full path to the correct binary location

+5 -5

src/docs/user/userguide/diffusion_managing.diviner

reviewed

··· 121 121 scalable workflows rarely rewrite repository history and it's easy to make 122 122 mistakes which are expensive to correct if this protection is disabled. 123 123 124 124 - If you do occasionally need to rewite published history, you can treat this 124 124 + If you do occasionally need to rewrite published history, you can treat this 125 125 option like a safety: disable it, perform required rewrites, then enable it 126 126 again. 127 127 ··· 148 148 - the repository will be hidden from view in default queries. 149 149 150 150 When repositories are created for the first time, they are deactivated. This 151 151 - gives you an opportuinty to customize settings, like adjusting policies or 151 151 + gives you an opportunity to customize settings, like adjusting policies or 152 152 configuring a URI to observe. You must activate a repository before it will 153 153 start working normally. 154 154 ··· 177 177 manage repository access policies. 178 178 179 179 You can configure granular access policies for each repository to control who 180 180 - can view, clone, administate, and push to the repository. 180 180 + can view, clone, administrate, and push to the repository. 181 181 182 182 183 183 Policies: View ··· 302 302 The **Actions** panel can configure notifications and publishing behavior. 303 303 304 304 Normally, Phabricator publishes notifications when it discovers new commits. 305 305 - You can disable publishing for a repository by turning off **Publish/Noitfy**. 305 305 + You can disable publishing for a repository by turning off **Publish/Notify**. 306 306 This will disable notifications, feed, and Herald (including audits and build 307 307 plans) for this repository. 308 308 ··· 347 347 ================== 348 348 349 349 Diffusion uses repository identifiers and information about the commit itself 350 350 - to generate globally unique identifers for each commit, like `rE12345`. 350 350 + to generate globally unique identifiers for each commit, like `rE12345`. 351 351 352 352 Each commit may have several identifiers: 353 353

+2 -2

src/docs/user/userguide/diffusion_uris.diviner

reviewed

··· 20 20 repository. This will create a read-only copy of the repository in Phabricator. 21 21 22 22 **Mirror Repositories**: Phabricator can publish any repository to mirrors, 23 23 - overwiting them with an exact copy of the repository that stays up to date as 23 23 + overwriting them with an exact copy of the repository that stays up to date as 24 24 the source changes. This works with both local repositories that Phabricator is 25 25 hosting and remote repositories that Phabricator is observing. 26 26 ··· 293 293 human-readable URI defaults to //Always// and the others default to //Never//. 294 294 295 295 **Always**: This URI will be shown to users as a clone/checkout URI. You can 296 296 - add URIs in this mode to cutomize exactly what users are shown. 296 296 + add URIs in this mode to customize exactly what users are shown. 297 297 298 298 **Never**: This URI will not be shown to users. You can hide less-preferred 299 299 URIs to guide users to the URIs they should be using to interact with the

+1 -1

src/docs/user/userguide/drydock.diviner

reviewed

··· 151 151 work. 152 152 153 153 Drydock is intended to solve resource management problems at very large scales 154 154 - and minimzes blocking operations, locks, and artificial sequencing. Drydock is 154 154 + and minimizes blocking operations, locks, and artificial sequencing. Drydock is 155 155 designed to fully utilize an almost arbitrarily large pool of resources and 156 156 improve performance roughly linearly with available hardware. 157 157

+1 -1

src/docs/user/userguide/drydock_blueprints.diviner

reviewed

··· 47 47 48 48 This also broadly prevents Drydock from surprising you by coming up with a 49 49 valid but unintended solution to an allocation problem which runs some 50 50 - operation on resources that are techincally suitable but not desirable. For 50 50 + operation on resources that are technically suitable but not desirable. For 51 51 example, you may not want your Android builds running on your iPhone build 52 52 tier, even if there's no technical reason they can't. 53 53

+1 -1

src/docs/user/userguide/drydock_security.diviner

reviewed

··· 141 141 Even if the host is not privileged, many Drydock processes have some level of 142 142 privilege (enabling them to clone repositories, or report test results back to 143 143 Phabricator). Be aware that tests can hijack credentials they are run with, 144 144 - and potentialy hijack credentials given to other processes on the same hosts. 144 144 + and potentially hijack credentials given to other processes on the same hosts. 145 145 You should use credentials with a minimum set of privileges and assume all 146 146 processes on a host have the highest level of access that any process on the 147 147 host has.

+1 -1

src/docs/user/userguide/forms.diviner

reviewed

··· 34 34 comment form if you're working in an application which supports comments. This 35 35 can streamline the edit workflow for less experienced users. 36 36 37 37 - Anyone can use prefiling, but you must have permission to configure an 37 37 + Anyone can use prefilling, but you must have permission to configure an 38 38 application in order to modify the application's forms. By default, only 39 39 administrators can configure applications. 40 40

+1 -1

src/docs/user/userguide/herald.diviner

reviewed

··· 126 126 For example, if you want to match revisions which add or remove calls to a 127 127 "muffinize" function, //but only in JS files//, you can set the value to 128 128 `["/\\.js$/", "/muffinize/"]` or similar. This condition is satisfied only 129 129 - when the filename matches the first expression and the conent matches the 129 129 + when the filename matches the first expression and the content matches the 130 130 second expression. 131 131 132 132 **Another Herald rule**: you can create Herald rules which depend on other

+1 -1

src/docs/user/userguide/jump.diviner

reviewed

··· 1 1 @title Search User Guide: Shortcuts 2 2 @group userguide 3 3 4 4 - Command reference for global search shorcuts. 4 4 + Command reference for global search shortcuts. 5 5 6 6 Overview 7 7 ========

+1 -1

src/docs/user/userguide/owners.diviner

reviewed

··· 24 24 25 25 Any files in those directories are considered to be part of the package, and 26 26 you can now conveniently refer to them (for example, in a Herald rule) by 27 27 - refering to the package instead of copy/pasting a huge regular expression 27 27 + referring to the package instead of copy/pasting a huge regular expression 28 28 into a bunch of places. 29 29 30 30 If new source files are later added, or the scope of the package otherwise

+1 -1

src/docs/user/userguide/projects.diviner

reviewed

··· 14 14 15 15 For example, you can create projects to provide: 16 16 17 17 - - **Organization**: Create a project to represent a product or initative, 17 17 + - **Organization**: Create a project to represent a product or initiative, 18 18 then use it to organize related work. 19 19 - **Groups**: Create a project to represent a group of people (like a team), 20 20 then add members of the group as project members.

+1 -1

src/docs/user/userguide/remarkup.diviner

reviewed

··· 366 366 367 367 T123#412 # Link to comment id #412 of task T123 368 368 369 369 - See the Phabricator configuraton setting `remarkup.ignored-object-names` to 369 369 + See the Phabricator configuration setting `remarkup.ignored-object-names` to 370 370 modify this behavior. 371 371 372 372 = Embedding Objects

+1 -1

src/docs/user/userguide/search.diviner

reviewed

··· 87 87 88 88 You can share queries with other users by sending them the URL. This will run 89 89 the same query for them with all the parameters you've set (they may see 90 90 - different results than you do, because they may not have the same permisions). 90 90 + different results than you do, because they may not have the same permissions). 91 91 92 92 93 93 Typeaheads

+1 -1

src/docs/user/userguide/spaces.diviner

reviewed

··· 70 70 Space Policies 71 71 ============== 72 72 73 73 - Briefly, spacess affect policies like this: 73 73 + Briefly, spaces affect policies like this: 74 74 75 75 - Spaces apply their view policy to all objects inside the space. 76 76 - Space policies are absolute, and stronger than all other policies. A

+1 -1

src/docs/user/userguide/users.diviner

reviewed

··· 73 73 is created. 74 74 75 75 Some options can be configured for mailing lists by browsing to the list user's 76 76 - profile and clicking {nav Edit Settings}. You can change the addresss for a 76 76 + profile and clicking {nav Edit Settings}. You can change the address for a 77 77 list by editing "Email Addresses" here, choose the language and format for 78 78 email the list receives, and customize which actions the list is notified about. 79 79

+1 -1

src/infrastructure/customfield/field/PhabricatorCustomFieldList.php

reviewed

··· 160 160 if ($value !== null) { 161 161 switch ($field->getStyleForPropertyView()) { 162 162 case 'header': 163 163 - // We want to hide headers if the fields the're assciated with 163 163 + // We want to hide headers if the fields they're associated with 164 164 // don't actually produce any visible properties. For example, in a 165 165 // list like this: 166 166 //

+2 -2

src/infrastructure/daemon/workers/query/PhabricatorWorkerTriggerQuery.php

reviewed

··· 5 5 6 6 // NOTE: This is a PolicyAware query so it can work with other infrastructure 7 7 // like handles; triggers themselves are low-level and do not have 8 8 - // meaninguful policies. 8 8 + // meaningful policies. 9 9 10 10 const ORDER_ID = 'id'; 11 11 const ORDER_EXECUTION = 'execution'; ··· 69 69 70 70 protected function nextPage(array $page) { 71 71 // NOTE: We don't implement paging because we don't currently ever need 72 72 - // it and paging ORDER_EXCUTION is a hassle. 72 72 + // it and paging ORDER_EXECUTION is a hassle. 73 73 throw new PhutilMethodNotImplementedException(); 74 74 } 75 75

+1 -1

src/infrastructure/diff/view/PHUIDiffGraphView.php

reviewed

··· 160 160 161 161 $terminated[$ii] = true; 162 162 163 163 - // If this thread is joinining some other node here, we don't want 163 163 + // If this thread is joining some other node here, we don't want 164 164 // to terminate it. 165 165 if (isset($graph[$key + 1])) { 166 166 $joins = $graph[$key + 1]['join'];

+1 -1

src/infrastructure/diff/view/PHUIDiffInlineCommentTableScaffold.php

reviewed

··· 4 4 * Wraps an inline comment row scaffold in a table. 5 5 * 6 6 * This scaffold is used to ship inlines over the wire to the client, so they 7 7 - * arrive in a form that's easy to mainipulate (a valid table node). 7 7 + * arrive in a form that's easy to manipulate (a valid table node). 8 8 */ 9 9 final class PHUIDiffInlineCommentTableScaffold extends AphrontView { 10 10

+1 -1

src/infrastructure/env/PhabricatorEnv.php

reviewed

··· 670 670 * Detect if a URI identifies some valid linkable remote resource. 671 671 * 672 672 * @param string URI to test. 673 673 - * @return bool True if a URI idenfies a remote resource with an allowed 673 673 + * @return bool True if a URI identifies a remote resource with an allowed 674 674 * protocol. 675 675 * @task uri 676 676 */

+3 -3

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php

reviewed

··· 730 730 '%s added %s reverting commit(s) for %s: %s.' => array( 731 731 array( 732 732 '%s added a reverting commit for %3$s: %4$s.', 733 733 - '%s added reverting commitsi for %3$s: %4$s.', 733 733 + '%s added reverting commits for %3$s: %4$s.', 734 734 ), 735 735 ), 736 736 ··· 1564 1564 '%s uninvited %s attendee(s): %s.' => 1565 1565 '%s uninvited: %3$s.', 1566 1566 1567 1567 - '%s invited %s attendee(s): %s; uninvinted %s attendee(s): %s.' => 1567 1567 + '%s invited %s attendee(s): %s; uninvited %s attendee(s): %s.' => 1568 1568 '%s invited: %3$s; uninvited: %5$s.', 1569 1569 1570 1570 '%s invited %s attendee(s) to %s: %s.' => ··· 1573 1573 '%s uninvited %s attendee(s) to %s: %s.' => 1574 1574 '%s removed invites for %3$s: %4$s.', 1575 1575 1576 1576 - '%s updated the invite list for %s, invited %s: %s; uninvinted %s: %s.' => 1576 1576 + '%s updated the invite list for %s, invited %s: %s; uninvited %s: %s.' => 1577 1577 '%s updated the invite list for %s, invited: %4$s; uninvited: %6$s.', 1578 1578 1579 1579 'Restart %s build(s)?' => array(

+2 -2

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

reviewed

··· 175 175 * So, generally, internal paging must bypass policy controls. 176 176 * 177 177 * This method returns the appropriate viewer, based on the context in which 178 178 - * the paging is occuring. 178 178 + * the paging is occurring. 179 179 * 180 180 * @return PhabricatorUser Viewer for executing paging queries. 181 181 */ ··· 536 536 * 537 537 * @param AphrontDatabaseConnection Connection query will execute on. 538 538 * @param list<map> Column description dictionaries. 539 539 - * @param map Additional constuction options. 539 539 + * @param map Additional construction options. 540 540 * @return string Query clause. 541 541 * @task paging 542 542 */

+1 -1

src/infrastructure/storage/lisk/LiskDAO.php

reviewed

··· 1121 1121 $this->willSaveObject(); 1122 1122 $data = $this->getAllLiskPropertyValues(); 1123 1123 1124 1124 - // Remove colums flagged as nonmutable from the update statement. 1124 1124 + // Remove columns flagged as nonmutable from the update statement. 1125 1125 $no_mutate = $this->getConfigOption(self::CONFIG_NO_MUTATE); 1126 1126 if ($no_mutate) { 1127 1127 foreach ($no_mutate as $column) {

+1 -1

src/infrastructure/storage/lisk/__tests__/LiskFixtureTestCase.php

reviewed

··· 98 98 $obj = new HarbormasterObject(); 99 99 $conn_w = $obj->establishConnection('w'); 100 100 101 101 - // Test that the counter bascially behaves as expected. 101 101 + // Test that the counter basically behaves as expected. 102 102 $this->assertEqual(1, LiskDAO::loadNextCounterValue($conn_w, 'a')); 103 103 $this->assertEqual(2, LiskDAO::loadNextCounterValue($conn_w, 'a')); 104 104 $this->assertEqual(3, LiskDAO::loadNextCounterValue($conn_w, 'a'));

+2 -2

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php

reviewed

··· 181 181 if (!$this->force && !$api->isCharacterSetAvailable('utf8mb4')) { 182 182 $message = pht( 183 183 "You have an old version of MySQL (older than 5.5) which does not ". 184 184 - "support the utf8mb4 character set. We strongly recomend upgrading to ". 185 185 - "5.5 or newer.\n\n". 184 184 + "support the utf8mb4 character set. We strongly recommend upgrading ". 185 185 + "to 5.5 or newer.\n\n". 186 186 "If you apply adjustments now and later update MySQL to 5.5 or newer, ". 187 187 "you'll need to apply adjustments again (and they will take a long ". 188 188 "time).\n\n".

+1 -1

src/infrastructure/util/PhabricatorHash.php

reviewed

··· 11 11 * weak. Callers should prefer @{method:digestWithNamedKey}. 12 12 * 13 13 * @param string Input string. 14 14 - * @return string 32-byte hexidecimal SHA1+HMAC hash. 14 14 + * @return string 32-byte hexadecimal SHA1+HMAC hash. 15 15 */ 16 16 public static function weakDigest($string, $key = null) { 17 17 if ($key === null) {

+4 -4

src/infrastructure/util/password/PhabricatorPasswordHasher.php

reviewed

··· 70 70 71 71 /** 72 72 * Return an indicator of this hasher's strength. When choosing to hash 73 73 - * new passwords, the strongest available hasher which is usuable for new 73 73 + * new passwords, the strongest available hasher which is usable for new 74 74 * passwords will be used, and the presence of a stronger hasher will 75 75 * prompt users to update their hashes. 76 76 * ··· 208 208 * Get all available password hashers. This may include hashers which can not 209 209 * actually be used (for example, a required extension is missing). 210 210 * 211 211 - * @return list<PhabicatorPasswordHasher> Hasher objects. 211 211 + * @return list<PhabricatorPasswordHasher> Hasher objects. 212 212 * @task hashing 213 213 */ 214 214 public static function getAllHashers() { ··· 243 243 * Get all usable password hashers. This may include hashers which are 244 244 * not desirable or advisable. 245 245 * 246 246 - * @return list<PhabicatorPasswordHasher> Hasher objects. 246 246 + * @return list<PhabricatorPasswordHasher> Hasher objects. 247 247 * @task hashing 248 248 */ 249 249 public static function getAllUsableHashers() { ··· 280 280 281 281 282 282 /** 283 283 - * Get the hashser for a given stored hash. 283 283 + * Get the hasher for a given stored hash. 284 284 * 285 285 * @return PhabricatorPasswordHasher Corresponding hasher. 286 286 * @task hashing

+1 -1

src/view/AphrontView.php

reviewed

··· 42 42 43 43 44 44 /** 45 45 - * Test if a viewer has been set on this elmeent. 45 45 + * Test if a viewer has been set on this element. 46 46 * 47 47 * @return bool True if a viewer is available. 48 48 */

+1 -1

src/view/page/PhabricatorStandardPageView.php

reviewed

··· 272 272 'doc_href' => $doc_href, 273 273 'message' => pht( 274 274 'Phabricator thinks you are using %s, but your '. 275 275 - 'client is conviced that it is using %s. This is a serious '. 275 275 + 'client is convinced that it is using %s. This is a serious '. 276 276 'misconfiguration with subtle, but significant, consequences.', 277 277 $server_protocol, $client_protocol), 278 278 ));

+1 -1

src/view/phui/PHUIHeaderView.php

reviewed

··· 166 166 $classes[] = 'phui-header-shell'; 167 167 168 168 if ($this->noBackground) { 169 169 - $classes[] = 'phui-header-no-backgound'; 169 169 + $classes[] = 'phui-header-no-background'; 170 170 } 171 171 172 172 if ($this->bleedHeader) {

+2 -2

webroot/rsrc/css/phui/phui-document.css

reviewed

··· 35 35 } 36 36 37 37 .phui-document-content 38 38 - .phui-header-shell.phui-header-no-backgound { 38 38 + .phui-header-shell.phui-header-no-background { 39 39 border-bottom: 1px solid {$thinblueborder}; 40 40 margin: 0 0 16px 0; 41 41 } 42 42 43 43 .phui-document-content 44 44 - .phui-header-shell.phui-header-no-backgound 44 44 + .phui-header-shell.phui-header-no-background 45 45 .phui-header-view { 46 46 padding: 8px 0 4px; 47 47 }

+1 -1

webroot/rsrc/css/phui/phui-header-view.css

reviewed

··· 34 34 vertical-align: middle; 35 35 } 36 36 37 37 - body .phui-header-shell.phui-header-no-backgound { 37 37 + body .phui-header-shell.phui-header-no-background { 38 38 background-color: transparent; 39 39 border: none; 40 40 }

+1 -1

webroot/rsrc/js/application/conpherence/behavior-menu.js

reviewed

··· 94 94 var _oldDevice = null; 95 95 96 96 /** 97 97 - * Initializes this behavior based on all the configuraton jonx and the 97 97 + * Initializes this behavior based on all the configuration jonx and the 98 98 * result of JX.Device.getDevice(); 99 99 */ 100 100 function init() {

+1 -1

webroot/rsrc/js/application/conpherence/behavior-participant-pane.js

reviewed

··· 69 69 // While the user is removing themselves, disable the notification 70 70 // update behavior. If we don't do this, the user can get an error 71 71 // when they remove themselves about permissions as the notification 72 72 - // code tries to load what jist happened. 72 72 + // code tries to load what just happened. 73 73 var loadedPhid = threadManager.getLoadedThreadPHID(); 74 74 threadManager.setLoadedThreadPHID(null); 75 75

+1 -1

webroot/rsrc/js/application/diffusion/DiffusionLocateFileSource.js

reviewed

··· 260 260 261 261 /** 262 262 * Score a matching string by finding the longest prefix of the search 263 263 - * query it contains continguously. 263 263 + * query it contains contiguously. 264 264 */ 265 265 scoreMatch: function(haystack, haypos, search) { 266 266 var pos = 0;

+1 -1

webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js

reviewed

··· 201 201 } 202 202 203 203 function render_image_header(image) { 204 204 - // Render image dimensions and visible size. If we have this infomation 204 204 + // Render image dimensions and visible size. If we have this information 205 205 // from the server we can display some of it immediately; otherwise, we need 206 206 // to wait for the image to load so we can read dimension information from 207 207 // it.

+2 -2

webroot/rsrc/js/core/Prefab.js

reviewed

··· 184 184 var self_hits = {}; 185 185 186 186 // We'll put matches where the user's input is a prefix of the name 187 187 - // above mathches where that isn't true. 187 187 + // above matches where that isn't true. 188 188 var prefix_hits = {}; 189 189 190 190 var tokens = this.tokenize(value); ··· 212 212 } 213 213 214 214 // If one result is open and one is closed, show the open result 215 215 - // first. The "!" tricks here are becaused closed values are display 215 215 + // first. The "!" tricks here are because closed values are display 216 216 // strings, so the value is either `null` or some truthy string. If 217 217 // we compare the values directly, we'll apply this rule to two 218 218 // objects which are both closed but for different reasons, like

+1 -1

webroot/rsrc/js/core/behavior-device.js

reviewed

··· 27 27 var self = JX.Device; 28 28 29 29 // Even when we emit a '<meta name="viewport" ... />' tag which tells 30 30 - // devices to fit the conent to the screen width, we'll sometimes measure 30 30 + // devices to fit the content to the screen width, we'll sometimes measure 31 31 // a viewport dimension which is larger than the available screen width, 32 32 // particularly if we check too early. 33 33

+1 -1

webroot/rsrc/js/phuix/PHUIXAutocomplete.js

reviewed

··· 543 543 544 544 // If the input is terminated by a space or another word-terminating 545 545 // punctuation mark, we're going to deactivate if the results can not 546 546 - // be refined by addding more words. 546 546 + // be refined by adding more words. 547 547 548 548 // The idea is that if you type "@alan ab", you're allowed to keep 549 549 // editing "ab" until you type a space, period, or other terminator,

+1 -1

webroot/rsrc/js/phuix/PHUIXDropdownMenu.js

reviewed

··· 124 124 } 125 125 126 126 // If this action was built dynamically with PHUIXActionView, don't 127 127 - // do anything by default. The caller is repsonsible for installing a 127 127 + // do anything by default. The caller is responsible for installing a 128 128 // handler if they want to react to clicks. 129 129 if (e.getNode('phuix-action-view')) { 130 130 return;