@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove "arcanist project" fields
Summary: Ref T7604. Remove these "arcanist project" fields from the `LiskDAO` classes, but leave the data intact (there are no more read/writes to this data).
Test Plan:
- Grepped for calls to these methods.
- Ran `./bin/storage adjust` to check for schema issues.
Reviewers: #blessed_reviewers, epriestley
Reviewed By: #blessed_reviewers, epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T7604
Differential Revision: https://secure.phabricator.com/D13012
-31
-20
src/applications/differential/storage/DifferentialDiff.php
-20
src/applications/differential/storage/DifferentialDiff.php
···
37
37
38
38
private $unsavedChangesets = array();
39
39
private $changesets = self::ATTACHABLE;
40
-
private $arcanistProject = self::ATTACHABLE;
41
40
private $revision = self::ATTACHABLE;
42
41
private $properties = array();
43
42
···
106
105
return id(new DifferentialChangeset())->loadAllWhere(
107
106
'diffID = %d',
108
107
$this->getID());
109
-
}
110
-
111
-
public function attachArcanistProject(
112
-
PhabricatorRepositoryArcanistProject $project = null) {
113
-
$this->arcanistProject = $project;
114
-
return $this;
115
-
}
116
-
117
-
public function getArcanistProject() {
118
-
return $this->assertAttached($this->arcanistProject);
119
-
}
120
-
121
-
public function getArcanistProjectName() {
122
-
$name = '';
123
-
if ($this->arcanistProject) {
124
-
$project = $this->getArcanistProject();
125
-
$name = $project->getName();
126
-
}
127
-
return $name;
128
108
}
129
109
130
110
public function save() {
-11
src/applications/releeph/storage/ReleephProject.php
-11
src/applications/releeph/storage/ReleephProject.php
···
23
23
protected $details = array();
24
24
25
25
private $repository = self::ATTACHABLE;
26
-
private $arcanistProject = self::ATTACHABLE;
27
26
28
27
protected function getConfiguration() {
29
28
return array(
···
65
64
66
65
public function setDetail($key, $value) {
67
66
$this->details[$key] = $value;
68
-
return $this;
69
-
}
70
-
71
-
public function getArcanistProject() {
72
-
return $this->assertAttached($this->arcanistProject);
73
-
}
74
-
75
-
public function attachArcanistProject(
76
-
PhabricatorRepositoryArcanistProject $arcanist_project = null) {
77
-
$this->arcanistProject = $arcanist_project;
78
67
return $this;
79
68
}
80
69