recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Limit damage caused by bad panels on dashboards you can manage

Summary:
Fixes T12203. If you tried to //manage// a dashboard which had a panel you can't see, we'd try to render bogus actions for it and fatal.

Instead, for the moment, survive. Presumably we'll ship a real fix for this in the next release or so, and tackle T10612 / T10145, which I think are closely related.

Test Plan: {F2570418}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12203

Differential Revision: https://secure.phabricator.com/D17311

epriestley 9c62a109 c8de5636

+4
+4
src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php
··· 255 255 PHUIHeaderView $header) { 256 256 $panel = $this->getPanel(); 257 257 258 + if (!$panel) { 259 + return $header; 260 + } 261 + 258 262 $dashboard_id = $this->getDashboardID(); 259 263 $edit_uri = id(new PhutilURI( 260 264 '/dashboard/panel/edit/'.$panel->getID().'/'));