recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Remove "Editable By" description fields in Passphrase, Phame, and Spaces

Summary:
Ref T13411. These three applications render an "Editable By: <policy>" field in their descriptions.

The pages that these appear on all have "Edit <thing>" actions which either tell you the policy or allow you to discover the policy, and this field is unusual (the vast majority of objects don't have it). I think it largely got copy/pasted or used as space-filler and doesn't offer much of value.

Remove it to simplify/standardize these pages and make changes to how this field works simpler to implement.

Test Plan: Viewed a Credential, Blog, and Space; no longer saw the "Editable By" field.

Maniphest Tasks: T13411

Differential Revision: https://secure.phabricator.com/D20802

epriestley 9c6969e8 a35d7c3c

-24
-8
src/applications/passphrase/controller/PassphraseCredentialViewController.php
··· 190 190 pht('Credential Type'), 191 191 $type->getCredentialTypeName()); 192 192 193 - $descriptions = PhabricatorPolicyQuery::renderPolicyDescriptions( 194 - $viewer, 195 - $credential); 196 - 197 - $properties->addProperty( 198 - pht('Editable By'), 199 - $descriptions[PhabricatorPolicyCapability::CAN_EDIT]); 200 - 201 193 if ($type->shouldRequireUsername()) { 202 194 $properties->addProperty( 203 195 pht('Username'),
-8
src/applications/phame/controller/blog/PhameBlogManageController.php
··· 143 143 ), 144 144 $feed_uri)); 145 145 146 - $descriptions = PhabricatorPolicyQuery::renderPolicyDescriptions( 147 - $viewer, 148 - $blog); 149 - 150 - $properties->addProperty( 151 - pht('Editable By'), 152 - $descriptions[PhabricatorPolicyCapability::CAN_EDIT]); 153 - 154 146 $engine = id(new PhabricatorMarkupEngine()) 155 147 ->setViewer($viewer) 156 148 ->addObject($blog, PhameBlog::MARKUP_FIELD_DESCRIPTION)
-8
src/applications/spaces/controller/PhabricatorSpacesViewController.php
··· 80 80 ? pht('Yes') 81 81 : pht('No')); 82 82 83 - $descriptions = PhabricatorPolicyQuery::renderPolicyDescriptions( 84 - $viewer, 85 - $space); 86 - 87 - $list->addProperty( 88 - pht('Editable By'), 89 - $descriptions[PhabricatorPolicyCapability::CAN_EDIT]); 90 - 91 83 $description = $space->getDescription(); 92 84 if (strlen($description)) { 93 85 $description = new PHUIRemarkupView($viewer, $description);