recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix "unmarked 0 inline comments as not undone" transactions

Summary:
Fixes T8483. I did this incorrectly in D13159, by doing it correctly first and then editing it carelessly. For most transaction types, it didn't matter, but did for inline state.

Also, clean up any bad inline state transactions.

Test Plan:
- Ran migration, bad transactions vanished.
- Marked some inline comments as done.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8483

Differential Revision: https://secure.phabricator.com/D13226

epriestley 9c82881c b8b4279a

+5
+4
resources/sql/autopatches/20150609.inline.sql
··· 1 + /* This cleans up some errant transactions, see T8483. */ 2 + 3 + DELETE FROM {$NAMESPACE}_differential.differential_transaction 4 + WHERE transactionType = 'core:inlinestate' AND newValue = 'null';
+1
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
··· 356 356 case PhabricatorTransactions::TYPE_BUILDABLE: 357 357 case PhabricatorTransactions::TYPE_TOKEN: 358 358 case PhabricatorTransactions::TYPE_INLINESTATE: 359 + return $xaction->getNewValue(); 359 360 case PhabricatorTransactions::TYPE_SPACE: 360 361 $space_phid = $xaction->getNewValue(); 361 362 if (!strlen($space_phid)) {