@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Restore psyduck to his proper place
Summary: Fixes T4665. The "attachable" logic was a little off after a recent change.
Test Plan: With and without a profile image, viewed a page.
Reviewers: btrahan, chad
Reviewed By: chad
Subscribers: epriestley
Maniphest Tasks: T4665
Differential Revision: https://secure.phabricator.com/D8594
+3
-5
+3
-5
src/applications/people/storage/PhabricatorUser.php
+3
-5
src/applications/people/storage/PhabricatorUser.php
···
652
652
}
653
653
654
654
public function loadProfileImageURI() {
655
-
if ($this->profileImage && $this->profileImage !== self::ATTACHABLE) {
655
+
if ($this->profileImage && ($this->profileImage !== self::ATTACHABLE)) {
656
656
return $this->profileImage;
657
657
}
658
658
···
664
664
$file = id(new PhabricatorFile())->loadOneWhere('phid = %s', $src_phid);
665
665
if ($file) {
666
666
$this->profileImage = $file->getBestURI();
667
+
return $this->profileImage;
667
668
}
668
669
}
669
670
670
-
if (!$this->profileImage) {
671
-
$this->profileImage = self::getDefaultProfileImageURI();
672
-
}
673
-
671
+
$this->profileImage = self::getDefaultProfileImageURI();
674
672
return $this->profileImage;
675
673
}
676
674