recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

parse with %s as `number_format()` returns stirng

Summary:
`number_format()` returns a string, so if passed a number greater than 999 by default it will add commas, which parsed by %d will only return the 1000's delimter.

```echo sprintf("%d", number_format(1000)); // Outputs 1
echo sprintf("%s", number_format(1000)); // Outputs 1,000

Test Plan: Looked at repos with over 999 commits.

Reviewers: epriestley, chad

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5913

authored by

Gareth Evans and committed by
epriestley 9c87ba8b c5929e37

+2 -2
+2 -2
src/applications/diffusion/controller/DiffusionHomeController.php
··· 94 94 'callsign' => $repository->getCallsign(), 95 95 'action' => 'history', 96 96 )), 97 - pht('%d Commits', number_format($size))); 97 + pht('%s Commits', new PhutilNumber($size))); 98 98 } 99 99 100 100 $lint_count = ''; ··· 110 110 'action' => 'lint', 111 111 )), 112 112 ), 113 - pht('%d Lint Messages', number_format($lint_branches[$branch]))); 113 + pht('%s Lint Messages', new PhutilNumber($lint_branches[$branch]))); 114 114 } 115 115 116 116 $datetime = '';