recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Don't require mentioned objects to have all required fields when editing comments

Summary: Fixes T12439. This pathway was just missing a `setContinueOnMissingFields(...)` to skip enforcement of required fields.

Test Plan:
- Added a required custom field.
- Mentioned any task without a field value in a comment.
- Edited that comment.
- Saved changes.
- Before fix: fatal in log.
- After fix: clean edit.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12439

Differential Revision: https://secure.phabricator.com/D17536

epriestley 9c998e98 5e16e460

+1
+1
src/applications/transactions/editor/PhabricatorApplicationTransactionCommentEditor.php
··· 92 92 $editor 93 93 ->setContentSource($this->getContentSource()) 94 94 ->setContinueOnNoEffect(true) 95 + ->setContinueOnMissingFields(true) 95 96 ->applyTransactions($object, $support_xactions); 96 97 } 97 98 }